* [PATCH] power: fan53555: Fix missing newline in error message
@ 2022-09-25 13:43 Michal Suchanek
2022-09-26 8:33 ` Peng Fan
2022-10-07 12:38 ` Jaehoon Chung
0 siblings, 2 replies; 3+ messages in thread
From: Michal Suchanek @ 2022-09-25 13:43 UTC (permalink / raw)
To: u-boot; +Cc: Michal Suchanek, Jaehoon Chung
Avoid concatenation with following message.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
drivers/power/pmic/fan53555.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c
index 4d1e686d27..0d91628f57 100644
--- a/drivers/power/pmic/fan53555.c
+++ b/drivers/power/pmic/fan53555.c
@@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
u8 *buff, int len)
{
if (dm_i2c_read(dev, reg, buff, len)) {
- pr_err("%s: read error for register: %#x!", dev->name, reg);
+ pr_err("%s: read error for register: %#x!\n", dev->name, reg);
return -EIO;
}
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: fan53555: Fix missing newline in error message
2022-09-25 13:43 [PATCH] power: fan53555: Fix missing newline in error message Michal Suchanek
@ 2022-09-26 8:33 ` Peng Fan
2022-10-07 12:38 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2022-09-26 8:33 UTC (permalink / raw)
To: Michal Suchanek, u-boot; +Cc: Jaehoon Chung
On 9/25/2022 9:43 PM, Michal Suchanek wrote:
> Avoid concatenation with following message.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> drivers/power/pmic/fan53555.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c
> index 4d1e686d27..0d91628f57 100644
> --- a/drivers/power/pmic/fan53555.c
> +++ b/drivers/power/pmic/fan53555.c
> @@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
> u8 *buff, int len)
> {
> if (dm_i2c_read(dev, reg, buff, len)) {
> - pr_err("%s: read error for register: %#x!", dev->name, reg);
> + pr_err("%s: read error for register: %#x!\n", dev->name, reg);
> return -EIO;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: fan53555: Fix missing newline in error message
2022-09-25 13:43 [PATCH] power: fan53555: Fix missing newline in error message Michal Suchanek
2022-09-26 8:33 ` Peng Fan
@ 2022-10-07 12:38 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2022-10-07 12:38 UTC (permalink / raw)
To: Michal Suchanek, u-boot; +Cc: Jaehoon Chung
On 9/25/22 22:43, Michal Suchanek wrote:
> Avoid concatenation with following message.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> drivers/power/pmic/fan53555.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/pmic/fan53555.c b/drivers/power/pmic/fan53555.c
> index 4d1e686d27..0d91628f57 100644
> --- a/drivers/power/pmic/fan53555.c
> +++ b/drivers/power/pmic/fan53555.c
> @@ -23,7 +23,7 @@ static int pmic_fan53555_read(struct udevice *dev, uint reg,
> u8 *buff, int len)
> {
> if (dm_i2c_read(dev, reg, buff, len)) {
> - pr_err("%s: read error for register: %#x!", dev->name, reg);
> + pr_err("%s: read error for register: %#x!\n", dev->name, reg);
> return -EIO;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-07 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 13:43 [PATCH] power: fan53555: Fix missing newline in error message Michal Suchanek
2022-09-26 8:33 ` Peng Fan
2022-10-07 12:38 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).