From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] efi_loader: remove support for CONFIG_LCD
Date: Thu, 14 Jul 2022 10:03:43 +0300 [thread overview]
Message-ID: <CAC_iWjK7Sf0uTW85xBHyMi=0SKtLZkBRx-zCHOXZCTb8_rETgw@mail.gmail.com> (raw)
In-Reply-To: <20220714064516.76166-1-heinrich.schuchardt@canonical.com>
On Thu, 14 Jul 2022 at 09:45, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> There is no board left using CONFIG_LCD without CONFIG_DM_VIDEO.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> lib/efi_loader/Makefile | 1 -
> lib/efi_loader/efi_gop.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index aaaa25cefe..f54c244c32 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -66,7 +66,6 @@ obj-$(CONFIG_EFI_VARIABLES_PRESEED) += efi_var_seed.o
> endif
> obj-y += efi_watchdog.o
> obj-$(CONFIG_EFI_ESRT) += efi_esrt.o
> -obj-$(CONFIG_LCD) += efi_gop.o
> obj-$(CONFIG_DM_VIDEO) += efi_gop.o
> obj-$(CONFIG_BLK) += efi_disk.o
> obj-$(CONFIG_NET) += efi_net.o
> diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
> index 2c81859807..5908b5c646 100644
> --- a/lib/efi_loader/efi_gop.c
> +++ b/lib/efi_loader/efi_gop.c
> @@ -8,7 +8,6 @@
> #include <common.h>
> #include <dm.h>
> #include <efi_loader.h>
> -#include <lcd.h>
> #include <log.h>
> #include <malloc.h>
> #include <video.h>
> @@ -459,11 +458,7 @@ efi_status_t EFIAPI gop_blt(struct efi_gop *this, struct efi_gop_pixel *buffer,
> if (ret != EFI_SUCCESS)
> return EFI_EXIT(ret);
>
> -#ifdef CONFIG_DM_VIDEO
> video_sync_all();
> -#else
> - lcd_sync();
> -#endif
>
> return EFI_EXIT(EFI_SUCCESS);
> }
> --
> 2.36.1
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
prev parent reply other threads:[~2022-07-14 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 6:45 [PATCH 1/1] efi_loader: remove support for CONFIG_LCD Heinrich Schuchardt
2022-07-14 7:03 ` Ilias Apalodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC_iWjK7Sf0uTW85xBHyMi=0SKtLZkBRx-zCHOXZCTb8_rETgw@mail.gmail.com' \
--to=ilias.apalodimas@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).