[PATCH 1/1] efi_loader: remove support for CONFIG_LCD

[PATCH 1/1] efi_loader: remove support for CONFIG_LCD

[Heinrich Schuchardt]

There is no board left using CONFIG_LCD without CONFIG_DM_VIDEO.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/efi_loader/Makefile  | 1 -
 lib/efi_loader/efi_gop.c | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
index aaaa25cefe..f54c244c32 100644
--- a/lib/efi_loader/Makefile
+++ b/lib/efi_loader/Makefile
@@ -66,7 +66,6 @@ obj-$(CONFIG_EFI_VARIABLES_PRESEED) += efi_var_seed.o
 endif
 obj-y += efi_watchdog.o
 obj-$(CONFIG_EFI_ESRT) += efi_esrt.o
-obj-$(CONFIG_LCD) += efi_gop.o
 obj-$(CONFIG_DM_VIDEO) += efi_gop.o
 obj-$(CONFIG_BLK) += efi_disk.o
 obj-$(CONFIG_NET) += efi_net.o
diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
index 2c81859807..5908b5c646 100644
--- a/lib/efi_loader/efi_gop.c
+++ b/lib/efi_loader/efi_gop.c
@@ -8,7 +8,6 @@
 #include <common.h>
 #include <dm.h>
 #include <efi_loader.h>
-#include <lcd.h>
 #include <log.h>
 #include <malloc.h>
 #include <video.h>
@@ -459,11 +458,7 @@ efi_status_t EFIAPI gop_blt(struct efi_gop *this, struct efi_gop_pixel *buffer,
 	if (ret != EFI_SUCCESS)
 		return EFI_EXIT(ret);
 
-#ifdef CONFIG_DM_VIDEO
 	video_sync_all();
-#else
-	lcd_sync();
-#endif
 
 	return EFI_EXIT(EFI_SUCCESS);
 }
-- 
2.36.1

Re: [PATCH 1/1] efi_loader: remove support for CONFIG_LCD

[Ilias Apalodimas]

On Thu, 14 Jul 2022 at 09:45, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> There is no board left using CONFIG_LCD without CONFIG_DM_VIDEO.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/efi_loader/Makefile  | 1 -
>  lib/efi_loader/efi_gop.c | 5 -----
>  2 files changed, 6 deletions(-)
>
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index aaaa25cefe..f54c244c32 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -66,7 +66,6 @@ obj-$(CONFIG_EFI_VARIABLES_PRESEED) += efi_var_seed.o
>  endif
>  obj-y += efi_watchdog.o
>  obj-$(CONFIG_EFI_ESRT) += efi_esrt.o
> -obj-$(CONFIG_LCD) += efi_gop.o
>  obj-$(CONFIG_DM_VIDEO) += efi_gop.o
>  obj-$(CONFIG_BLK) += efi_disk.o
>  obj-$(CONFIG_NET) += efi_net.o
> diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
> index 2c81859807..5908b5c646 100644
> --- a/lib/efi_loader/efi_gop.c
> +++ b/lib/efi_loader/efi_gop.c
> @@ -8,7 +8,6 @@
>  #include <common.h>
>  #include <dm.h>
>  #include <efi_loader.h>
> -#include <lcd.h>
>  #include <log.h>
>  #include <malloc.h>
>  #include <video.h>
> @@ -459,11 +458,7 @@ efi_status_t EFIAPI gop_blt(struct efi_gop *this, struct efi_gop_pixel *buffer,
>         if (ret != EFI_SUCCESS)
>                 return EFI_EXIT(ret);
>
> -#ifdef CONFIG_DM_VIDEO
>         video_sync_all();
> -#else
> -       lcd_sync();
> -#endif
>
>         return EFI_EXIT(EFI_SUCCESS);
>  }
> --
> 2.36.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>