u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2
@ 2021-09-11 18:27 Andy Shevchenko
  2021-09-19  8:06 ` Bin Meng
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-09-11 18:27 UTC (permalink / raw)
  To: Andy Shevchenko, u-boot; +Cc: Simon Glass, Bin Meng

On Intel Tangier the SDHCI #2 provides SD card connection.
Add GPIO card detection for it.

Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier")
BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Bin Meng <bmeng.cn@gmail.com>
---
v3: basically returned to the content of v2 (pull bias back to none)
    since there is nothing special about the signal which is supposed
    to be triggered by both edges

 .../asm/arch-tangier/acpi/southcluster.asl    | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index 01077293bb91..41facdde6a3d 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -97,6 +97,38 @@ Device (PCI0)
         }
     }
 
+    Device (SDHB)
+    {
+        Name (_ADR, 0x00010002)
+        Name (_DEP, Package ()
+        {
+            GPIO
+        })
+
+        Name (RBUF, ResourceTemplate()
+        {
+            GpioInt(Edge, ActiveBoth, SharedAndWake, PullNone, 10000,
+                "\\_SB.PCI0.GPIO", 0, ResourceConsumer, , ) { 77 }
+        })
+
+        Method (_CRS, 0, Serialized)
+        {
+            Return (RBUF)
+        }
+
+        Name (_DSD, Package () {
+            ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+            Package () {
+                Package () { "cd-gpios", Package () { ^SDHB, 0, 0, 0 } },
+            }
+        })
+
+        Method (_STA)
+        {
+            Return (STA_VISIBLE)
+        }
+    }
+
     Device (SDHC)
     {
         Name (_ADR, 0x00010003)
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2
  2021-09-11 18:27 [PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2 Andy Shevchenko
@ 2021-09-19  8:06 ` Bin Meng
  0 siblings, 0 replies; 2+ messages in thread
From: Bin Meng @ 2021-09-19  8:06 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: U-Boot Mailing List, Simon Glass

On Sun, Sep 12, 2021 at 2:27 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Intel Tangier the SDHCI #2 provides SD card connection.
> Add GPIO card detection for it.
>
> Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier")
> BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> v3: basically returned to the content of v2 (pull bias back to none)
>     since there is nothing special about the signal which is supposed
>     to be triggered by both edges
>
>  .../asm/arch-tangier/acpi/southcluster.asl    | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-19  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 18:27 [PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2 Andy Shevchenko
2021-09-19  8:06 ` Bin Meng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).