From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: Eugen.Hristev@microchip.com
Cc: sjg@chromium.org, Balamanikandan.Gunasundar@microchip.com,
u-boot@lists.denx.de, Sandeep.Sheriker@microchip.com,
dario.binacchi@amarulasolutions.com, Mihai.Sain@microchip.com,
Sergiu.Moga@microchip.com, Claudiu.Beznea@microchip.com,
hs@denx.de, Tudor.Ambarus@microchip.com, ascull@google.com,
kettenis@openbsd.org, jh80.chung@samsung.com, peng.fan@nxp.com,
ye.li@nxp.com, Hari.PrasathGE@microchip.com
Subject: Re: [PATCH v2 0/9] Add DM support for atmel NAND driver
Date: Wed, 31 Aug 2022 08:37:20 +0200 [thread overview]
Message-ID: <CAOf5uwmxxETD2TPGZGgHvDr1f+XUAx1E=S0Rd=YX7KfE3FBKUw@mail.gmail.com> (raw)
In-Reply-To: <98449704-0e25-877d-e1af-9e31bebcd7de@microchip.com>
Hi
On Wed, Aug 31, 2022 at 8:34 AM <Eugen.Hristev@microchip.com> wrote:
>
> On 8/30/22 5:30 AM, Simon Glass wrote:
> > Hi,
> >
> > On Mon, 29 Aug 2022 at 00:41, Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> >>
> >> Hi
> >>
> >> On Mon, Aug 29, 2022 at 8:19 AM Balamanikandan Gunasundar
> >> <balamanikandan.gunasundar@microchip.com> wrote:
> >>>
> >>> Change include:
> >>>
> >>> - Adapt GPIO descriptor apis for U-Boot. Use
> >>> gpio_request_by_name_nodev, dm_gpio_get_value etc.
> >>> - Use U_BOOT_DRIVER instead of platform_driver.
> >>> - Replace struct platform_device with struct udevice
> >>> - Check the status of nfc exec operation by polling the status
> >>> register instead of interrupt based handling
> >>> - DMA operations not supported. Remove it
> >>> - Adapt DT parsing to U-Boot APIs
> >>>
> >>> v2:
> >>>
> >>> - Add linux reference version in the commit message from which the
> >>> driver is ported from
> >>> - Reword the commit message to describe the changes clearly
> >>>
> >>
> >> Thank you to repost it again, I will review it and try to include soon
> >>
> >> Michael
> >>
> >>> Balamanikandan Gunasundar (9):
> >>> nand: atmel: Add DM based NAND driver
> >>> nand: atmel: Add pmecc driver
> >>> mfd: syscon: Add atmel-matrix registers definition
> >>> memory: atmel-ebi: add Atmel EBI (External Bus Interface) driver
> >>> mfd: syscon: atmel-smc: Add driver for atmel SMC
> >>> configs: at91: sam9x60ek: Enable DM based nand driver
> >>> ARM: dts: at91: sam9x60: Add nodes for EBI and NAND
> >>> ARM: dts: at91: sam9x60ek: Enable NAND support
> >>> board: sam9x60ek: remove nand init from board file
> >>>
> >>> MAINTAINERS | 1 +
> >>> arch/arm/dts/sam9x60.dtsi | 42 +
> >>> arch/arm/dts/sam9x60ek.dts | 103 +
> >>> board/atmel/sam9x60ek/sam9x60ek.c | 59 -
> >>> configs/sam9x60ek_mmc_defconfig | 9 +-
> >>> configs/sam9x60ek_nandflash_defconfig | 9 +-
> >>> configs/sam9x60ek_qspiflash_defconfig | 8 +-
> >>> drivers/Kconfig | 2 +
> >>> drivers/Makefile | 1 +
> >>> drivers/memory/Kconfig | 7 +
> >>> drivers/memory/Makefile | 1 +
> >>> drivers/memory/atmel_ebi.c | 37 +
> >>> drivers/mfd/Kconfig | 4 +
> >>> drivers/mfd/Makefile | 1 +
> >>> drivers/mfd/atmel-smc.c | 364 +++
> >>> drivers/mtd/nand/raw/Kconfig | 8 +
> >>> drivers/mtd/nand/raw/Makefile | 1 +
> >>> drivers/mtd/nand/raw/atmel/Makefile | 5 +
> >>> drivers/mtd/nand/raw/atmel/nand-controller.c | 2293 ++++++++++++++++++
> >>> drivers/mtd/nand/raw/atmel/pmecc.c | 965 ++++++++
> >>> drivers/mtd/nand/raw/atmel/pmecc.h | 94 +
> >>> include/configs/sam9x60ek.h | 5 -
> >>> include/linux/mfd/syscon/atmel-matrix.h | 112 +
> >>> include/linux/mfd/syscon/atmel-smc.h | 119 +
> >>> 24 files changed, 4177 insertions(+), 73 deletions(-)
> >>> create mode 100644 drivers/memory/atmel_ebi.c
> >>> create mode 100644 drivers/mfd/Kconfig
> >>> create mode 100644 drivers/mfd/Makefile
> >>> create mode 100644 drivers/mfd/atmel-smc.c
> >>> create mode 100644 drivers/mtd/nand/raw/atmel/Makefile
> >>> create mode 100644 drivers/mtd/nand/raw/atmel/nand-controller.c
> >>> create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.c
> >>> create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.h
> >>> create mode 100644 include/linux/mfd/syscon/atmel-matrix.h
> >>> create mode 100644 include/linux/mfd/syscon/atmel-smc.h
> >>>
> >>> --
> >>> 2.34.1
> >>>
> >
> > Once this series is in, I wonder if it might be possible to drop the
> > nand_init() call and have this happen as needed, i.e. lazy init?
> >
> > Regards,
> > Simon
> >
>
> Hi Simon,
>
> nand_init() should be called if nand is accessed. Do you have a specific
> place in mind where this call is not appropriate, and should be removed ?
>
Those are different topics, I would like to keep them split. Anyway I think that
nand should work as mmc for initialization. I put a note to make it happen.
> Hi Michael,
>
> If you want to review this series, please do, I would like this to fit
> into the next merge window for 2023.01 , but if it needs more time,
> that's fine.
Yes, I will look at it tomorrow
Michael
>
> Eugen
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
next prev parent reply other threads:[~2022-08-31 6:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 6:19 [PATCH v2 0/9] Add DM support for atmel NAND driver Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 1/9] nand: atmel: Add DM based " Balamanikandan Gunasundar
2022-09-05 8:55 ` Eugen.Hristev
2022-08-29 6:19 ` [PATCH v2 2/9] nand: atmel: Add pmecc driver Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 3/9] mfd: syscon: Add atmel-matrix registers definition Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 4/9] memory: atmel-ebi: add Atmel EBI (External Bus Interface) driver Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 5/9] mfd: syscon: atmel-smc: Add driver for atmel SMC Balamanikandan Gunasundar
2022-08-31 12:53 ` Michael Nazzareno Trimarchi
2022-09-30 11:02 ` Michael Nazzareno Trimarchi
2022-09-30 14:00 ` Tom Rini
2022-08-29 6:19 ` [PATCH v2 6/9] configs: at91: sam9x60ek: Enable DM based nand driver Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 7/9] ARM: dts: at91: sam9x60: Add nodes for EBI and NAND Balamanikandan Gunasundar
2022-08-29 6:19 ` [PATCH v2 8/9] ARM: dts: at91: sam9x60ek: Enable NAND support Balamanikandan Gunasundar
2022-08-31 13:14 ` Michael Nazzareno Trimarchi
2022-08-31 13:31 ` Eugen.Hristev
2022-08-31 14:19 ` Michael Nazzareno Trimarchi
2022-09-01 5:57 ` Eugen.Hristev
2022-09-20 8:41 ` Dario Binacchi
2022-08-29 6:19 ` [PATCH v2 9/9] board: sam9x60ek: remove nand init from board file Balamanikandan Gunasundar
2022-08-29 6:41 ` [PATCH v2 0/9] Add DM support for atmel NAND driver Michael Nazzareno Trimarchi
2022-08-30 2:30 ` Simon Glass
2022-08-31 6:34 ` Eugen.Hristev
2022-08-31 6:37 ` Michael Nazzareno Trimarchi [this message]
2022-08-31 13:46 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOf5uwmxxETD2TPGZGgHvDr1f+XUAx1E=S0Rd=YX7KfE3FBKUw@mail.gmail.com' \
--to=michael@amarulasolutions.com \
--cc=Balamanikandan.Gunasundar@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=Sandeep.Sheriker@microchip.com \
--cc=Sergiu.Moga@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=ascull@google.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=hs@denx.de \
--cc=jh80.chung@samsung.com \
--cc=kettenis@openbsd.org \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).