* [PATCH] common: board_r: print error if binman_init fails
@ 2021-07-16 22:44 Tim Harvey
2021-07-20 17:42 ` Simon Glass
2021-07-24 21:12 ` Simon Glass
0 siblings, 2 replies; 3+ messages in thread
From: Tim Harvey @ 2021-07-16 22:44 UTC (permalink / raw)
To: u-boot, Simon Glass; +Cc: Tim Harvey
Display an error if binman_init fails.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
common/board_r.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/common/board_r.c b/common/board_r.c
index 3f82404772..e3e6248a1f 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -323,10 +323,16 @@ static int initr_manual_reloc_cmdtable(void)
static int initr_binman(void)
{
+ int ret;
+
if (!CONFIG_IS_ENABLED(BINMAN_FDT))
return 0;
- return binman_init();
+ ret = binman_init();
+ if (ret)
+ printf("binman_init failed:%d\n", ret);
+
+ return ret;
}
#if defined(CONFIG_MTD_NOR_FLASH)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] common: board_r: print error if binman_init fails
2021-07-16 22:44 [PATCH] common: board_r: print error if binman_init fails Tim Harvey
@ 2021-07-20 17:42 ` Simon Glass
2021-07-24 21:12 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-07-20 17:42 UTC (permalink / raw)
To: Tim Harvey; +Cc: U-Boot Mailing List
Hi Tim,
On Fri, 16 Jul 2021 at 16:44, Tim Harvey <tharvey@gateworks.com> wrote:
>
> Display an error if binman_init fails.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> common/board_r.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/common/board_r.c b/common/board_r.c
> index 3f82404772..e3e6248a1f 100644
> --- a/common/board_r.c
> +++ b/common/board_r.c
> @@ -323,10 +323,16 @@ static int initr_manual_reloc_cmdtable(void)
>
> static int initr_binman(void)
> {
> + int ret;
> +
> if (!CONFIG_IS_ENABLED(BINMAN_FDT))
> return 0;
>
> - return binman_init();
> + ret = binman_init();
> + if (ret)
> + printf("binman_init failed:%d\n", ret);
How about log_err() instead of printf() ?
> +
> + return ret;
> }
>
> #if defined(CONFIG_MTD_NOR_FLASH)
> --
> 2.17.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] common: board_r: print error if binman_init fails
2021-07-16 22:44 [PATCH] common: board_r: print error if binman_init fails Tim Harvey
2021-07-20 17:42 ` Simon Glass
@ 2021-07-24 21:12 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-07-24 21:12 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List, Tim Harvey
Hi Tim,
On Fri, 16 Jul 2021 at 16:44, Tim Harvey <tharvey@gateworks.com> wrote:
>
> Display an error if binman_init fails.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> common/board_r.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-24 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 22:44 [PATCH] common: board_r: print error if binman_init fails Tim Harvey
2021-07-20 17:42 ` Simon Glass
2021-07-24 21:12 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).