u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] efi_loader: remove duplicate assignment
Date: Sun, 2 Apr 2023 14:38:31 +1200	[thread overview]
Message-ID: <CAPnjgZ0jdA5uCqvhJo3yCXiiRDsz_ryFG+bjj+ApcH3ns389Pw@mail.gmail.com> (raw)
In-Reply-To: <20230401053013.19294-1-heinrich.schuchardt@canonical.com>

On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> Assigning the value of a variable to itself should be avoided.
>
> Addresses-Coverity-ID: 451089 ("Evaluation order violation")
> Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/efi_loader/efi_device_path.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2023-04-02  2:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  5:30 [PATCH 1/1] efi_loader: remove duplicate assignment Heinrich Schuchardt
2023-04-02  2:38 ` Simon Glass [this message]
2023-04-03  5:58   ` Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0jdA5uCqvhJo3yCXiiRDsz_ryFG+bjj+ApcH3ns389Pw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).