* [PATCH 1/1] efi_loader: remove duplicate assignment
@ 2023-04-01 5:30 Heinrich Schuchardt
2023-04-02 2:38 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2023-04-01 5:30 UTC (permalink / raw)
To: Ilias Apalodimas; +Cc: u-boot, Heinrich Schuchardt
Assigning the value of a variable to itself should be avoided.
Addresses-Coverity-ID: 451089 ("Evaluation order violation")
Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
lib/efi_loader/efi_device_path.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index b6dd575b13..39e301450c 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -749,7 +749,7 @@ __maybe_unused static void *dp_fill(void *buf, struct udevice *dev)
#endif
#if defined(CONFIG_USB)
case UCLASS_MASS_STORAGE: {
- struct blk_desc *desc = desc = dev_get_uclass_plat(dev);
+ struct blk_desc *desc = dev_get_uclass_plat(dev);
struct efi_device_path_controller *dp =
dp_fill(buf, dev->parent);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] efi_loader: remove duplicate assignment
2023-04-01 5:30 [PATCH 1/1] efi_loader: remove duplicate assignment Heinrich Schuchardt
@ 2023-04-02 2:38 ` Simon Glass
2023-04-03 5:58 ` Ilias Apalodimas
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2023-04-02 2:38 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Ilias Apalodimas, U-Boot Mailing List
On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> Assigning the value of a variable to itself should be avoided.
>
> Addresses-Coverity-ID: 451089 ("Evaluation order violation")
> Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> lib/efi_loader/efi_device_path.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] efi_loader: remove duplicate assignment
2023-04-02 2:38 ` Simon Glass
@ 2023-04-03 5:58 ` Ilias Apalodimas
0 siblings, 0 replies; 3+ messages in thread
From: Ilias Apalodimas @ 2023-04-03 5:58 UTC (permalink / raw)
To: Simon Glass; +Cc: Heinrich Schuchardt, U-Boot Mailing List
On Sun, 2 Apr 2023 at 05:38, Simon Glass <sjg@chromium.org> wrote:
>
> On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> >
> > Assigning the value of a variable to itself should be avoided.
> >
> > Addresses-Coverity-ID: 451089 ("Evaluation order violation")
> > Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> > lib/efi_loader/efi_device_path.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-03 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-01 5:30 [PATCH 1/1] efi_loader: remove duplicate assignment Heinrich Schuchardt
2023-04-02 2:38 ` Simon Glass
2023-04-03 5:58 ` Ilias Apalodimas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).