Re: [PATCH v3 4/7] cmd: fru: add product info area parsing support

From: Simon Glass <sjg@chromium.org>
To: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Cc: "Michal Simek" <michal.simek@amd.com>,
	"Ovidiu Panait" <ovidiu.panait@windriver.com>,
	"Mario Six" <mario.six@gdsys.cc>,
	"Masahisa Kojima" <masahisa.kojima@linaro.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Ashok Reddy Soma" <ashok.reddy.soma@xilinx.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Huang Jianan" <jnhuang95@gmail.com>,
	"Chris Morgan" <macromorgan@hotmail.com>,
	"Roland Gaudig" <roland.gaudig@weidmueller.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Alexandru Gagniuc" <mr.nuke.me@gmail.com>,
	"Jamie Iles" <quic_jiles@quicinc.com>,
	"Graeme Gregory" <quic_ggregory@quicinc.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 4/7] cmd: fru: add product info area parsing support
Date: Wed, 24 Aug 2022 18:25:38 -0700	[thread overview]
Message-ID: <CAPnjgZ1PcX4v9jLv5yPggiUAMJQ0MmxrAP0Sq-=GKn6G_z-t3A@mail.gmail.com> (raw)
In-Reply-To: <20220823215300.1485789-5-quic_jaehyoo@quicinc.com>

Hi Jae,

On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>
> Add product info area parsing support. Custom board fields can be
> added dynamically using linked list so that each board support can
> utilize them in their own custom way.
>
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> ---
> Changes from v2:
>  * Changed 'struct fru_board_info_member' to 'struct fru_common_info_member'.
>
> Changes from v1:
>  * Refactored using linked list instead of calling a custom parsing callback.
>
> Changes from RFC:
>  * Added manufacturer custom product info fields parsing flow.
>
>  cmd/fru.c     |  28 ++++--
>  include/fru.h |  34 ++++++-
>  lib/fru_ops.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++---
>  3 files changed, 286 insertions(+), 20 deletions(-)
>

Please add tests for this code.

Regards,
Simon