* [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl
@ 2022-03-23 18:26 ` Sean Anderson
2022-03-23 19:01 ` Simon Glass
2022-03-28 23:21 ` Jaehoon Chung
0 siblings, 2 replies; 3+ messages in thread
From: Sean Anderson @ 2022-03-23 18:26 UTC (permalink / raw)
To: u-boot, Tom Rini
Cc: Patrick Delaunay, Simon Glass, Lokesh Vutla, Anatolij Gustschin,
Sean Anderson, Jaehoon Chung
If dev_count_phandle_with_args returns 0 or another error, then pd will never
have been initialized by power_domain_get_by_index. Avoid comparing against
pd.dev in this situation.
Fixes: 3e4fcfa4bc ("power-domain: fix hang in endless loop on i.MX8")
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
drivers/power/domain/power-domain-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/domain/power-domain-uclass.c b/drivers/power/domain/power-domain-uclass.c
index 33f9206bd0..1a317a00aa 100644
--- a/drivers/power/domain/power-domain-uclass.c
+++ b/drivers/power/domain/power-domain-uclass.c
@@ -137,7 +137,7 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on)
* off their power-domain parent. So we will get here again and
* again and will be stuck in an endless loop.
*/
- if (!on && dev_get_parent(dev) == pd.dev &&
+ if (count > 0 && !on && dev_get_parent(dev) == pd.dev &&
device_get_uclass_id(dev) == UCLASS_POWER_DOMAIN)
return ret;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl
2022-03-23 18:26 ` [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl Sean Anderson
@ 2022-03-23 19:01 ` Simon Glass
2022-03-28 23:21 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-03-23 19:01 UTC (permalink / raw)
To: Sean Anderson
Cc: U-Boot Mailing List, Tom Rini, Patrick Delaunay, Lokesh Vutla,
Anatolij Gustschin, Jaehoon Chung
On Wed, 23 Mar 2022 at 12:26, Sean Anderson <seanga2@gmail.com> wrote:
>
> If dev_count_phandle_with_args returns 0 or another error, then pd will never
> have been initialized by power_domain_get_by_index. Avoid comparing against
> pd.dev in this situation.
>
> Fixes: 3e4fcfa4bc ("power-domain: fix hang in endless loop on i.MX8")
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>
> drivers/power/domain/power-domain-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl
2022-03-23 18:26 ` [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl Sean Anderson
2022-03-23 19:01 ` Simon Glass
@ 2022-03-28 23:21 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2022-03-28 23:21 UTC (permalink / raw)
To: Sean Anderson, u-boot, Tom Rini
Cc: Patrick Delaunay, Simon Glass, Lokesh Vutla, Anatolij Gustschin
On 3/24/22 03:26, Sean Anderson wrote:
> If dev_count_phandle_with_args returns 0 or another error, then pd will never
> have been initialized by power_domain_get_by_index. Avoid comparing against
> pd.dev in this situation.
>
> Fixes: 3e4fcfa4bc ("power-domain: fix hang in endless loop on i.MX8")
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> drivers/power/domain/power-domain-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/domain/power-domain-uclass.c b/drivers/power/domain/power-domain-uclass.c
> index 33f9206bd0..1a317a00aa 100644
> --- a/drivers/power/domain/power-domain-uclass.c
> +++ b/drivers/power/domain/power-domain-uclass.c
> @@ -137,7 +137,7 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on)
> * off their power-domain parent. So we will get here again and
> * again and will be stuck in an endless loop.
> */
> - if (!on && dev_get_parent(dev) == pd.dev &&
> + if (count > 0 && !on && dev_get_parent(dev) == pd.dev &&
> device_get_uclass_id(dev) == UCLASS_POWER_DOMAIN)
> return ret;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-28 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220323182624epcas1p1fb76eeceb6c8b659c9f8f2a82cc89f5b@epcas1p1.samsung.com>
2022-03-23 18:26 ` [PATCH] power-domain: Fix use of uninitialized value in dev_power_domain_ctrl Sean Anderson
2022-03-23 19:01 ` Simon Glass
2022-03-28 23:21 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).