* [PATCH] rockchip: Fix the broken Video out for rk3288 boards
@ 2023-01-02 18:23 Jagan Teki
2023-01-04 20:01 ` Simon Glass
2023-01-06 16:52 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Jagan Teki @ 2023-01-02 18:23 UTC (permalink / raw)
To: Kever Yang, Philipp Tomsich
Cc: u-boot, Tom Rini, linux-amarula, Jagan Teki, Simon Glass,
Lin Huang, Jernej Skrabec, Michael Trimarchi, Arnaud Patard,
Manoj Sai
Video out on RK3288 boards has been broken since from few
releases due to the adding of reset support on vop but
missed enabling DM_RESET on associated boards.
This patch fixes those RK3288 boards.
Cc: Simon Glass <sjg@chromium.org>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
configs/evb-rk3288_defconfig | 1 +
configs/firefly-rk3288_defconfig | 1 +
configs/miqi-rk3288_defconfig | 1 +
configs/rock-pi-n8-rk3288_defconfig | 1 +
configs/tinker-rk3288_defconfig | 1 +
configs/tinker-s-rk3288_defconfig | 1 +
configs/vyasa-rk3288_defconfig | 1 +
7 files changed, 7 insertions(+)
diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
index 7c0b856ca5..2c2c679b29 100644
--- a/configs/evb-rk3288_defconfig
+++ b/configs/evb-rk3288_defconfig
@@ -80,6 +80,7 @@ CONFIG_DM_REGULATOR_FIXED=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index 63c53a0248..12ed055acf 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -77,6 +77,7 @@ CONFIG_DM_REGULATOR_FIXED=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
index 0811e70dce..2cf0efc816 100644
--- a/configs/miqi-rk3288_defconfig
+++ b/configs/miqi-rk3288_defconfig
@@ -74,6 +74,7 @@ CONFIG_DM_REGULATOR_FIXED=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/rock-pi-n8-rk3288_defconfig b/configs/rock-pi-n8-rk3288_defconfig
index 4ed98c0a51..757d99b8b5 100644
--- a/configs/rock-pi-n8-rk3288_defconfig
+++ b/configs/rock-pi-n8-rk3288_defconfig
@@ -73,6 +73,7 @@ CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
# CONFIG_RAM_ROCKCHIP_DEBUG is not set
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
index 85d94a6ea8..e69ef6875f 100644
--- a/configs/tinker-rk3288_defconfig
+++ b/configs/tinker-rk3288_defconfig
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/tinker-s-rk3288_defconfig b/configs/tinker-s-rk3288_defconfig
index 7dfbad8083..eb153dc8d5 100644
--- a/configs/tinker-s-rk3288_defconfig
+++ b/configs/tinker-s-rk3288_defconfig
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
diff --git a/configs/vyasa-rk3288_defconfig b/configs/vyasa-rk3288_defconfig
index cbae60f987..f503cc1604 100644
--- a/configs/vyasa-rk3288_defconfig
+++ b/configs/vyasa-rk3288_defconfig
@@ -82,6 +82,7 @@ CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_RAM=y
CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYSRESET=y
CONFIG_USB=y
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rockchip: Fix the broken Video out for rk3288 boards
2023-01-02 18:23 [PATCH] rockchip: Fix the broken Video out for rk3288 boards Jagan Teki
@ 2023-01-04 20:01 ` Simon Glass
2023-01-06 16:52 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2023-01-04 20:01 UTC (permalink / raw)
To: Jagan Teki
Cc: Kever Yang, Philipp Tomsich, u-boot, Tom Rini, linux-amarula,
Lin Huang, Jernej Skrabec, Michael Trimarchi, Arnaud Patard,
Manoj Sai
On Mon, 2 Jan 2023 at 11:24, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Video out on RK3288 boards has been broken since from few
> releases due to the adding of reset support on vop but
> missed enabling DM_RESET on associated boards.
>
> This patch fixes those RK3288 boards.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
> Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
> Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> configs/evb-rk3288_defconfig | 1 +
> configs/firefly-rk3288_defconfig | 1 +
> configs/miqi-rk3288_defconfig | 1 +
> configs/rock-pi-n8-rk3288_defconfig | 1 +
> configs/tinker-rk3288_defconfig | 1 +
> configs/tinker-s-rk3288_defconfig | 1 +
> configs/vyasa-rk3288_defconfig | 1 +
> 7 files changed, 7 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
This should get in for the release
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rockchip: Fix the broken Video out for rk3288 boards
2023-01-02 18:23 [PATCH] rockchip: Fix the broken Video out for rk3288 boards Jagan Teki
2023-01-04 20:01 ` Simon Glass
@ 2023-01-06 16:52 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-01-06 16:52 UTC (permalink / raw)
To: Jagan Teki
Cc: Kever Yang, Philipp Tomsich, u-boot, linux-amarula, Simon Glass,
Lin Huang, Jernej Skrabec, Michael Trimarchi, Arnaud Patard,
Manoj Sai
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Mon, Jan 02, 2023 at 11:53:45PM +0530, Jagan Teki wrote:
> Video out on RK3288 boards has been broken since from few
> releases due to the adding of reset support on vop but
> missed enabling DM_RESET on associated boards.
>
> This patch fixes those RK3288 boards.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Lin Huang <hl@rock-chips.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
> Fixes: <9749d2ea29e1> ("rockchip: video: vop: Add reset support")
> Reported-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-06 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 18:23 [PATCH] rockchip: Fix the broken Video out for rk3288 boards Jagan Teki
2023-01-04 20:01 ` Simon Glass
2023-01-06 16:52 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).