* [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()
@ 2023-04-01 6:24 Heinrich Schuchardt
2023-04-02 2:37 ` Simon Glass
2023-04-22 16:51 ` Simon Glass
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2023-04-01 6:24 UTC (permalink / raw)
To: Marek Vasut, Simon Glass
Cc: Sean Anderson, Andrew Scull, u-boot, Heinrich Schuchardt
Handling of SANDBOX_FLASH_EP_OUT should never fall through to
SANDBOX_FLASH_EP_IN.
This addresses a warning shown when compiling with
-Wimplicit-fallthrough.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
drivers/usb/emul/sandbox_flash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox_flash.c
index 01ccc4bc17..7c5c1ab3de 100644
--- a/drivers/usb/emul/sandbox_flash.c
+++ b/drivers/usb/emul/sandbox_flash.c
@@ -266,6 +266,7 @@ static int sandbox_flash_bulk(struct udevice *dev, struct usb_device *udev,
default:
break;
}
+ break;
case SANDBOX_FLASH_EP_IN:
switch (info->phase) {
case SCSIPH_DATA:
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()
2023-04-01 6:24 [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk() Heinrich Schuchardt
@ 2023-04-02 2:37 ` Simon Glass
2023-04-22 16:51 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2023-04-02 2:37 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Marek Vasut, Sean Anderson, Andrew Scull, U-Boot Mailing List
On Sat, 1 Apr 2023 at 19:25, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> Handling of SANDBOX_FLASH_EP_OUT should never fall through to
> SANDBOX_FLASH_EP_IN.
>
> This addresses a warning shown when compiling with
> -Wimplicit-fallthrough.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> drivers/usb/emul/sandbox_flash.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()
2023-04-01 6:24 [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk() Heinrich Schuchardt
2023-04-02 2:37 ` Simon Glass
@ 2023-04-22 16:51 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2023-04-22 16:51 UTC (permalink / raw)
To: Simon Glass
Cc: Marek Vasut, Sean Anderson, Andrew Scull, U-Boot Mailing List,
Heinrich Schuchardt
On Sat, 1 Apr 2023 at 19:25, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> Handling of SANDBOX_FLASH_EP_OUT should never fall through to
> SANDBOX_FLASH_EP_IN.
>
> This addresses a warning shown when compiling with
> -Wimplicit-fallthrough.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> drivers/usb/emul/sandbox_flash.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-22 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-01 6:24 [PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk() Heinrich Schuchardt
2023-04-02 2:37 ` Simon Glass
2023-04-22 16:51 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).