From: Simon Glass <sjg@chromium.org>
To: Mark Kettenis <kettenis@openbsd.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Anatolij Gustschin <agust@denx.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH 3/3] video: simplefb: Add 30bpp support
Date: Sat, 25 Sep 2021 07:41:00 -0600 [thread overview]
Message-ID: <CAPnjgZ3vmFXZiCShnbonDohB=gDP46qH79GoJXcb0AaZOjkzGw@mail.gmail.com> (raw)
In-Reply-To: <20210916130117.20894-4-kettenis@openbsd.org>
On Thu, 16 Sept 2021 at 07:02, Mark Kettenis <kettenis@openbsd.org> wrote:
>
> Recognize the canonical format strings for framebuffers in
> 30bpp mode.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> drivers/video/simplefb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index fd58426cf5..7e1cc4560f 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -52,6 +52,9 @@ static int simple_video_probe(struct udevice *dev)
> uc_priv->bpix = VIDEO_BPP16;
> } else if (strcmp(format, "a8b8g8r8") == 0) {
> uc_priv->bpix = VIDEO_BPP32;
> + } else if (strcmp(format, "a2r10g10b10") == 0 ||
> + strcmp(format, "x2r10g10b10") == 0) {
> + uc_priv->bpix = VIDEO_BPP30;
> } else {
> printf("%s: invalid format: %s\n", __func__, format);
> return -EINVAL;
> --
> 2.33.0
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested on: Macbook Air M1
Tested-by: Simon Glass <sjg@chromium.org>
prev parent reply other threads:[~2021-09-25 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 13:01 [PATCH 0/3] 30bpp framebuffer support Mark Kettenis
2021-09-16 13:01 ` [PATCH 1/3] video: Add 30bpp support Mark Kettenis
2021-09-25 13:40 ` Simon Glass
2021-09-25 16:55 ` Mark Kettenis
2021-09-16 13:01 ` [PATCH 2/3] efi_loader: GOP: " Mark Kettenis
2021-09-17 2:56 ` Heinrich Schuchardt
2021-09-17 9:23 ` Mark Kettenis
2021-09-17 11:29 ` Heinrich Schuchardt
2021-09-17 12:41 ` Mark Kettenis
2021-09-25 13:40 ` Simon Glass
2021-09-16 13:01 ` [PATCH 3/3] video: simplefb: " Mark Kettenis
2021-09-25 13:41 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3vmFXZiCShnbonDohB=gDP46qH79GoJXcb0AaZOjkzGw@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=agraf@csgraf.de \
--cc=agust@denx.de \
--cc=kettenis@openbsd.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).