From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Mark Kettenis <kettenis@openbsd.org>, u-boot@lists.denx.de
Cc: Anatolij Gustschin <agust@denx.de>, Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support
Date: Fri, 17 Sep 2021 04:56:31 +0200 [thread overview]
Message-ID: <ec075e0a-c78f-2d13-59fb-5050161e4daa@gmx.de> (raw)
In-Reply-To: <20210916130117.20894-3-kettenis@openbsd.org>
On 9/16/21 3:01 PM, Mark Kettenis wrote:
> Provide correct framebuffer information for 30bpp modes.
This is not enough to get a correct GOP implementation for the 30bpp mode.
Have a look at efi_gop_pixel efi_vid16_to_blt_col() and
efi_blt_col_to_vid16() and where they are used.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> lib/efi_loader/efi_gop.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
> index 1206b2d7a2..42bf49b184 100644
> --- a/lib/efi_loader/efi_gop.c
> +++ b/lib/efi_loader/efi_gop.c
> @@ -227,6 +227,7 @@ static efi_uintn_t gop_get_bpp(struct efi_gop *this)
>
> switch (gopobj->bpix) {
> #ifdef CONFIG_DM_VIDEO
> + case VIDEO_BPP30:
> case VIDEO_BPP32:
> #else
> case LCD_COLOR32:
> @@ -468,6 +469,7 @@ efi_status_t efi_gop_register(void)
> switch (bpix) {
> #ifdef CONFIG_DM_VIDEO
> case VIDEO_BPP16:
> + case VIDEO_BPP30:
> case VIDEO_BPP32:
> #else
> case LCD_COLOR32:
> @@ -518,6 +520,14 @@ efi_status_t efi_gop_register(void)
> #endif
> {
> gopobj->info.pixel_format = EFI_GOT_BGRA8;
> +#ifdef CONFIG_DM_VIDEO
This symbol is not 30bpp specific. Is there a Kconfig variable that we
can use to hide 30bpp support where it is not needed?
Which modes does the M1 support?
Best regards
Heinrich
> + } else if (bpix == VIDEO_BPP30) {
> + gopobj->info.pixel_format = EFI_GOT_BITMASK;
> + gopobj->info.pixel_bitmask[0] = 0x3ff00000; /* red */
> + gopobj->info.pixel_bitmask[1] = 0x000ffc00; /* green */
> + gopobj->info.pixel_bitmask[2] = 0x000003ff; /* blue */
> + gopobj->info.pixel_bitmask[3] = 0xc0000000; /* reserved */
> +#endif
> } else {
> gopobj->info.pixel_format = EFI_GOT_BITMASK;
> gopobj->info.pixel_bitmask[0] = 0xf800; /* red */
>
next prev parent reply other threads:[~2021-09-17 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 13:01 [PATCH 0/3] 30bpp framebuffer support Mark Kettenis
2021-09-16 13:01 ` [PATCH 1/3] video: Add 30bpp support Mark Kettenis
2021-09-25 13:40 ` Simon Glass
2021-09-25 16:55 ` Mark Kettenis
2021-09-16 13:01 ` [PATCH 2/3] efi_loader: GOP: " Mark Kettenis
2021-09-17 2:56 ` Heinrich Schuchardt [this message]
2021-09-17 9:23 ` Mark Kettenis
2021-09-17 11:29 ` Heinrich Schuchardt
2021-09-17 12:41 ` Mark Kettenis
2021-09-25 13:40 ` Simon Glass
2021-09-16 13:01 ` [PATCH 3/3] video: simplefb: " Mark Kettenis
2021-09-25 13:41 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec075e0a-c78f-2d13-59fb-5050161e4daa@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=agraf@csgraf.de \
--cc=agust@denx.de \
--cc=kettenis@openbsd.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).