u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chuys@gmail.com>
To: Sean Anderson <seanga2@gmail.com>, Tom Rini <trini@konsulko.com>
Cc: lukma@denx.de, sjg@chromium.org, sr@denx.de, hs@denx.de,
	 Stanley Chu <yschu@nuvoton.com>,
	kwliu@nuvoton.com, ctcchien@nuvoton.com,  avifishman70@gmail.com,
	tmaimon77@gmail.com, u-boot@lists.denx.de
Subject: Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC
Date: Fri, 11 Mar 2022 08:39:41 +0800	[thread overview]
Message-ID: <CAPwEoQPwdsV-ucsvP3f_U7vkBRdOmnvhoTsDykgjxtMR769J4A@mail.gmail.com> (raw)
In-Reply-To: <0fee2e28-b3c8-d649-0921-52e6fb098e71@gmail.com>

Hi Sean,
Thanks for the review.
It is addressed in the gpio driver patch as below.
https://patchwork.ozlabs.org/project/uboot/patch/20220225021450.18690-1-yschu@nuvoton.com/

--
Stanley

On Thu, Dec 16, 2021 at 6:30 AM Sean Anderson <seanga2@gmail.com> wrote:
>
> On 12/15/21 5:16 PM, Jesse Taube wrote:
> >
> >
> > On 12/15/21 13:32, Sean Anderson wrote:
> >> On 12/14/21 9:57 PM, Stanley Chu wrote:
> >>> Add basic support for the Nuvoton NPCM845 BMC.
> >>>
> >>> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> >>> ---
> >>>    arch/arm/Kconfig                          |   9 +
> >>>    arch/arm/Makefile                         |   1 +
> >>>    arch/arm/include/asm/arch-npcm8xx/clock.h | 164 ++++++++++++
> >>>    arch/arm/include/asm/arch-npcm8xx/espi.h  |  23 ++
> >>>    arch/arm/include/asm/arch-npcm8xx/gcr.h   | 313 ++++++++++++++++++++++
> >>>    arch/arm/include/asm/arch-npcm8xx/gpio.h  |  11 +
> >>>    arch/arm/include/asm/arch-npcm8xx/rst.h   |  32 +++
> >>>    arch/arm/mach-nuvoton/Kconfig             |  24 ++
> >>>    arch/arm/mach-nuvoton/Makefile            |   1 +
> >>>    arch/arm/mach-nuvoton/npcm8xx/Kconfig     |  18 ++
> >>>    arch/arm/mach-nuvoton/npcm8xx/Makefile    |   1 +
> >>>    arch/arm/mach-nuvoton/npcm8xx/cpu.c       | 170 ++++++++++++
> >>>    arch/arm/mach-nuvoton/npcm8xx/reset.c     |  51 ++++
> >>>    board/nuvoton/arbel/Kconfig               |  18 ++
> >>>    board/nuvoton/arbel/Makefile              |   1 +
> >>>    board/nuvoton/arbel/arbel.c               |  33 +++
> >>>    include/configs/arbel.h                   |  54 ++++
> >>>    17 files changed, 924 insertions(+)
> > Hello World!
> >
> > Because I was CC'ed I guess I will keep myself up-to date.
> > This commit has 17 files changed and almost 1k insertions,
> > That is a relatively large commit. Would it be better to split
> > /arch/arm/include/asm
> > /arch/arm/mach-nuvoton
> > /board
> > /include/configs
> > into different commits.
> > I ask this because I split them for a patch I'm working on
>
> Please submit the relevant headers with their drivers.
>
> For example, arch/arm/include/asm/arch-npcm8xx/gpio.h should go
> in "[PATCH v1 5/9] gpio: npcm: Add support for Nuvoton NPCM SoCs"
>
> --Sean
>

  parent reply	other threads:[~2022-03-11  0:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15  2:57 [PATCH v1 0/9] Add Nuvoton NPCM845 support Stanley Chu
2021-12-15  2:57 ` [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC Stanley Chu
2021-12-15 12:12   ` Giulio Benetti
2022-03-11  0:50     ` Stanley Chu
2022-03-11  1:06       ` Giulio Benetti
2022-03-11  1:07         ` Giulio Benetti
2021-12-15 18:32   ` Sean Anderson
2022-03-11  0:55     ` Stanley Chu
     [not found]     ` <d23d2925-d5ea-e23b-fb99-7856aedfb328@gmail.com>
     [not found]       ` <0fee2e28-b3c8-d649-0921-52e6fb098e71@gmail.com>
2022-03-11  0:39         ` Stanley Chu [this message]
2022-03-11  0:57       ` Stanley Chu
2022-03-10 18:49   ` Tom Rini
2022-03-11  2:13     ` Stanley Chu
2022-03-11  2:50       ` Tom Rini
2022-03-11  2:53       ` Giulio Benetti
2022-03-11  4:07         ` Stanley Chu
2021-12-15  2:57 ` [PATCH v1 2/9] clk: nuvoton: Add support for NPCM845 Stanley Chu
2021-12-15 18:32   ` Sean Anderson
2022-02-16 16:25   ` Tom Rini
2022-02-17  2:08     ` Stanley
2021-12-15  2:57 ` [PATCH v1 3/9] timer: npcm: Add NPCM timer support Stanley Chu
2021-12-15  2:57 ` [PATCH v1 4/9] serial: npcm: Add support for Nuvoton NPCM SoCs Stanley Chu
2021-12-15  2:57 ` [PATCH v1 5/9] gpio: " Stanley Chu
2021-12-15  2:57 ` [PATCH v1 6/9] pinctrl: nuvoton: Add NPCM8xx pinctrl driver Stanley Chu
2021-12-15  2:57 ` [PATCH v1 7/9] spi: npcm-fiu: add NPCM8xx FIU controller driver Stanley Chu
2021-12-15  2:57 ` [PATCH v1 8/9] ARM: dts: Add Nuvoton NPCM845 device tree Stanley Chu
2021-12-15 13:07   ` Tom Rini
2021-12-15 13:32     ` 盛
2021-12-15 13:35       ` Tom Rini
2021-12-15 15:32         ` Jesse Taube
2021-12-15 15:39           ` Tom Rini
2021-12-15  2:58 ` [PATCH v1 9/9] ARM: configs: Add defconfig for Nuvoton NPCM845 Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPwEoQPwdsV-ucsvP3f_U7vkBRdOmnvhoTsDykgjxtMR769J4A@mail.gmail.com \
    --to=stanley.chuys@gmail.com \
    --cc=avifishman70@gmail.com \
    --cc=ctcchien@nuvoton.com \
    --cc=hs@denx.de \
    --cc=kwliu@nuvoton.com \
    --cc=lukma@denx.de \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=tmaimon77@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=yschu@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).