Re: [PATCH v4 01/11] bootmenu: fix menu API error handling

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>,
	Takahiro Akashi <takahiro.akashi@linaro.org>,
	Francois Ozog <francois.ozog@linaro.org>,
	Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH v4 01/11] bootmenu: fix menu API error handling
Date: Wed, 30 Mar 2022 11:55:47 +0300	[thread overview]
Message-ID: <YkQbEzE5Fw24LEu1@hades> (raw)
In-Reply-To: <20220324135443.1571-2-masahisa.kojima@linaro.org>

On Thu, Mar 24, 2022 at 10:54:33PM +0900, Masahisa Kojima wrote:
> U-Boot menu framework(common/menu.c) returns 1 if it is successful,
> returns negative value if it fails.
> 
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> ---
> Newly added in v4
> 
>  cmd/bootmenu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c
> index 409ef9a848..d573487272 100644
> --- a/cmd/bootmenu.c
> +++ b/cmd/bootmenu.c
> @@ -463,7 +463,7 @@ static void bootmenu_show(int delay)
>  	}
>  
>  	for (iter = bootmenu->first; iter; iter = iter->next) {
> -		if (!menu_item_add(menu, iter->key, iter))
> +		if (menu_item_add(menu, iter->key, iter) != 1)
>  			goto cleanup;
>  	}
>  
> @@ -476,7 +476,7 @@ static void bootmenu_show(int delay)
>  
>  	init = 1;
>  
> -	if (menu_get_choice(menu, &choice)) {
> +	if (menu_get_choice(menu, &choice) == 1) {
>  		iter = choice;
>  		title = strdup(iter->title);
>  		command = strdup(iter->command);
> -- 
> 2.17.1
> 
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>