Re: [PATCH v4 04/11] menu: always show the menu regardless of the number of entry

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Simon Glass <sjg@chromium.org>,
	Takahiro Akashi <takahiro.akashi@linaro.org>,
	Francois Ozog <francois.ozog@linaro.org>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v4 04/11] menu: always show the menu regardless of the number of entry
Date: Sat, 2 Apr 2022 09:56:56 +0200	[thread overview]
Message-ID: <f487a36d-74aa-5c02-5be6-95059cff694a@gmx.de> (raw)
In-Reply-To: <20220324135443.1571-5-masahisa.kojima@linaro.org>

On 3/24/22 14:54, Masahisa Kojima wrote:
> To make user aware of the menu entry selection, menu always
> appears regardless of the number of entry.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> ---
> Newly created in v4
>
>   common/menu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/menu.c b/common/menu.c
> index 5fb2ffbd06..b577d80b4f 100644
> --- a/common/menu.c
> +++ b/common/menu.c
> @@ -271,7 +271,7 @@ int menu_get_choice(struct menu *m, void **choice)
>   	if (!m || !choice)
>   		return -EINVAL;
>
> -	if (!m->prompt || m->item_cnt == 1)
> +	if (!m->prompt)
>   		return menu_default_choice(m, choice);

As we can disable entering the console item_cnt may be zero.
This case needs to be handled.

Best regards

Heinrich

>
>   	return menu_interactive_choice(m, choice);