From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Paul Barker <paul.barker@sancloud.com>,
u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support
Date: Mon, 26 Sep 2022 16:40:48 +0300 [thread overview]
Message-ID: <YzGr4Ohvh6KEjJIo@hera> (raw)
In-Reply-To: <8f5bcacf-65b1-42aa-ff7f-d770b93e3cec@gmx.de>
Hi Heinrich,
[...]
> > > +};
> > > +
> > > +static struct efi_legacy_spi_controller_protocol
> > > +dummy_legacy_spi_controller_protocol = {
> > > + .maximum_offset = 0,
> > > + .maximum_range_bytes = 0,
> > > + .range_register_count = 0,
> > > + .erase_block_opcode = legacy_erase_block_opcode,
> > > + .write_status_prefix = legacy_write_status_prefix,
> > > + .bios_base_address = legacy_bios_base_address,
> > > + .clear_spi_protect = legacy_clear_spi_protect,
> > > + .is_range_protected = legacy_is_range_protected,
> > > + .protect_next_range = legacy_protect_next_range,
> > > + .lock_controller = legacy_lock_controller
> > > +};
> >
> > Keeping in mind all these return EFI_UNSUPPORTED can we get rid of them and
> > set the legacy_spi_protocol to NULL? Or defining them is mandatory from the PI spec?
> > Do you plan to implement it in the future?
>
> What do you mean by setting to NULL?
> You simply would not install the protocol interface on any handle.
> If there is no legacy SPI controller, it does not make sense to install
> the protocol.
There's no protocol installation for this, The protocl we install is
efi_spi_io_protocol and one of it's struct members is that legacy spi
protocol
[...]
Cheers
/Ilias
next prev parent reply other threads:[~2022-09-26 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 16:06 [PATCH v3 0/3] Support UEFI SPI I/O protocol Paul Barker
2022-09-21 16:06 ` [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support Paul Barker
2022-09-26 12:43 ` Ilias Apalodimas
2022-09-26 13:13 ` Heinrich Schuchardt
2022-09-26 13:40 ` Ilias Apalodimas [this message]
2022-10-03 12:05 ` Paul Barker
2022-10-03 12:00 ` Paul Barker
2022-09-26 13:52 ` Heinrich Schuchardt
2022-10-03 12:05 ` Paul Barker
2022-10-04 16:31 ` Paul Barker
2022-10-04 17:25 ` Heinrich Schuchardt
2022-09-21 16:06 ` [PATCH v3 2/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export Paul Barker
2022-09-21 16:15 ` Tom Rini
2022-09-26 11:33 ` Ilias Apalodimas
2022-09-26 13:13 ` Tom Rini
2022-09-26 13:33 ` Heinrich Schuchardt
2022-09-26 19:13 ` Tom Rini
2022-09-21 16:06 ` [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support Paul Barker
2022-09-26 13:21 ` Heinrich Schuchardt
2022-10-03 12:07 ` Paul Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGr4Ohvh6KEjJIo@hera \
--to=ilias.apalodimas@linaro.org \
--cc=paul.barker@sancloud.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).