From: Paul Barker <paul.barker@sancloud.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support
Date: Tue, 4 Oct 2022 17:31:46 +0100 [thread overview]
Message-ID: <dffff265-4c2e-b34b-34be-d84008ac806e@sancloud.com> (raw)
In-Reply-To: <3a888c87-7635-63ed-9c14-f2a53c530168@sancloud.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1004 bytes --]
On 03/10/2022 13:05, Paul Barker wrote:
> On 26/09/2022 14:52, Heinrich Schuchardt wrote:
>> On 9/21/22 18:06, Paul Barker wrote:
>>> +
>>> + log_debug("Added EFI_SPI_IO_PROTOCOL for %s with guid "
>>> + "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x\n",
>>> + name,
>>> + guid->b[3], guid->b[2], guid->b[1], guid->b[0],
>>> + guid->b[5], guid->b[4], guid->b[7], guid->b[6],
>>> + guid->b[8], guid->b[9], guid->b[10], guid->b[11],
>>> + guid->b[12], guid->b[13], guid->b[14], guid->b[15]);
>>> + return EFI_SUCCESS;
>>
>> This should be
>>
>> log_debug(Added EFI_SPI_IO_PROTOCOL for %s with guid %pD\n", guid);
>
> I'll address this in v4.
After a quick look in lib/vsprintf.c, I assume you meant %pUl here.
Thanks,
--
Paul Barker
Principal Software Engineer
SanCloud Ltd
e: paul.barker@sancloud.com
w: https://sancloud.com/
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6865 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-10-04 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 16:06 [PATCH v3 0/3] Support UEFI SPI I/O protocol Paul Barker
2022-09-21 16:06 ` [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support Paul Barker
2022-09-26 12:43 ` Ilias Apalodimas
2022-09-26 13:13 ` Heinrich Schuchardt
2022-09-26 13:40 ` Ilias Apalodimas
2022-10-03 12:05 ` Paul Barker
2022-10-03 12:00 ` Paul Barker
2022-09-26 13:52 ` Heinrich Schuchardt
2022-10-03 12:05 ` Paul Barker
2022-10-04 16:31 ` Paul Barker [this message]
2022-10-04 17:25 ` Heinrich Schuchardt
2022-09-21 16:06 ` [PATCH v3 2/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export Paul Barker
2022-09-21 16:15 ` Tom Rini
2022-09-26 11:33 ` Ilias Apalodimas
2022-09-26 13:13 ` Tom Rini
2022-09-26 13:33 ` Heinrich Schuchardt
2022-09-26 19:13 ` Tom Rini
2022-09-21 16:06 ` [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support Paul Barker
2022-09-26 13:21 ` Heinrich Schuchardt
2022-10-03 12:07 ` Paul Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dffff265-4c2e-b34b-34be-d84008ac806e@sancloud.com \
--to=paul.barker@sancloud.com \
--cc=ilias.apalodimas@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).