* Re: [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE
2022-08-27 12:00 [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE Pali Rohár
@ 2022-08-30 2:30 ` Simon Glass
2022-08-30 12:26 ` Stefan Roese
2022-09-13 6:58 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2022-08-30 2:30 UTC (permalink / raw)
To: Pali Rohár; +Cc: Stefan Roese, U-Boot Mailing List
Hi Pali,
On Sat, 27 Aug 2022 at 06:01, Pali Rohár <pali@kernel.org> wrote:
>
This patch is missing a motivation. Please always add a commit message.
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
> index 5ae133879f32..45779198b678 100644
> --- a/board/Marvell/mvebu_armada-37xx/board.c
> +++ b/board/Marvell/mvebu_armada-37xx/board.c
> @@ -132,6 +132,8 @@ int board_late_init(void)
> dev = mmc_dev->dev;
> device_remove(dev, DM_REMOVE_NORMAL);
> device_unbind(dev);
> + if (of_live_active())
> + ofnode_set_enabled(dev_ofnode(dev), false);
> }
>
> /* Ensure that 'env default -a' set correct value to $fdtfile */
> --
> 2.20.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE
2022-08-27 12:00 [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE Pali Rohár
2022-08-30 2:30 ` Simon Glass
@ 2022-08-30 12:26 ` Stefan Roese
2022-09-13 6:58 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-08-30 12:26 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot
On 27.08.22 14:00, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali@kernel.org>
As mentioned by Simon, please add a short sentence in the commit text
as well.
Other than that:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
> index 5ae133879f32..45779198b678 100644
> --- a/board/Marvell/mvebu_armada-37xx/board.c
> +++ b/board/Marvell/mvebu_armada-37xx/board.c
> @@ -132,6 +132,8 @@ int board_late_init(void)
> dev = mmc_dev->dev;
> device_remove(dev, DM_REMOVE_NORMAL);
> device_unbind(dev);
> + if (of_live_active())
> + ofnode_set_enabled(dev_ofnode(dev), false);
> }
>
> /* Ensure that 'env default -a' set correct value to $fdtfile */
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE
2022-08-27 12:00 [PATCH] arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE Pali Rohár
2022-08-30 2:30 ` Simon Glass
2022-08-30 12:26 ` Stefan Roese
@ 2022-09-13 6:58 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-09-13 6:58 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot
On 27.08.22 14:00, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
> index 5ae133879f32..45779198b678 100644
> --- a/board/Marvell/mvebu_armada-37xx/board.c
> +++ b/board/Marvell/mvebu_armada-37xx/board.c
> @@ -132,6 +132,8 @@ int board_late_init(void)
> dev = mmc_dev->dev;
> device_remove(dev, DM_REMOVE_NORMAL);
> device_unbind(dev);
> + if (of_live_active())
> + ofnode_set_enabled(dev_ofnode(dev), false);
> }
>
> /* Ensure that 'env default -a' set correct value to $fdtfile */
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread