From: Michael Walle <michael@walle.cc>
To: "Sahil Malhotra (OSS)" <sahil.malhotra@oss.nxp.com>
Cc: "Clément Faure" <clement.faure@nxp.com>,
"Gaurav Jain" <gaurav.jain@nxp.com>,
"Pankaj Gupta" <pankaj.gupta@nxp.com>,
"Priyanka Jain" <priyanka.jain@nxp.com>,
u-boot@lists.denx.de, "Varun Sethi" <V.Sethi@nxp.com>,
"Ye Li" <ye.li@nxp.com>,
"ZHIZHIKIN Andrey" <andrey.zhizhikin@leica-geosystems.com>
Subject: Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature
Date: Mon, 29 Nov 2021 18:47:15 +0100 [thread overview]
Message-ID: <cea238bcbafdddfad78083156b8492d7@walle.cc> (raw)
In-Reply-To: <DB7PR04MB53226A4FFBA30EE5BF67541C82669@DB7PR04MB5322.eurprd04.prod.outlook.com>
Hi Sahil,
Am 2021-11-29 12:55, schrieb Sahil Malhotra (OSS):
> Am 2021-11-17 19:11, schrieb Sahil Malhotra (OSS):
>>> Could you please add some description what this is doing and for what
>>> this is intended? To have a "DTB overlay feature", it is enough to
>>> just enable CONFIG_OF_LIBFDT_OVERLAY.
>> I will add some description, and yes for DTB overlay feature, it is
>> enough to enable CONFIG_OF_LIBFDT_OVERLAY but we need to do this step
>> before booting the kernel that's why also have to enable
>> CONFIG_OF_SYSTEM_SETUP.
>
>> Ok. What will the overlay do? Could you give an example?
> This overlay will be disabling the crypto nodes which will be used by
> optee in secure world, so that linux should not use it.
>
>
>>> Apparently you're adding an overlay passed by optee. Doesn't this
>>> have to be applied to u-boot's control dtb too?
>> Yes, we will be applying the overlay passed by optee, yes it will be
>> applied to dtb which will be passed to uboot for kernel booting.
>
>> If I read this patch correctly, you're modifying the DT before you
>> jump to linux. But I was asking whether you also have to modify the DT
>> which is used by u-boot. Eg. if you disable some kind of crypto nodes
>> (because optee will use them in secure world), this also have to
>> communicated to u-boot, not only linux, no?
> Yes, I got your point now, and is very valid, but as of now for u-boot
> we are just using the first available node for communicating with CAAM
> leaving other job rings as it is.
> So we need not to apply overlay to DTB used by uboot.
But we should do the correct thing, so that u-boot and linux
doesn't see a different version of the device tree.
Also what do you mean with "the first available node"?
There is already a new CAAM driver for u-boot pending,
see
https://lore.kernel.org/u-boot/20211115070014.17586-1-gaurav.jain@nxp.com/
-michael
next prev parent reply other threads:[~2021-11-29 17:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 6:23 [PATCH 1/2] fsl-layerscape: add dtb overlay feature Sahil Malhotra
2021-11-17 6:23 ` [PATCH 2/2] configs: enabled DTB overlay feature for LS SoCs Sahil Malhotra
2021-11-17 7:53 ` [PATCH 1/2] fsl-layerscape: add dtb overlay feature Michael Walle
2021-11-17 18:11 ` Sahil Malhotra (OSS)
2021-11-17 18:20 ` Michael Walle
2021-11-29 11:55 ` Sahil Malhotra (OSS)
2021-11-29 17:47 ` Michael Walle [this message]
2021-12-08 6:12 ` Sahil Malhotra (OSS)
2021-12-08 10:13 ` ZHIZHIKIN Andrey
2021-12-10 6:33 ` Sahil Malhotra (OSS)
2021-12-17 6:19 ` Sahil Malhotra (OSS)
2021-12-17 7:27 ` Michael Walle
2021-12-20 12:52 ` Michael Walle
2021-12-23 8:46 ` [EXT] " Sahil Malhotra (OSS)
2021-12-23 9:34 ` Michael Walle
2021-12-10 7:38 ` François Ozog
-- strict thread matches above, loose matches on Subject: below --
2022-01-06 6:09 Sahil Malhotra (OSS)
2022-01-06 7:40 ` Michael Walle
2022-02-04 11:27 ` Sahil Malhotra (OSS)
2022-02-24 10:59 ` Sahil Malhotra (OSS)
2022-02-24 12:33 ` Michael Walle
2021-11-16 10:16 Sahil Malhotra
2021-11-16 8:34 Sahil Malhotra
2021-11-16 8:30 Sahil Malhotra
2021-11-16 6:49 Sahil Malhotra
2021-11-16 6:46 Sahil Malhotra
2021-11-16 6:37 Sahil Malhotra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cea238bcbafdddfad78083156b8492d7@walle.cc \
--to=michael@walle.cc \
--cc=V.Sethi@nxp.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=clement.faure@nxp.com \
--cc=gaurav.jain@nxp.com \
--cc=pankaj.gupta@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=sahil.malhotra@oss.nxp.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).