From: Michael Walle <michael@walle.cc>
To: "Sahil Malhotra (OSS)" <sahil.malhotra@oss.nxp.com>
Cc: "ZHIZHIKIN Andrey" <andrey.zhizhikin@leica-geosystems.com>,
"Clément Faure" <clement.faure@nxp.com>,
"Gaurav Jain" <gaurav.jain@nxp.com>,
"Pankaj Gupta" <pankaj.gupta@nxp.com>,
"Priyanka Jain" <priyanka.jain@nxp.com>,
u-boot@lists.denx.de, "Varun Sethi" <V.Sethi@nxp.com>,
"Ye Li" <ye.li@nxp.com>
Subject: Re: [EXT] Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature
Date: Thu, 23 Dec 2021 10:34:45 +0100 [thread overview]
Message-ID: <1ea4e3f13da952e61d530ec9b31d193c@walle.cc> (raw)
In-Reply-To: <DB7PR04MB5322EBFE9BC6F6D90379A2AB827E9@DB7PR04MB5322.eurprd04.prod.outlook.com>
Hi Sahil,
Am 2021-12-23 09:46, schrieb Sahil Malhotra (OSS):
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Michael Walle
>> Sent: Monday, December 20, 2021 6:23 PM
>> To: Sahil Malhotra (OSS) <sahil.malhotra@oss.nxp.com>
>> Cc: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>; Clément
>> Faure <clement.faure@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>;
>> Pankaj Gupta <pankaj.gupta@nxp.com>; Priyanka Jain
>> <priyanka.jain@nxp.com>; u-boot@lists.denx.de; Varun Sethi
>> <V.Sethi@nxp.com>; Ye Li <ye.li@nxp.com>
>> Subject: [EXT] Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature
>>
>> Caution: EXT Email
>>
>> Hi Sahil,
>>
>> Am 2021-12-10 07:33, schrieb Sahil Malhotra (OSS):
>> >> DT nodes can be statically disabled if we know that they are held by
>> >> HAB and are not released to NS World.
>> >>
>> >> OP-TEE does set the status itself via dt_enable_secure_status(),
>> >> which should present the properly configured FDT when U-Boot takes
>> over.
>> > Yes, OP-TEE set the status by dt_enable_secure_status() in DTB overlay
>> > which gets merged with DTB provided for Linux bootup and then Linux
>> > boots with merged DTB.
>> > But u-boot uses the DTB embedded in its image. How can we modify that
>> > DTB or merge DTB overlay passed by OP-TEE with uboot DTB ?
>>
>> But then u-boot has the "wrong" dtb. What is the reason, there is an
>> overlay
>> instead of a whole dtb? what if the overlay doesn't match the dtb?
> "wrong" dtb means that uboot will not be aware of CAAM job ring which
> is taken by
> OP-TEE and uboot on LS platforms currently use JR0, which is not being
> used by any other
> entity in LS bootflow.
I don't know I follow. u-boot and linux should have the same device
tree;
regardless if that device is used or not. So applying the overlay just
for
linux isn't enough here.
> We don't use DTB in OP-TEE, but when we use CAAM in OP-TEE, OP-TEE
> reserves
> One Job Ring for its use and that is communicated to Kernel using DTB
> overlay.
>
>> what if the overlay doesn't match the dtb?
> I didn't get this point, can you please elaborate a little.
You are merging a dtb fragment with an unknown dtb, right? Who says they
match? you might have an old dtb where the supplied dtb fragment doesn't
make any sense.
I might be missing something here. Eg. where is the linux dtb supposed
to
come from? This patchset is really missing an example and a description
how
things should work.
-michael
next prev parent reply other threads:[~2021-12-23 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 6:23 [PATCH 1/2] fsl-layerscape: add dtb overlay feature Sahil Malhotra
2021-11-17 6:23 ` [PATCH 2/2] configs: enabled DTB overlay feature for LS SoCs Sahil Malhotra
2021-11-17 7:53 ` [PATCH 1/2] fsl-layerscape: add dtb overlay feature Michael Walle
2021-11-17 18:11 ` Sahil Malhotra (OSS)
2021-11-17 18:20 ` Michael Walle
2021-11-29 11:55 ` Sahil Malhotra (OSS)
2021-11-29 17:47 ` Michael Walle
2021-12-08 6:12 ` Sahil Malhotra (OSS)
2021-12-08 10:13 ` ZHIZHIKIN Andrey
2021-12-10 6:33 ` Sahil Malhotra (OSS)
2021-12-17 6:19 ` Sahil Malhotra (OSS)
2021-12-17 7:27 ` Michael Walle
2021-12-20 12:52 ` Michael Walle
2021-12-23 8:46 ` [EXT] " Sahil Malhotra (OSS)
2021-12-23 9:34 ` Michael Walle [this message]
2021-12-10 7:38 ` François Ozog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea4e3f13da952e61d530ec9b31d193c@walle.cc \
--to=michael@walle.cc \
--cc=V.Sethi@nxp.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=clement.faure@nxp.com \
--cc=gaurav.jain@nxp.com \
--cc=pankaj.gupta@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=sahil.malhotra@oss.nxp.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).