From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Marek Behún" <marek.behun@nic.cz>, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: Remove commented example code
Date: Sat, 18 Dec 2021 09:34:31 +0100 [thread overview]
Message-ID: <d58378bb-7be0-7024-cdb1-a1bb2d5c8f20@denx.de> (raw)
In-Reply-To: <20211217172851.4818-1-pali@kernel.org>
On 12/17/21 18:28, Pali Rohár wrote:
> Include file debug_uart.h already contains documentation how to use it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> arch/arm/mach-mvebu/spl.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 6a9e1d860cf7..29a8adc9d79c 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -5,7 +5,6 @@
>
> #include <common.h>
> #include <dm.h>
> -#include <debug_uart.h>
> #include <fdtdec.h>
> #include <hang.h>
> #include <image.h>
> @@ -303,18 +302,6 @@ void board_init_f(ulong dummy)
> */
> board_early_init_f();
>
> - /* Example code showing how to enable the debug UART on MVEBU */
> -#ifdef EARLY_UART
> - /*
> - * Debug UART can be used from here if required:
> - *
> - * debug_uart_init();
> - * printch('a');
> - * printhex8(0x1234);
> - * printascii("string");
> - */
> -#endif
> -
> /*
> * Use special translation offset for SPL. This needs to be
> * configured *before* spl_init() is called as this function
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2021-12-18 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 17:28 [PATCH] arm: mvebu: Remove commented example code Pali Rohár
2021-12-18 8:34 ` Stefan Roese [this message]
2021-12-18 13:49 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58378bb-7be0-7024-cdb1-a1bb2d5c8f20@denx.de \
--to=sr@denx.de \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).