[PATCH] arm: mvebu: Remove commented example code

[PATCH] arm: mvebu: Remove commented example code

[Pali Rohár]

Include file debug_uart.h already contains documentation how to use it.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/mach-mvebu/spl.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 6a9e1d860cf7..29a8adc9d79c 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -5,7 +5,6 @@
 
 #include <common.h>
 #include <dm.h>
-#include <debug_uart.h>
 #include <fdtdec.h>
 #include <hang.h>
 #include <image.h>
@@ -303,18 +302,6 @@ void board_init_f(ulong dummy)
 	 */
 	board_early_init_f();
 
-	/* Example code showing how to enable the debug UART on MVEBU */
-#ifdef EARLY_UART
-	/*
-	 * Debug UART can be used from here if required:
-	 *
-	 * debug_uart_init();
-	 * printch('a');
-	 * printhex8(0x1234);
-	 * printascii("string");
-	 */
-#endif
-
 	/*
 	 * Use special translation offset for SPL. This needs to be
 	 * configured *before* spl_init() is called as this function
-- 
2.20.1

Re: [PATCH] arm: mvebu: Remove commented example code

[Stefan Roese]

On 12/17/21 18:28, Pali Rohár wrote:
> Include file debug_uart.h already contains documentation how to use it.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/spl.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 6a9e1d860cf7..29a8adc9d79c 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -5,7 +5,6 @@
>   
>   #include <common.h>
>   #include <dm.h>
> -#include <debug_uart.h>
>   #include <fdtdec.h>
>   #include <hang.h>
>   #include <image.h>
> @@ -303,18 +302,6 @@ void board_init_f(ulong dummy)
>   	 */
>   	board_early_init_f();
>   
> -	/* Example code showing how to enable the debug UART on MVEBU */
> -#ifdef EARLY_UART
> -	/*
> -	 * Debug UART can be used from here if required:
> -	 *
> -	 * debug_uart_init();
> -	 * printch('a');
> -	 * printhex8(0x1234);
> -	 * printascii("string");
> -	 */
> -#endif
> -
>   	/*
>   	 * Use special translation offset for SPL. This needs to be
>   	 * configured *before* spl_init() is called as this function
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH] arm: mvebu: Remove commented example code

[Stefan Roese]

On 12/17/21 18:28, Pali Rohár wrote:
> Include file debug_uart.h already contains documentation how to use it.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied to u-boot-marvell/next

Thanks,
Stefan

> ---
>   arch/arm/mach-mvebu/spl.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 6a9e1d860cf7..29a8adc9d79c 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -5,7 +5,6 @@
>   
>   #include <common.h>
>   #include <dm.h>
> -#include <debug_uart.h>
>   #include <fdtdec.h>
>   #include <hang.h>
>   #include <image.h>
> @@ -303,18 +302,6 @@ void board_init_f(ulong dummy)
>   	 */
>   	board_early_init_f();
>   
> -	/* Example code showing how to enable the debug UART on MVEBU */
> -#ifdef EARLY_UART
> -	/*
> -	 * Debug UART can be used from here if required:
> -	 *
> -	 * debug_uart_init();
> -	 * printch('a');
> -	 * printhex8(0x1234);
> -	 * printascii("string");
> -	 */
> -#endif
> -
>   	/*
>   	 * Use special translation offset for SPL. This needs to be
>   	 * configured *before* spl_init() is called as this function
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de