From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Marek Behún" <marek.behun@nic.cz>, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: Use printf for printing fatal errors
Date: Sat, 18 Dec 2021 14:50:00 +0100 [thread overview]
Message-ID: <e9b91bbd-b6d1-cf75-b239-f0ece94239fa@denx.de> (raw)
In-Reply-To: <20211217173114.4948-1-pali@kernel.org>
On 12/17/21 18:31, Pali Rohár wrote:
> There is no point to hide/disable fatal errors via debug() macro.
> Print fatal errors loudly.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/next
Thanks,
Stefan
> ---
> arch/arm/mach-mvebu/spl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index 29a8adc9d79c..609495097585 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -313,7 +313,7 @@ void board_init_f(ulong dummy)
>
> ret = spl_init();
> if (ret) {
> - debug("spl_init() failed: %d\n", ret);
> + printf("spl_init() failed: %d\n", ret);
> hang();
> }
>
> @@ -329,7 +329,7 @@ void board_init_f(ulong dummy)
> /* Setup DDR */
> ret = ddr3_init();
> if (ret) {
> - debug("ddr3_init() failed: %d\n", ret);
> + printf("ddr3_init() failed: %d\n", ret);
> hang();
> }
> #endif
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
prev parent reply other threads:[~2021-12-18 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 17:31 [PATCH] arm: mvebu: Use printf for printing fatal errors Pali Rohár
2021-12-18 8:34 ` Stefan Roese
2021-12-18 13:50 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9b91bbd-b6d1-cf75-b239-f0ece94239fa@denx.de \
--to=sr@denx.de \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).