* [PATCH] o4-imx-nano: Fix dtc warnings
@ 2021-06-17 15:57 Fabio Estevam
2021-06-17 16:07 ` Oleh Kravchenko
2021-06-21 11:32 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-06-17 15:57 UTC (permalink / raw)
To: sbabic; +Cc: oleg, u-boot, trini, Fabio Estevam
Remove the LED unit addresses and reg properties to
fix the following dtc build warnings:
arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
...
arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value
Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts
index d1785b7dc702..54d32f9dd47b 100644
--- a/arch/arm/dts/o4-imx-nano.dts
+++ b/arch/arm/dts/o4-imx-nano.dts
@@ -24,40 +24,34 @@
leds {
compatible = "gpio-leds";
- led@0 {
+ led0 {
color = <LED_COLOR_ID_RED>;
gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
- reg = <0>;
};
- led@1 {
+ led1{
color = <LED_COLOR_ID_GREEN>;
gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
- reg = <1>;
};
- led@2 {
+ led2 {
gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
color = <LED_COLOR_ID_BLUE>;
- reg = <2>;
};
- led@3 {
+ led3 {
color = <LED_COLOR_ID_RED>;
gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
- reg = <3>;
};
- led@4 {
+ led4{
color = <LED_COLOR_ID_GREEN>;
gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
- reg = <4>;
};
- led@5 {
+ led5 {
color = <LED_COLOR_ID_BLUE>;
gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
- reg = <5>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] o4-imx-nano: Fix dtc warnings
2021-06-17 15:57 [PATCH] o4-imx-nano: Fix dtc warnings Fabio Estevam
@ 2021-06-17 16:07 ` Oleh Kravchenko
2021-06-21 11:32 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Oleh Kravchenko @ 2021-06-17 16:07 UTC (permalink / raw)
To: Fabio Estevam, sbabic; +Cc: u-boot, trini
17.06.21 18:57, Fabio Estevam пише:
> Remove the LED unit addresses and reg properties to
> fix the following dtc build warnings:
>
> arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> ...
> arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value
>
> Reported-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts
> index d1785b7dc702..54d32f9dd47b 100644
> --- a/arch/arm/dts/o4-imx-nano.dts
> +++ b/arch/arm/dts/o4-imx-nano.dts
> @@ -24,40 +24,34 @@
> leds {
> compatible = "gpio-leds";
>
> - led@0 {
> + led0 {
> color = <LED_COLOR_ID_RED>;
> gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
> - reg = <0>;
> };
>
> - led@1 {
> + led1{
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
> - reg = <1>;
> };
>
> - led@2 {
> + led2 {
> gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
> color = <LED_COLOR_ID_BLUE>;
> - reg = <2>;
> };
>
> - led@3 {
> + led3 {
> color = <LED_COLOR_ID_RED>;
> gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
> - reg = <3>;
> };
>
> - led@4 {
> + led4{
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
> - reg = <4>;
> };
>
> - led@5 {
> + led5 {
> color = <LED_COLOR_ID_BLUE>;
> gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
> - reg = <5>;
> };
> };
>
>
Reviewed-by: Oleh Kravchenko <oleg@kaa.org.ua>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] o4-imx-nano: Fix dtc warnings
2021-06-17 15:57 [PATCH] o4-imx-nano: Fix dtc warnings Fabio Estevam
2021-06-17 16:07 ` Oleh Kravchenko
@ 2021-06-21 11:32 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2021-06-21 11:32 UTC (permalink / raw)
To: Fabio Estevam, sbabic; +Cc: oleg, u-boot, trini
On 17.06.21 17:57, Fabio Estevam wrote:
> Remove the LED unit addresses and reg properties to
> fix the following dtc build warnings:
>
> arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> ...
> arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value
>
> Reported-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
Thanks, applied to -master.
Best regards,
Stefano
> arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts
> index d1785b7dc702..54d32f9dd47b 100644
> --- a/arch/arm/dts/o4-imx-nano.dts
> +++ b/arch/arm/dts/o4-imx-nano.dts
> @@ -24,40 +24,34 @@
> leds {
> compatible = "gpio-leds";
>
> - led@0 {
> + led0 {
> color = <LED_COLOR_ID_RED>;
> gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>;
> - reg = <0>;
> };
>
> - led@1 {
> + led1{
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>;
> - reg = <1>;
> };
>
> - led@2 {
> + led2 {
> gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>;
> color = <LED_COLOR_ID_BLUE>;
> - reg = <2>;
> };
>
> - led@3 {
> + led3 {
> color = <LED_COLOR_ID_RED>;
> gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>;
> - reg = <3>;
> };
>
> - led@4 {
> + led4{
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>;
> - reg = <4>;
> };
>
> - led@5 {
> + led5 {
> color = <LED_COLOR_ID_BLUE>;
> gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>;
> - reg = <5>;
> };
> };
>
>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-21 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 15:57 [PATCH] o4-imx-nano: Fix dtc warnings Fabio Estevam
2021-06-17 16:07 ` Oleh Kravchenko
2021-06-21 11:32 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).