From: "John Groves (jgroves)" <jgroves@micron.com>
To: Karel Zak <kzak@redhat.com>, Ruediger Meier <ruediger.meier@ga-group.nl>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: [EXT] Re: ready for v2.32 ?
Date: Mon, 26 Feb 2018 22:44:12 +0000 [thread overview]
Message-ID: <1519685049171.25700@micron.com> (raw)
In-Reply-To: <20180226222021.tvjznf3w7qzsyafg@ws.net.home>
________________________________________
From: Karel Zak <kzak@redhat.com>
Sent: Monday, February 26, 2018 4:20 PM
To: Ruediger Meier; John Groves (jgroves)
Cc: util-linux@vger.kernel.org
Subject: [EXT] Re: ready for v2.32 ?
On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
>
> [...]
> blkid: superblocks probing: [37] mpool ... FAILED
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
> 1 tests of 199 FAILED
> ---------------------------------------------------------------------
I guess we have to use le32_to_cpu() osd->osb_cksum1.
John, is mpool little endian, big endian, or both?
Karel
>
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool
> 2018-02-26
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Doh! Mpool stores its metadata as little endian, and rigorously uses le32_to_cpu and the like to move on-media structures to & from memory.
le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.
Thanks!
John
next prev parent reply other threads:[~2018-02-26 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 21:16 ready for v2.32 ? Ruediger Meier
2018-02-26 22:20 ` Karel Zak
2018-02-26 22:44 ` John Groves (jgroves) [this message]
2018-02-26 22:50 ` [EXT] " Karel Zak
2018-02-26 23:01 ` Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519685049171.25700@micron.com \
--to=jgroves@micron.com \
--cc=kzak@redhat.com \
--cc=ruediger.meier@ga-group.nl \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).