* Re: ready for v2.32 ?
@ 2018-02-26 21:16 Ruediger Meier
2018-02-26 22:20 ` Karel Zak
0 siblings, 1 reply; 5+ messages in thread
From: Ruediger Meier @ 2018-02-26 21:16 UTC (permalink / raw)
To: util-linux
There is one test failure on big endian (ppc/ppc64)
[...]
blkid: superblocks probing: [37] mpool ... FAILED
(blkid/low-probe-mpool)
[...]
---------------------------------------------------------------------
1 tests of 199 FAILED
---------------------------------------------------------------------
--- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool
2018-02-26 20:14:24.265703542 +0000
+++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool
2018-02-26
20:38:14.300022547 +0000
@@ -1,6 +0,0 @@
-ID_FS_LABEL=mp1
-ID_FS_LABEL_ENC=mp1
-ID_FS_TYPE=mpool
-ID_FS_USAGE=filesystem
-ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
-ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ready for v2.32 ?
2018-02-26 21:16 ready for v2.32 ? Ruediger Meier
@ 2018-02-26 22:20 ` Karel Zak
2018-02-26 22:44 ` [EXT] " John Groves (jgroves)
0 siblings, 1 reply; 5+ messages in thread
From: Karel Zak @ 2018-02-26 22:20 UTC (permalink / raw)
To: Ruediger Meier, John Groves; +Cc: util-linux
On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
>
> [...]
> blkid: superblocks probing: [37] mpool ... FAILED
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
> 1 tests of 199 FAILED
> ---------------------------------------------------------------------
I guess we have to use le32_to_cpu() osd->osb_cksum1.
John, is mpool little endian, big endian, or both?
Karel
>
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool
> 2018-02-26
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [EXT] Re: ready for v2.32 ?
2018-02-26 22:20 ` Karel Zak
@ 2018-02-26 22:44 ` John Groves (jgroves)
2018-02-26 22:50 ` Karel Zak
0 siblings, 1 reply; 5+ messages in thread
From: John Groves (jgroves) @ 2018-02-26 22:44 UTC (permalink / raw)
To: Karel Zak, Ruediger Meier; +Cc: util-linux
________________________________________
From: Karel Zak <kzak@redhat.com>
Sent: Monday, February 26, 2018 4:20 PM
To: Ruediger Meier; John Groves (jgroves)
Cc: util-linux@vger.kernel.org
Subject: [EXT] Re: ready for v2.32 ?
On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
>
> [...]
> blkid: superblocks probing: [37] mpool ... FAILED
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
> 1 tests of 199 FAILED
> ---------------------------------------------------------------------
I guess we have to use le32_to_cpu() osd->osb_cksum1.
John, is mpool little endian, big endian, or both?
Karel
>
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool
> 2018-02-26
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Doh! Mpool stores its metadata as little endian, and rigorously uses le32_to_cpu and the like to move on-media structures to & from memory.
le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.
Thanks!
John
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [EXT] Re: ready for v2.32 ?
2018-02-26 22:44 ` [EXT] " John Groves (jgroves)
@ 2018-02-26 22:50 ` Karel Zak
2018-02-26 23:01 ` Ruediger Meier
0 siblings, 1 reply; 5+ messages in thread
From: Karel Zak @ 2018-02-26 22:50 UTC (permalink / raw)
To: John Groves (jgroves); +Cc: Ruediger Meier, util-linux
On Mon, Feb 26, 2018 at 10:44:12PM +0000, John Groves (jgroves) wrote:
> Doh! Mpool stores its metadata as little endian, and rigorously uses
> le32_to_cpu and the like to move on-media structures to & from
> memory.
>
> le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.
Fixed. Thanks for quick reply!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [EXT] Re: ready for v2.32 ?
2018-02-26 22:50 ` Karel Zak
@ 2018-02-26 23:01 ` Ruediger Meier
0 siblings, 0 replies; 5+ messages in thread
From: Ruediger Meier @ 2018-02-26 23:01 UTC (permalink / raw)
To: Karel Zak; +Cc: John Groves (jgroves), util-linux
On Monday 26 February 2018, Karel Zak wrote:
> On Mon, Feb 26, 2018 at 10:44:12PM +0000, John Groves (jgroves) wrote:
> > Doh! Mpool stores its metadata as little endian, and rigorously
> > uses le32_to_cpu and the like to move on-media structures to & from
> > memory.
> >
> > le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.
>
> Fixed. Thanks for quick reply!
Always nice to see when it was worth to ask for adding a test case :)
cu,
Rudi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-26 23:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 21:16 ready for v2.32 ? Ruediger Meier
2018-02-26 22:20 ` Karel Zak
2018-02-26 22:44 ` [EXT] " John Groves (jgroves)
2018-02-26 22:50 ` Karel Zak
2018-02-26 23:01 ` Ruediger Meier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).