lsblk '--allcols'

lsblk '--allcols'

[Dan Mick]

Beyond simple "show me a quick overview", I often want to see everything
the system knows about a blockdev, and it's a drag to have to construct
the option list from the output of help.  I've made a simple
"-A/--allcols" patch.  Is that something that would meet the
expectations of the team, and if so, is email to this list the best way
to submit it?

Re: lsblk '--allcols'

[Sami Kerola]

On 20 April 2018 at 22:42, Dan Mick <dmick@redhat.com> wrote:
> Beyond simple "show me a quick overview", I often want to see everything
> the system knows about a blockdev, and it's a drag to have to construct
> the option list from the output of help.  I've made a simple
> "-A/--allcols" patch.  Is that something that would meet the
> expectations of the team, and if so, is email to this list the best way
> to submit it?

Pardon if I sound confused. Subject line says lsblk that already has
display all columns option:

 -O, --output-all     output all columns

In message body you are talking about blockdev, that has it's place
but lsblk is better reporting tool. Assuming lsblk does not list something
blockdev can then I recommend adding that to lsblk.

That said --allcols proposal has a point. Right now various tools
that use smartcols has the options listed below. Perhaps --output-all
should be part of these.

 -J, --json             use JSON output format
 -n, --noheadings       don't print headings
 -o, --output <list>    COLUMNS to display (see below)
 -r, --raw              use the raw output format

If I see right the --output-all could be added to these utilities: fdisk,
fincore, findmnt, losetup, lscpu, lsipc, lslocks, lslogins, lsmem, lsns,
partx, prlimit, rfkill, sfdisk, swapon, uuidparse, wdctl, wipefs, and
zramctl.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: lsblk '--allcols'

[Karel Zak]

On Sat, Apr 21, 2018 at 09:14:03AM +0100, Sami Kerola wrote:
> If I see right the --output-all could be added to these utilities: fdisk,
> fincore, findmnt, losetup, lscpu, lsipc, lslocks, lslogins, lsmem, lsns,
> partx, prlimit, rfkill, sfdisk, swapon, uuidparse, wdctl, wipefs, and
> zramctl.

Good idea. (Your) patches are welcomed :-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: lsblk '--allcols'

[Sami Kerola]

On Mon, 23 Apr 2018, Karel Zak wrote:
> On Sat, Apr 21, 2018 at 09:14:03AM +0100, Sami Kerola wrote:
> > If I see right the --output-all could be added to these utilities: fdisk,
> > fincore, findmnt, losetup, lscpu, lsipc, lslocks, lslogins, lsmem, lsns,
> > partx, prlimit, rfkill, sfdisk, swapon, uuidparse, wdctl, wipefs, and
> > zramctl.
> 
> Good idea. (Your) patches are welcomed :-)

Here's some.  I skipped couple commands, they either already listing all 
columns or are unlikely to be used for info listing (fdisk, wipefs, ...)

Due the tiring repetativeness in these changes I won't send send these to 
maillist. Please fetch from my remote to review & merge.

----------------------------------------------------------------
The following changes since commit 136f89ce5ed8cd159a1c56b5a775dada2363ecd3:
  libblkid: add BitLocker detection (2018-04-24 11:47:55 +0200)
are available in the Git repository at:
  git://github.com/kerolasa/lelux-utiliteetit.git output-all
for you to fetch changes up to 9c1bbbf41bc82aa94e93703af19d459092a728ed:
  zramctl: add --output-all option (2018-04-24 22:28:41 +0100)
----------------------------------------------------------------

Sami Kerola (11):
      findmnt: add --output-all option
      losetup: add --output-all option
      lscpu: add --output-all option
      lslocks: add --output-all option
      lslogins: add --output-all option
      lsmem: add --output-all option
      lsns: add --output-all option
      partx: add --output-all option
      rfkill: add --output-all option
      swapon: add --output-all option
      zramctl: add --output-all option

 bash-completion/findmnt  |  1 +
 bash-completion/losetup  |  1 +
 bash-completion/lscpu    |  1 +
 bash-completion/lslocks  |  1 +
 bash-completion/lslogins |  1 +
 bash-completion/lsmem    |  1 +
 bash-completion/lsns     |  1 +
 bash-completion/partx    |  1 +
 bash-completion/rfkill   |  1 +
 bash-completion/swapon   |  1 +
 bash-completion/zramctl  |  1 +
 disk-utils/partx.8       |  3 +++
 disk-utils/partx.c       |  9 ++++++++-
 login-utils/lslogins.1   |  3 +++
 login-utils/lslogins.c   |  7 +++++++
 misc-utils/findmnt.8     |  5 +++++
 misc-utils/findmnt.c     | 12 +++++++++++-
 misc-utils/lslocks.8     |  3 +++
 misc-utils/lslocks.c     |  9 +++++++++
 sys-utils/losetup.8      |  3 +++
 sys-utils/losetup.c      |  9 ++++++++-
 sys-utils/lscpu.1        |  4 ++++
 sys-utils/lscpu.c        | 11 +++++++++++
 sys-utils/lsmem.1        |  3 +++
 sys-utils/lsmem.c        |  9 ++++++++-
 sys-utils/lsns.8         |  3 +++
 sys-utils/lsns.c         |  9 +++++++++
 sys-utils/rfkill.8       |  3 +++
 sys-utils/rfkill.c       | 12 +++++++++++-
 sys-utils/swapon.8       |  3 +++
 sys-utils/swapon.c       |  8 +++++++-
 sys-utils/zramctl.8      |  3 +++
 sys-utils/zramctl.c      | 11 ++++++++++-
 33 files changed, 146 insertions(+), 7 deletions(-)

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: lsblk '--allcols'

[Karel Zak]

On Tue, Apr 24, 2018 at 10:38:02PM +0100, Sami Kerola wrote:
> On Mon, 23 Apr 2018, Karel Zak wrote:
> > On Sat, Apr 21, 2018 at 09:14:03AM +0100, Sami Kerola wrote:
> > > If I see right the --output-all could be added to these utilities: fdisk,
> > > fincore, findmnt, losetup, lscpu, lsipc, lslocks, lslogins, lsmem, lsns,
> > > partx, prlimit, rfkill, sfdisk, swapon, uuidparse, wdctl, wipefs, and
> > > zramctl.
> > 
> > Good idea. (Your) patches are welcomed :-)
> 
> Here's some.  I skipped couple commands, they either already listing all 
> columns or are unlikely to be used for info listing (fdisk, wipefs, ...)
> 
> Due the tiring repetativeness in these changes I won't send send these to 
> maillist. Please fetch from my remote to review & merge.

Merged, maybe next time you can use "pull request" git hub feature ;-)

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com