Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] libmount: fix comment referring to passno field
@ 2019-08-15 10:50 Patrick Steinhardt
  2019-08-20 12:52 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick Steinhardt @ 2019-08-15 10:50 UTC (permalink / raw)
  To: util-linux; +Cc: Patrick Steinhardt

There's an obvious copy-paste error in `mnt_parse_table_line` when
referring to the 6th field of the fstab format, where it says "freq"
instead of "passno". This has probably been copied from the 5th field,
which is in fact correctly labelled as "freq".

Fix the mistake by changing the comment to say "passno" instead.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 libmount/src/tab_parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmount/src/tab_parse.c b/libmount/src/tab_parse.c
index 8e94715d2..2dfa6cbb4 100644
--- a/libmount/src/tab_parse.c
+++ b/libmount/src/tab_parse.c
@@ -154,7 +154,7 @@ static int mnt_parse_table_line(struct libmnt_fs *fs, const char *s)
 	if (!s || !*s)
 		goto done;
 
-	/* (6) freq (optional) */
+	/* (6) passno (optional) */
 	s = next_s32(s, &fs->passno, &rc);
 	if (s && *s && rc) {
 		DBG(TAB, ul_debug("tab parse error: [passno]"));
-- 
2.22.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libmount: fix comment referring to passno field
  2019-08-15 10:50 [PATCH] libmount: fix comment referring to passno field Patrick Steinhardt
@ 2019-08-20 12:52 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2019-08-20 12:52 UTC (permalink / raw)
  To: Patrick Steinhardt; +Cc: util-linux

On Thu, Aug 15, 2019 at 12:50:05PM +0200, Patrick Steinhardt wrote:
>  libmount/src/tab_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 10:50 [PATCH] libmount: fix comment referring to passno field Patrick Steinhardt
2019-08-20 12:52 ` Karel Zak

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git