* [PATCH] su: silence a useless warning
@ 2019-12-06 10:06 Jouke Witteveen
2019-12-06 11:41 ` Karel Zak
0 siblings, 1 reply; 2+ messages in thread
From: Jouke Witteveen @ 2019-12-06 10:06 UTC (permalink / raw)
To: util-linux
When the requested shell matches the restricted shell, there is no reason
to issue a warning, since we will be doing precisely as requested.
Signed-off-by: Jouke Witteveen <j.witteveen@gmail.com>
---
login-utils/su-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 9bf0971b2..e671d822b 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -1149,6 +1149,7 @@ int su_main(int argc, char **argv, int mode)
shell = getenv("SHELL");
if (shell
+ && strcmp(shell, su->pwd->pw_shell)
&& getuid() != 0
&& is_restricted_shell(su->pwd->pw_shell)) {
/* The user being su'd to has a nonstandard shell, and
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-06 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 10:06 [PATCH] su: silence a useless warning Jouke Witteveen
2019-12-06 11:41 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).