From: Karel Zak <kzak@redhat.com>
To: Aurelien LAJOIE <orel@melix.net>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH v2] libuuid: improve uuid_unparse() performance
Date: Wed, 1 Apr 2020 10:31:03 +0200 [thread overview]
Message-ID: <20200401083103.ipberscb6yzvpu4r@ws.net.home> (raw)
In-Reply-To: <20200326143827.25879-1-orel@melix.net>
On Thu, Mar 26, 2020 at 03:38:27PM +0100, Aurelien LAJOIE wrote:
> +#ifdef UUID_UNPARSE_DEFAULT_UPPER
> void uuid_unparse(const uuid_t uu, char *out)
> -{
> - uuid_unparse_x(uu, out, FMT_DEFAULT);
> -}
> + __attribute__((alias("uuid_unparse_upper")));
> +#else
> +void uuid_unparse(const uuid_t uu, char *out)
> + __attribute__((alias("uuid_unparse_lower")));
> +#endif
The alias attribute is not portable to clang on Darwin.
https://travis-ci.org/github/karelzak/util-linux/jobs/669244356?utm_medium=notification&utm_source=email
I have replaced the aliases with function calls.
https://github.com/karelzak/util-linux/commit/bee464006776203a8cb545a35c86234181c7a55a
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2020-04-01 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:38 [PATCH v2] libuuid: improve uuid_unparse() performance Aurelien LAJOIE
2020-03-31 13:30 ` Karel Zak
2020-04-01 8:31 ` Karel Zak [this message]
2020-04-01 9:34 ` Peter Cordes
2020-04-01 10:00 ` Karel Zak
2020-04-01 10:05 ` Karel Zak
2020-04-01 11:09 ` Peter Cordes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401083103.ipberscb6yzvpu4r@ws.net.home \
--to=kzak@redhat.com \
--cc=orel@melix.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).