From: Karel Zak <kzak@redhat.com>
To: Peter Cordes <peter@cordes.ca>
Cc: Aurelien LAJOIE <orel@melix.net>, util-linux@vger.kernel.org
Subject: Re: [PATCH v2] libuuid: improve uuid_unparse() performance
Date: Wed, 1 Apr 2020 12:05:56 +0200 [thread overview]
Message-ID: <20200401100556.ccc2p5mmtn7zqmxw@ws.net.home> (raw)
In-Reply-To: <20200401100005.tuamlrlrujfzr7yd@ws.net.home>
On Wed, Apr 01, 2020 at 12:00:09PM +0200, Karel Zak wrote:
> On Wed, Apr 01, 2020 at 06:34:06AM -0300, Peter Cordes wrote:
> > Or can we put the wrapper function in a .h so it can inline away?
> > That would bake the choice into applications that use libuuid, so you
> > couldn't change it just by rebuilding libuuid. That's perhaps not
> > desirable; if applications wanted to have that choice baked in they
> > could have called the explicit upper or lower versions.
>
> Frankly, what we're trying to fix by the alias? It sounds like
> premature optimization. The current solution works, maybe foo(bar())
> is also optimized by compiler. I have doubts that use inline function
> in header or so makes a real sense.
BTW, would be better to make uuid_fmt() as inline function as we use
it in uuid_unparse_lower(), uuid_unparse_upper() and uuid_unparse()?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2020-04-01 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:38 [PATCH v2] libuuid: improve uuid_unparse() performance Aurelien LAJOIE
2020-03-31 13:30 ` Karel Zak
2020-04-01 8:31 ` Karel Zak
2020-04-01 9:34 ` Peter Cordes
2020-04-01 10:00 ` Karel Zak
2020-04-01 10:05 ` Karel Zak [this message]
2020-04-01 11:09 ` Peter Cordes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401100556.ccc2p5mmtn7zqmxw@ws.net.home \
--to=kzak@redhat.com \
--cc=orel@melix.net \
--cc=peter@cordes.ca \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).