* [PATCH] bash-completion: umount explicitly needs gawk
@ 2020-04-28 7:13 Wolfram Sang
2020-04-29 10:33 ` Karel Zak
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2020-04-28 7:13 UTC (permalink / raw)
To: util-linux; +Cc: Wolfram Sang
gensub() is a gawk extension, so use it explicitly. Otherwise users will
get an error if their 'awk' defaults to something else.
Fixes: 3ebfc8d37 ("bash-completion: umount support relative path and ~ as home shorthands")
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
bash-completion/umount | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bash-completion/umount b/bash-completion/umount
index 7fc2bd376..0949688f9 100644
--- a/bash-completion/umount
+++ b/bash-completion/umount
@@ -51,7 +51,7 @@ _umount_module()
local oldifs=$IFS
IFS=$'\n'
- COMPREPLY=( $( compgen -W "$(findmnt -lno TARGET | awk \
+ COMPREPLY=( $( compgen -W "$(findmnt -lno TARGET | gawk \
'{
if ($0 ~ ENVIRON["HOME"]) {
homeless = $0
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bash-completion: umount explicitly needs gawk
2020-04-28 7:13 [PATCH] bash-completion: umount explicitly needs gawk Wolfram Sang
@ 2020-04-29 10:33 ` Karel Zak
0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2020-04-29 10:33 UTC (permalink / raw)
To: Wolfram Sang; +Cc: util-linux
On Tue, Apr 28, 2020 at 09:13:15AM +0200, Wolfram Sang wrote:
> gensub() is a gawk extension, so use it explicitly. Otherwise users will
> get an error if their 'awk' defaults to something else.
Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-29 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 7:13 [PATCH] bash-completion: umount explicitly needs gawk Wolfram Sang
2020-04-29 10:33 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).