fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck

fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck

[наб]

[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]

Downstream bug: https://bugs.debian.org/1062208

Just got
  [ 3030.473467] FAT-fs (mmcblk1p1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.
great idea! After unmounting I did
  # fsck /dev/mmcblk1p1
  fsck from util-linux 2.39.3
which is just --version. Maybe
  # fsck -AR
  fsck from util-linux 2.39.3
so also no.

strace says
  close(6</sys/devices/platform/soc/11240000.mmc/mmc_host/mmc1/mmc1:e624/block/mmcblk1/mmcblk1p1/start>) = 0
  close(5</sys/devices/platform/soc/11240000.mmc/mmc_host/mmc1/mmc1:e624/block/mmcblk1/mmcblk1p1>) = 0
  close(3</dev/mmcblk1p1>)                = 0
  munmap(0xffffa8eb7000, 266240)          = 0
  munmap(0xffffa8e76000, 266240)          = 0
  munmap(0xffffa8e35000, 266240)          = 0
  munmap(0xffffa8df4000, 266240)          = 0
  close(4</dev/mmcblk1>)                  = 0
  faccessat(AT_FDCWD</root>, "/usr/local/sbin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  faccessat(AT_FDCWD</root>, "/usr/local/bin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  faccessat(AT_FDCWD</root>, "/usr/sbin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  faccessat(AT_FDCWD</root>, "/usr/bin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  faccessat(AT_FDCWD</root>, "/sbin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  faccessat(AT_FDCWD</root>, "/bin/fsck.vfat", X_OK) = -1 ENOENT (No such file or directory)
  dup(1<pipe:[10683]>)                    = 3<pipe:[10683]>
  close(3<pipe:[10683]>)                  = 0
  dup(2<pipe:[10683]>)                    = 3<pipe:[10683]>
  close(3<pipe:[10683]>)                  = 0
  exit_group(0)                           = ?
  +++ exited with 0 +++
which looks like a failed path traversal and then nothing?

I think in -A mode it makes sense to silently ignore a lack of type-specific fsck.
But when explicitly requesting fsck /dev/whatever, that condition
should at /least/ warn (I'm assuming erroring out would be too invasive),
because right now fsck cleared my potentially-broken filesystem w/o checks.

Best,
наб

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck

[Karel Zak]

On Wed, Feb 07, 2024 at 06:52:47PM +0100, наб wrote:
> I think in -A mode it makes sense to silently ignore a lack of type-specific fsck.
> But when explicitly requesting fsck /dev/whatever, that condition
> should at /least/ warn (I'm assuming erroring out would be too invasive),
> because right now fsck cleared my potentially-broken filesystem w/o checks.

 Good idea, possible improvements:
 https://github.com/util-linux/util-linux/pull/2777

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: fsck exits 0 with no output (just version) when it doesn't find a type-specific fsck

[наб]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

On Thu, Feb 08, 2024 at 12:55:49PM +0100, Karel Zak wrote:
> On Wed, Feb 07, 2024 at 06:52:47PM +0100, наб wrote:
> > I think in -A mode it makes sense to silently ignore a lack of type-specific fsck.
> > But when explicitly requesting fsck /dev/whatever, that condition
> > should at /least/ warn (I'm assuming erroring out would be too invasive),
> > because right now fsck cleared my potentially-broken filesystem w/o checks.
>  Good idea, possible improvements:
>  https://github.com/util-linux/util-linux/pull/2777
Looks good, works for me.

(The warning is in slavic word order, though; 
 ought to be "fsck.%s not found".)

Best,
наб

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]