From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
Jason Wang <jasowang@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
sgarzare@redhat.com, nrupal.jani@intel.com,
Piotr.Uminski@intel.com, hang.yuan@intel.com,
virtio@lists.oasis-open.org, pasic@linux.ibm.com,
Shahaf Shuler <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: Re: [virtio-comment] Re: [virtio] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues
Date: Thu, 9 Mar 2023 10:56:51 -0500 [thread overview]
Message-ID: <20230309155651.GA387087@fedora> (raw)
In-Reply-To: <20230309085432-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]
On Thu, Mar 09, 2023 at 08:55:15AM -0500, Michael S. Tsirkin wrote:
> On Thu, Mar 09, 2023 at 07:35:42AM -0500, Stefan Hajnoczi wrote:
> > On Wed, Mar 08, 2023 at 12:21:46PM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Mar 08, 2023 at 12:15:23PM -0500, Stefan Hajnoczi wrote:
> > > > > > > > Or we could say that admin commands must complete within bounded time,
> > > > > > > > but I'm not sure that is implementable for some device types like
> > > > > > > > virtio-blk, virtio-scsi, and virtiofs.
> > > > > > >
> > > > > > > No we can't.
> > > > > > > Some commands, for example FW upgrade can take 10 minutes and it's perfectly
> > > > > > > fine. Other commands like setting feature bit will take 1 millisec.
> > > > > > > Each device implements commands in a different internal logic so we can't
> > > > > > > expect to complete after X time.
> > > > > >
> > > > > > When I say bounded time, I mean that it finishes in a finite amount of
> > > > > > time. I'm not saying there is a specific time X that all device
> > > > > > implementations must satisfy. Unbounded means it might never finish.
> > > > >
> > > > > There might be a chance that any command for any virtio device type will
> > > > > never finish. Nothing new here in the adminq.
> > > > >
> > > > > what one can do is to set a timeout for himself and if this timeout expire -
> > > > > check the device status. If it needs_reset - do a reset. if status is ok,
> > > > > then wait some more time.
> > > > > After X retries, unmap buffers or reset the adminq.
> > > >
> > > > Michael: What effect does resetting the group owner device have on group
> > > > member devices?
> > >
> > > virtio level reset? It's a good question. I'd expect them all to be
> > > reset no?
> > >
> > > > I'm concerned that this approach disrupts all group member devices. For
> > > > example, you try to add a new device but the command hangs. In order to
> > > > recover you now have to reset the group owner device and this breaks all
> > > > the group member devices.
> > >
> > >
> > > I agree. How about a VQ level reset though? Seems like exactly
> > > what's needed here?
> >
> > Yes, a new virtqueue-level reset feature would take care of this case.
> >
> > Stefan
>
> Why would we need a new one? We already have VIRTIO_F_RING_RESET.
I was unaware :).
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-09 15:56 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1677761896.git.mst@redhat.com>
2023-03-06 16:40 ` [virtio-comment] [PATCH v10 00/10] Introduce device group and device management Jiri Pirko
2023-03-06 22:48 ` Michael S. Tsirkin
2023-03-07 7:17 ` Jiri Pirko
2023-03-07 17:15 ` Michael S. Tsirkin
[not found] ` <2d232eba17d75c5dad2db17dc297f34a3612c33e.1677761896.git.mst@redhat.com>
2023-03-06 17:00 ` [virtio-comment] Re: [virtio] [PATCH v10 02/10] admin: introduce device group and related concepts David Edmondson
[not found] ` <0a784140387c2a592f7e1e7bbc5ae926ec5b45da.1677761896.git.mst@redhat.com>
[not found] ` <m2leka0yvl.fsf@oracle.com>
2023-03-06 22:00 ` [virtio-comment] Re: [virtio] [PATCH v10 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-03-07 10:04 ` David Edmondson
2023-03-08 14:16 ` Cornelia Huck
2023-03-08 15:04 ` Michael S. Tsirkin
[not found] ` <ZAXcqqdwfoLokT2l@nanopsycho>
2023-03-06 22:54 ` [virtio-comment] [PATCH v10 00/10] Introduce device group and device management Michael S. Tsirkin
2023-03-07 7:21 ` Jiri Pirko
2023-03-07 17:20 ` Michael S. Tsirkin
2023-03-07 19:31 ` Parav Pandit
2023-03-08 5:11 ` Jason Wang
2023-03-08 12:02 ` Parav Pandit
2023-03-10 8:32 ` Zhu, Lingshan
2023-03-08 9:49 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 16:30 ` Cornelia Huck
2023-03-08 17:22 ` Michael S. Tsirkin
2023-03-08 18:15 ` Jiri Pirko
[not found] ` <910b3607a5f255134d30b3e1233e564f564eafb8.1677761896.git.mst@redhat.com>
[not found] ` <20230302201011.GB2554028@fedora>
[not found] ` <20230302185214-mutt-send-email-mst@kernel.org>
[not found] ` <20230303131337.GA2866370@fedora>
[not found] ` <20230303081515-mutt-send-email-mst@kernel.org>
2023-03-03 20:23 ` [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands Stefan Hajnoczi
2023-03-07 11:31 ` [virtio-comment] Re: [virtio-dev] " Jiri Pirko
2023-03-08 12:03 ` Michael S. Tsirkin
2023-03-07 10:31 ` [virtio-comment] Re: [virtio] " David Edmondson
[not found] ` <PH0PR12MB548116853CAC23DF9CA7345EDCB29@PH0PR12MB5481.namprd12.prod.outlook.com>
[not found] ` <20230302184447-mutt-send-email-mst@kernel.org>
2023-03-07 18:26 ` [virtio-comment] " Parav Pandit
2023-03-15 10:44 ` [virtio-comment] " Max Gurtovoy
[not found] ` <20230302201912.GC2554028@fedora>
[not found] ` <20230302185803-mutt-send-email-mst@kernel.org>
[not found] ` <20230303131703.GB2866370@fedora>
[not found] ` <20230303081900-mutt-send-email-mst@kernel.org>
[not found] ` <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com>
2023-03-07 18:33 ` [virtio-comment] " Parav Pandit
2023-03-08 0:34 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 1:01 ` [virtio-comment] " Parav Pandit
2023-03-08 1:06 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 1:14 ` [virtio-comment] " Parav Pandit
2023-03-08 10:55 ` [virtio-comment] " Max Gurtovoy
2023-03-08 12:07 ` Michael S. Tsirkin
2023-03-08 13:05 ` Max Gurtovoy
2023-03-08 14:43 ` Cornelia Huck
2023-03-08 14:54 ` Michael S. Tsirkin
2023-03-08 15:21 ` Michael S. Tsirkin
2023-03-09 0:29 ` Max Gurtovoy
2023-03-09 6:38 ` Michael S. Tsirkin
[not found] ` <20c81b66f0b21b5bd646c24840ac3f8462c86acf.1677761896.git.mst@redhat.com>
[not found] ` <20230302204007.GD2554028@fedora>
[not found] ` <20230302190230-mutt-send-email-mst@kernel.org>
[not found] ` <20230303132840.GC2866370@fedora>
2023-03-03 13:37 ` [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-03-03 20:21 ` [virtio-comment] Re: [virtio] " Stefan Hajnoczi
2023-03-05 9:38 ` Michael S. Tsirkin
2023-03-06 0:03 ` Stefan Hajnoczi
2023-03-06 0:18 ` Michael S. Tsirkin
[not found] ` <20230306110340.GA35392@fedora>
2023-03-06 18:37 ` Michael S. Tsirkin
2023-03-06 20:17 ` Stefan Hajnoczi
2023-03-06 21:43 ` Michael S. Tsirkin
2023-03-31 11:07 ` Michael S. Tsirkin
2023-03-07 8:03 ` Jiri Pirko
2023-03-07 14:39 ` Stefan Hajnoczi
2023-03-07 15:07 ` Jiri Pirko
2023-03-07 19:03 ` Stefan Hajnoczi
2023-03-07 19:09 ` Parav Pandit
2023-03-08 5:17 ` [virtio-comment] Re: [virtio] " Jason Wang
2023-03-08 11:58 ` Stefan Hajnoczi
2023-03-08 11:59 ` Michael S. Tsirkin
2023-03-08 10:17 ` Jiri Pirko
2023-03-08 12:44 ` Stefan Hajnoczi
2023-03-08 12:57 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 17:17 ` Stefan Hajnoczi
2023-03-07 16:13 ` Michael S. Tsirkin
2023-03-08 10:08 ` Jiri Pirko
2023-03-08 11:44 ` Michael S. Tsirkin
[not found] ` <7f63fa0a-7deb-5875-6c6b-bfc651681653@redhat.com>
[not found] ` <20230306112030.GB35392@fedora>
2023-03-06 15:28 ` Max Gurtovoy
2023-03-06 16:25 ` Stefan Hajnoczi
2023-03-07 19:04 ` [virtio-comment] " Parav Pandit
2023-03-08 11:17 ` [virtio-comment] " Max Gurtovoy
2023-03-08 14:13 ` Stefan Hajnoczi
2023-03-08 16:19 ` Max Gurtovoy
2023-03-08 17:15 ` Stefan Hajnoczi
2023-03-08 17:21 ` Michael S. Tsirkin
2023-03-09 12:35 ` Stefan Hajnoczi
2023-03-09 13:55 ` Michael S. Tsirkin
2023-03-09 15:56 ` Stefan Hajnoczi [this message]
2023-03-08 16:21 ` Parav Pandit
[not found] ` <e8d41902-b794-66e9-8f15-e8617435047c@redhat.com>
2023-03-06 16:22 ` Jiri Pirko
[not found] ` <027fff1b-8ed7-abc0-2331-b188b8822bf4@nvidia.com>
2023-03-06 22:49 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 20:58 ` Max Gurtovoy
2023-03-08 21:09 ` Michael S. Tsirkin
2023-03-08 21:17 ` Parav Pandit
2023-03-09 7:28 ` [virtio-comment] Re: [virtio-dev] " Jiri Pirko
2023-03-07 7:56 ` Jiri Pirko
[not found] ` <ZAXfegxCfvfLwiJT@nanopsycho>
2023-03-06 15:37 ` [virtio-comment] Re: [virtio] " Max Gurtovoy
2023-03-06 18:44 ` Michael S. Tsirkin
2023-03-06 18:40 ` Michael S. Tsirkin
2023-03-07 7:36 ` Jiri Pirko
2023-03-07 16:30 ` Michael S. Tsirkin
2023-03-08 10:05 ` Jiri Pirko
2023-03-08 11:50 ` Michael S. Tsirkin
2023-03-08 12:08 ` Jiri Pirko
2023-03-08 17:29 ` Max Gurtovoy
2023-03-08 18:01 ` David Edmondson
2023-03-08 18:19 ` Jiri Pirko
2023-03-08 21:25 ` Parav Pandit
2023-03-09 7:30 ` Jiri Pirko
2023-03-09 13:04 ` Parav Pandit
2023-03-09 13:57 ` Michael S. Tsirkin
2023-03-09 14:02 ` David Edmondson
2023-03-09 14:11 ` Parav Pandit
2023-03-09 14:22 ` Michael S. Tsirkin
2023-03-09 14:30 ` Parav Pandit
2023-03-09 14:43 ` Michael S. Tsirkin
2023-03-09 16:53 ` Parav Pandit
2023-03-09 17:14 ` Michael S. Tsirkin
2023-03-09 17:16 ` Parav Pandit
2023-03-08 21:45 ` Parav Pandit
2023-03-09 7:37 ` Jiri Pirko
2023-03-09 12:36 ` Parav Pandit
2023-03-09 16:32 ` Jiri Pirko
2023-03-07 10:41 ` David Edmondson
[not found] ` <80c4bc60c9119f68b66f5a003564cec719cc1487.1677761896.git.mst@redhat.com>
2023-03-07 10:54 ` [virtio-comment] Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery David Edmondson
[not found] ` <ZAXbBgN2jw8RhE/3@nanopsycho>
2023-03-08 11:54 ` Michael S. Tsirkin
2023-03-08 12:41 ` Jiri Pirko
2023-03-31 11:43 ` Michael S. Tsirkin
2023-03-08 12:38 ` Jiri Pirko
2023-03-10 8:14 ` [virtio-comment] " Zhu, Lingshan
[not found] ` <20230302210929.GH2554028@fedora>
2023-03-31 11:39 ` Michael S. Tsirkin
[not found] ` <6677477d48dfc234d3d1a339fb39d8fa2a3b983d.1677761896.git.mst@redhat.com>
2023-03-07 11:04 ` [virtio-comment] [PATCH v10 09/10] admin: conformance clauses David Edmondson
2023-03-08 11:58 ` Michael S. Tsirkin
2023-03-08 12:59 ` David Edmondson
2023-03-08 13:05 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 13:22 ` Michael S. Tsirkin
2023-03-08 13:44 ` David Edmondson
2023-03-08 14:02 ` Jiri Pirko
2023-03-08 14:12 ` Michael S. Tsirkin
2023-03-10 9:10 ` [virtio-comment] " Zhu, Lingshan
2023-03-10 9:13 ` Michael S. Tsirkin
2023-03-10 18:00 ` Zhu Lingshan
2023-03-10 9:34 ` Michael S. Tsirkin
[not found] ` <dd9c34ed74ee296228562f6946d4ca3f2fbee1e1.1677761896.git.mst@redhat.com>
[not found] ` <PH0PR12MB5481595368C8F0C0E16B681BDCB29@PH0PR12MB5481.namprd12.prod.outlook.com>
[not found] ` <20230303032434-mutt-send-email-mst@kernel.org>
[not found] ` <ZAXB44F3MS9CxIiK@nanopsycho>
2023-03-06 18:46 ` [virtio-comment] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-03-07 7:40 ` Jiri Pirko
2023-03-07 18:52 ` [virtio-comment] " Parav Pandit
2023-03-08 16:24 ` Cornelia Huck
2023-03-08 16:37 ` Parav Pandit
2023-03-08 16:30 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 18:21 ` [virtio-comment] Re: [virtio] " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309155651.GA387087@fedora \
--to=stefanha@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=cohuck@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nrupal.jani@intel.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).