From: Jiri Pirko <jiri@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com,
nrupal.jani@intel.com, Piotr.Uminski@intel.com,
hang.yuan@intel.com, virtio@lists.oasis-open.org,
Zhu Lingshan <lingshan.zhu@intel.com>,
pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-comment] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues
Date: Tue, 7 Mar 2023 08:36:41 +0100 [thread overview]
Message-ID: <ZAbpiRVdo8BciELX@nanopsycho> (raw)
In-Reply-To: <20230306133816-mutt-send-email-mst@kernel.org>
Mon, Mar 06, 2023 at 07:40:38PM CET, mst@redhat.com wrote:
>On Mon, Mar 06, 2023 at 01:41:30PM +0100, Jiri Pirko wrote:
>> Thu, Mar 02, 2023 at 02:05:06PM CET, mst@redhat.com wrote:
>> >The admin virtqueues will be the first interface to issue admin commands.
>> >
>> >Currently virtio specification defines control virtqueue to manipulate
>> >features and configuration of the device it operates on. However,
>> >control virtqueue commands are device type specific, which makes it very
>> >difficult to extend for device agnostic commands.
>> >
>> >To support this requirement in a more generic way, this patch introduces
>> >a new admin virtqueue interface.
>> >
>> >We also support more than one admin virtqueue, for QoS and
>> >scalability requirements.
>> >
>> >Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> >Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> >---
>> > admin.tex | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> > content.tex | 7 +++--
>> > 2 files changed, 79 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/admin.tex b/admin.tex
>> >index 7e28b77..3ffac2e 100644
>> >--- a/admin.tex
>> >+++ b/admin.tex
>> >@@ -155,3 +155,77 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
>> > \field{command_specific_data} and \field{command_specific_result}
>> > depends on these structures and is described separately or is
>> > implicit in the structure description.
>> >+
>> >+\section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues}
>> >+
>> >+An administration virtqueue of an owner device is used to submit
>> >+group administration commands. An owner device can have more
>>
>> I admit I'm confused. You introduce a concept of admin virtqueue, which
>> sounds quite generic to me, usable in future by much more things than
>> "device groups", correct?
>>
>> If yes, here you say "group administration commands" which contradics
>> that idea. On multiple places the text this patchset introduces
>> this very muych tights to groups. Like in struct virtio_admin_cmd
>> which contains fields very specific to groups.
>>
>> If no, isn't it a mistake as the admin queue should be here to
>> handle more than just group commands?
>
>For now, no.
Hmm, if not for now, the future exension would not be so simple, I fear.
>
>Passing commands to devices themselves is already covered in spec
>reasonably well though not in a generic way.
You mean using the control queue, correct?
From one of the patch description of this patchset I understand that you
cannot use control queue for this because control queue is
device-specific, yet group control is device-agnostic.
My undestanding therefore was, that the admin queue you are introducing
serves as a generic carrier for device-agnostic commands, in parallel
for having control queue serving as a generic carrier of device-specific
commands. If this is not the case, I think it would be nice to describe
the exact monivation and scope of admin queue.
>
>What we lack is passing commands about one device to another device.
>E.g. control VFs through PFs.
Could you provide examples of such commands please?
>This is what groups do.
>But if we see more uses we can always add them.
>
>
>I'd rather avoid being too generic though.
In that case, why not to avoid using generic terms and stay
"group-centric"? What I mean is:
"Administration Virtqueues" -> "Group Administration Virtqueues"
"struct virtio_admin_cmd" -> "struct virtio_group_admin_cmd"
Etc. Helps to avoid confusion.
>
>
>
>
>>
>> >+than one administration virtqueue.
[...]
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-07 7:36 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1677761896.git.mst@redhat.com>
2023-03-06 16:40 ` [virtio-comment] [PATCH v10 00/10] Introduce device group and device management Jiri Pirko
2023-03-06 22:48 ` Michael S. Tsirkin
2023-03-07 7:17 ` Jiri Pirko
2023-03-07 17:15 ` Michael S. Tsirkin
[not found] ` <2d232eba17d75c5dad2db17dc297f34a3612c33e.1677761896.git.mst@redhat.com>
2023-03-06 17:00 ` [virtio-comment] Re: [virtio] [PATCH v10 02/10] admin: introduce device group and related concepts David Edmondson
[not found] ` <0a784140387c2a592f7e1e7bbc5ae926ec5b45da.1677761896.git.mst@redhat.com>
[not found] ` <m2leka0yvl.fsf@oracle.com>
2023-03-06 22:00 ` [virtio-comment] Re: [virtio] [PATCH v10 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-03-07 10:04 ` David Edmondson
2023-03-08 14:16 ` Cornelia Huck
2023-03-08 15:04 ` Michael S. Tsirkin
[not found] ` <ZAXcqqdwfoLokT2l@nanopsycho>
2023-03-06 22:54 ` [virtio-comment] [PATCH v10 00/10] Introduce device group and device management Michael S. Tsirkin
2023-03-07 7:21 ` Jiri Pirko
2023-03-07 17:20 ` Michael S. Tsirkin
2023-03-07 19:31 ` Parav Pandit
2023-03-08 5:11 ` Jason Wang
2023-03-08 12:02 ` Parav Pandit
2023-03-10 8:32 ` Zhu, Lingshan
2023-03-08 9:49 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 16:30 ` Cornelia Huck
2023-03-08 17:22 ` Michael S. Tsirkin
2023-03-08 18:15 ` Jiri Pirko
[not found] ` <910b3607a5f255134d30b3e1233e564f564eafb8.1677761896.git.mst@redhat.com>
[not found] ` <20230302201011.GB2554028@fedora>
[not found] ` <20230302185214-mutt-send-email-mst@kernel.org>
[not found] ` <20230303131337.GA2866370@fedora>
[not found] ` <20230303081515-mutt-send-email-mst@kernel.org>
2023-03-03 20:23 ` [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands Stefan Hajnoczi
2023-03-07 11:31 ` [virtio-comment] Re: [virtio-dev] " Jiri Pirko
2023-03-08 12:03 ` Michael S. Tsirkin
2023-03-07 10:31 ` [virtio-comment] Re: [virtio] " David Edmondson
[not found] ` <PH0PR12MB548116853CAC23DF9CA7345EDCB29@PH0PR12MB5481.namprd12.prod.outlook.com>
[not found] ` <20230302184447-mutt-send-email-mst@kernel.org>
2023-03-07 18:26 ` [virtio-comment] " Parav Pandit
2023-03-15 10:44 ` [virtio-comment] " Max Gurtovoy
[not found] ` <20230302201912.GC2554028@fedora>
[not found] ` <20230302185803-mutt-send-email-mst@kernel.org>
[not found] ` <20230303131703.GB2866370@fedora>
[not found] ` <20230303081900-mutt-send-email-mst@kernel.org>
[not found] ` <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com>
2023-03-07 18:33 ` [virtio-comment] " Parav Pandit
2023-03-08 0:34 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 1:01 ` [virtio-comment] " Parav Pandit
2023-03-08 1:06 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 1:14 ` [virtio-comment] " Parav Pandit
2023-03-08 10:55 ` [virtio-comment] " Max Gurtovoy
2023-03-08 12:07 ` Michael S. Tsirkin
2023-03-08 13:05 ` Max Gurtovoy
2023-03-08 14:43 ` Cornelia Huck
2023-03-08 14:54 ` Michael S. Tsirkin
2023-03-08 15:21 ` Michael S. Tsirkin
2023-03-09 0:29 ` Max Gurtovoy
2023-03-09 6:38 ` Michael S. Tsirkin
[not found] ` <20c81b66f0b21b5bd646c24840ac3f8462c86acf.1677761896.git.mst@redhat.com>
[not found] ` <20230302204007.GD2554028@fedora>
[not found] ` <20230302190230-mutt-send-email-mst@kernel.org>
[not found] ` <20230303132840.GC2866370@fedora>
2023-03-03 13:37 ` [virtio-comment] Re: [PATCH v10 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-03-03 20:21 ` [virtio-comment] Re: [virtio] " Stefan Hajnoczi
2023-03-05 9:38 ` Michael S. Tsirkin
2023-03-06 0:03 ` Stefan Hajnoczi
2023-03-06 0:18 ` Michael S. Tsirkin
[not found] ` <20230306110340.GA35392@fedora>
2023-03-06 18:37 ` Michael S. Tsirkin
2023-03-06 20:17 ` Stefan Hajnoczi
2023-03-06 21:43 ` Michael S. Tsirkin
2023-03-31 11:07 ` Michael S. Tsirkin
2023-03-07 8:03 ` Jiri Pirko
2023-03-07 14:39 ` Stefan Hajnoczi
2023-03-07 15:07 ` Jiri Pirko
2023-03-07 19:03 ` Stefan Hajnoczi
2023-03-07 19:09 ` Parav Pandit
2023-03-08 5:17 ` [virtio-comment] Re: [virtio] " Jason Wang
2023-03-08 11:58 ` Stefan Hajnoczi
2023-03-08 11:59 ` Michael S. Tsirkin
2023-03-08 10:17 ` Jiri Pirko
2023-03-08 12:44 ` Stefan Hajnoczi
2023-03-08 12:57 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 17:17 ` Stefan Hajnoczi
2023-03-07 16:13 ` Michael S. Tsirkin
2023-03-08 10:08 ` Jiri Pirko
2023-03-08 11:44 ` Michael S. Tsirkin
[not found] ` <7f63fa0a-7deb-5875-6c6b-bfc651681653@redhat.com>
[not found] ` <20230306112030.GB35392@fedora>
2023-03-06 15:28 ` Max Gurtovoy
2023-03-06 16:25 ` Stefan Hajnoczi
2023-03-07 19:04 ` [virtio-comment] " Parav Pandit
2023-03-08 11:17 ` [virtio-comment] " Max Gurtovoy
2023-03-08 14:13 ` Stefan Hajnoczi
2023-03-08 16:19 ` Max Gurtovoy
2023-03-08 17:15 ` Stefan Hajnoczi
2023-03-08 17:21 ` Michael S. Tsirkin
2023-03-09 12:35 ` Stefan Hajnoczi
2023-03-09 13:55 ` Michael S. Tsirkin
2023-03-09 15:56 ` Stefan Hajnoczi
2023-03-08 16:21 ` Parav Pandit
[not found] ` <e8d41902-b794-66e9-8f15-e8617435047c@redhat.com>
2023-03-06 16:22 ` Jiri Pirko
[not found] ` <027fff1b-8ed7-abc0-2331-b188b8822bf4@nvidia.com>
2023-03-06 22:49 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 20:58 ` Max Gurtovoy
2023-03-08 21:09 ` Michael S. Tsirkin
2023-03-08 21:17 ` Parav Pandit
2023-03-09 7:28 ` [virtio-comment] Re: [virtio-dev] " Jiri Pirko
2023-03-07 7:56 ` Jiri Pirko
[not found] ` <ZAXfegxCfvfLwiJT@nanopsycho>
2023-03-06 15:37 ` [virtio-comment] Re: [virtio] " Max Gurtovoy
2023-03-06 18:44 ` Michael S. Tsirkin
2023-03-06 18:40 ` Michael S. Tsirkin
2023-03-07 7:36 ` Jiri Pirko [this message]
2023-03-07 16:30 ` Michael S. Tsirkin
2023-03-08 10:05 ` Jiri Pirko
2023-03-08 11:50 ` Michael S. Tsirkin
2023-03-08 12:08 ` Jiri Pirko
2023-03-08 17:29 ` Max Gurtovoy
2023-03-08 18:01 ` David Edmondson
2023-03-08 18:19 ` Jiri Pirko
2023-03-08 21:25 ` Parav Pandit
2023-03-09 7:30 ` Jiri Pirko
2023-03-09 13:04 ` Parav Pandit
2023-03-09 13:57 ` Michael S. Tsirkin
2023-03-09 14:02 ` David Edmondson
2023-03-09 14:11 ` Parav Pandit
2023-03-09 14:22 ` Michael S. Tsirkin
2023-03-09 14:30 ` Parav Pandit
2023-03-09 14:43 ` Michael S. Tsirkin
2023-03-09 16:53 ` Parav Pandit
2023-03-09 17:14 ` Michael S. Tsirkin
2023-03-09 17:16 ` Parav Pandit
2023-03-08 21:45 ` Parav Pandit
2023-03-09 7:37 ` Jiri Pirko
2023-03-09 12:36 ` Parav Pandit
2023-03-09 16:32 ` Jiri Pirko
2023-03-07 10:41 ` David Edmondson
[not found] ` <80c4bc60c9119f68b66f5a003564cec719cc1487.1677761896.git.mst@redhat.com>
2023-03-07 10:54 ` [virtio-comment] Re: [virtio-dev] [PATCH v10 08/10] admin: command list discovery David Edmondson
[not found] ` <ZAXbBgN2jw8RhE/3@nanopsycho>
2023-03-08 11:54 ` Michael S. Tsirkin
2023-03-08 12:41 ` Jiri Pirko
2023-03-31 11:43 ` Michael S. Tsirkin
2023-03-08 12:38 ` Jiri Pirko
2023-03-10 8:14 ` [virtio-comment] " Zhu, Lingshan
[not found] ` <20230302210929.GH2554028@fedora>
2023-03-31 11:39 ` Michael S. Tsirkin
[not found] ` <6677477d48dfc234d3d1a339fb39d8fa2a3b983d.1677761896.git.mst@redhat.com>
2023-03-07 11:04 ` [virtio-comment] [PATCH v10 09/10] admin: conformance clauses David Edmondson
2023-03-08 11:58 ` Michael S. Tsirkin
2023-03-08 12:59 ` David Edmondson
2023-03-08 13:05 ` [virtio-comment] Re: [virtio] " Jiri Pirko
2023-03-08 13:22 ` Michael S. Tsirkin
2023-03-08 13:44 ` David Edmondson
2023-03-08 14:02 ` Jiri Pirko
2023-03-08 14:12 ` Michael S. Tsirkin
2023-03-10 9:10 ` [virtio-comment] " Zhu, Lingshan
2023-03-10 9:13 ` Michael S. Tsirkin
2023-03-10 18:00 ` Zhu Lingshan
2023-03-10 9:34 ` Michael S. Tsirkin
[not found] ` <dd9c34ed74ee296228562f6946d4ca3f2fbee1e1.1677761896.git.mst@redhat.com>
[not found] ` <PH0PR12MB5481595368C8F0C0E16B681BDCB29@PH0PR12MB5481.namprd12.prod.outlook.com>
[not found] ` <20230303032434-mutt-send-email-mst@kernel.org>
[not found] ` <ZAXB44F3MS9CxIiK@nanopsycho>
2023-03-06 18:46 ` [virtio-comment] Re: [virtio] Re: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-03-07 7:40 ` Jiri Pirko
2023-03-07 18:52 ` [virtio-comment] " Parav Pandit
2023-03-08 16:24 ` Cornelia Huck
2023-03-08 16:37 ` Parav Pandit
2023-03-08 16:30 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 18:21 ` [virtio-comment] Re: [virtio] " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAbpiRVdo8BciELX@nanopsycho \
--to=jiri@nvidia.com \
--cc=Piotr.Uminski@intel.com \
--cc=cohuck@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nrupal.jani@intel.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).