[virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation

[Parav Pandit <parav@nvidia.com>]

> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Wednesday, March 22, 2023 12:37 PM
> 
> On Wed, Mar 22 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> >> From: Cornelia Huck <cohuck@redhat.com>
> >> Sent: Wednesday, March 22, 2023 11:21 AM
> >>
> >> On Wed, Mar 22 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:
> >>
> >> > +The driver MUST NOT set \field{vqn} to any value other than an
> >> > +enabled
> >> transmit or receive virtqueue number.
> >>
> > Why do you suggest a negative statement here?
> > How is it better than,
> > The driver MUST set ...
> 
> So make it
> 
> "The driver MUST set \field{vqn} to the virtqueue number of an enabled
> transmit or receive virtqueue." ?
> 
Looks good.

> > The device will anyway have to check and apply the parameter to the right
> virtqueue.
> > And if the vq is not enabled or vq is not tx or rx vq, it needs to fail the
> command.
> 
> Well, I think we want to avoid having to add a normative statement for the
> device, so we need to be strict with what the driver is allowed to do.
Drivers are untrusted entities.
device normative statement is needed, it will do the checks anyway where it is applying the config.

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/