From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Heng Qi <hengqi@linux.alibaba.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Jason Wang <jasowang@redhat.com>,
Alvaro Karsz <alvaro.karsz@solid-run.com>,
David Edmondson <david.edmondson@oracle.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation
Date: Wed, 22 Mar 2023 12:53:26 -0400 [thread overview]
Message-ID: <20230322125058-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481B3FD31F529EDF420FACEDC869@PH0PR12MB5481.namprd12.prod.outlook.com>
On Wed, Mar 22, 2023 at 04:49:58PM +0000, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, March 22, 2023 12:47 PM
> >
> > I agree with Cornelia here. Yes if devices do not want to trust drivers then they
> > will validate input but what exactly happens then is currently up to device.
> > If we want to try and specify devices in all cases of out of spec input that's a big
> > project, certainly doable but I would rather not connect it to this, rather
> > boutique, feature.
> Both of your and Cornelia's comment is abstract to me.
> We cannot change past.
But we can make sure things are consistent. Currently we don't describe
device behaviour if driver is out of spec and I see 0 reasons to start
doing it with coalescing commands specifically.
> For the new command of interest here, hen driver supplied incorrect values, the device will return error.
It might be easier for device to just set NEEDS_RESET and stop
responding. For a hypervisor implementation that's often better than returning error
since device state is then preserved making things easier to debug.
> How to implement is upto the device to figure out.
what to do is also up to the device.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-22 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 12:51 [virtio-comment] [PATCH v13] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-03-22 15:20 ` [virtio-comment] " Cornelia Huck
2023-03-22 16:23 ` [virtio-comment] " Parav Pandit
2023-03-22 16:36 ` Cornelia Huck
2023-03-22 16:40 ` Parav Pandit
2023-03-22 16:44 ` Cornelia Huck
2023-03-22 16:46 ` Parav Pandit
2023-03-22 16:50 ` Michael S. Tsirkin
2023-03-22 16:46 ` Michael S. Tsirkin
2023-03-22 16:49 ` Parav Pandit
2023-03-22 16:53 ` Michael S. Tsirkin [this message]
2023-03-22 17:02 ` Parav Pandit
2023-03-23 2:26 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322125058-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).