From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"nrupal.jani@intel.com" <nrupal.jani@intel.com>,
"Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
"hang.yuan@intel.com" <hang.yuan@intel.com>,
"virtio@lists.oasis-open.org" <virtio@lists.oasis-open.org>,
Zhu Lingshan <lingshan.zhu@intel.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v10 02/10] admin: introduce device group and related concepts
Date: Thu, 2 Mar 2023 18:44:30 -0500 [thread overview]
Message-ID: <20230302184408-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481AF533A3C9FC0EFEB46DDDCB29@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Mar 02, 2023 at 06:39:47PM +0000, Parav Pandit wrote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Thursday, March 2, 2023 8:05 AM
> >
> > Each device group has a type. For now, define one initial group:
> >
> > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given PCI SR-IOV physical
> > function (PF). This group may contain zero or more virtio devices according to
> > NumVFs configured.
> >
> > Each device within a group has a unique identifier. This identifier is the group
> > member identifier.
> >
> > Note: one can argue both ways whether the new device group handling
> > functionality (this and following patches) is closer to a new device type or a
> > new transport type.
> >
> > However, I expect that we will add more features in the near future. To
> > facilitate this as much as possible of the text is located in the new admin
> > chapter.
> >
> > I did my best to minimize transport-specific text.
> >
> > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > admin.tex | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> > content.tex | 2 ++
> > 2 files changed, 51 insertions(+)
> > create mode 100644 admin.tex
> >
> You missed addressing the comments of [1].
> Can you please fix them?
>
> [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00235.html
Hmm oh ok. At least ): one for sure.
> > diff --git a/admin.tex b/admin.tex
> > new file mode 100644
> > index 0000000..3dc47be
> > --- /dev/null
> > +++ b/admin.tex
> > @@ -0,0 +1,49 @@
> > +\section{Device groups}\label{sec:Basic Facilities of a Virtio Device /
> > +Device groups}
> > +
> > +It is occasionally useful to have a device control a group of other
> > +devices. Terminology used in such cases:
> > +
> > +\begin{description}
> > +\item[Device group]
> > + or just group, includes zero or more devices.
> > +\item[Owner device]
> > + or owner, the device controlling the group.
> > +\item[Member device]
> > + a device within a group. The owner device itself is not
> > + a member of the group.
> > +\item[Member identifier]
> > + each member has this identifier, unique within the group
> > + and used to address it through the owner device.
> > +\item[Group type identifier]
> > + specifies what kind of member devices there are in a
> > + group, how is the member identifier is interpreted
> > + and what kind of control the owner has.
> > + A given owner can control a single group of a given type,
> > + thus the type and the owner together identify the group.
> > + \footnote{Even though some group types only support
> > + specific transports, group type identifiers
> > + are global rather than transport-specific -
> > + we don't expect a flood of new group types.}
> > \end{description}
> > +
> > +The following group types, and their identifiers, are currently specified):
> > +\begin{description}
> > +\item[SR-IOV group type (0x1)]
> > +This device group has a PCI Single Root I/O Virtualization
> > +(SR-IOV) physical function (PF) device as the owner and includes all
> > +its SR-IOV virtual functions (VFs) as members (see
> > +\hyperref[intro:PCIe]{[PCIe]}).
> > +
> > +The PF device itself is not a member of the group.
> > +
> > +The group type identifier for this group is 0x1.
> > +
> > +A member identifier for this group can have a value from 0x1 to 0xFFFF
> > +and equals the SR-IOV VF number of the member device (see
> > +\hyperref[intro:PCIe]{[PCIe]}).
> > +
> > +Both owner and member devices for this group type use the Virtio PCI
> > +transport (see \ref{sec:Virtio Transport Options / Virtio Over PCI Bus}).
> > +\end{description}
> > +
> > +
> > diff --git a/content.tex b/content.tex
> > index 0c2d917..ffe45c4 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -491,6 +491,8 @@ \section{Exporting Objects}\label{sec:Basic Facilities of
> > a Virtio Device / Expo types. It is RECOMMENDED that devices generate
> > version 4 UUIDs as specified by \hyperref[intro:rfc4122]{[RFC4122]}.
> >
> > +\input{admin.tex}
> > +
> > \chapter{General Initialization And Device Operation}\label{sec:General
> > Initialization And Device Operation}
> >
> > We start with an overview of device initialization, then expand on the
> > --
> > MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-02 23:44 UTC|newest]
Thread overview: 169+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:04 [virtio-dev] [PATCH v10 00/10] Introduce device group and device management Michael S. Tsirkin
2023-03-02 13:04 ` [virtio-dev] [PATCH v10 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-02 23:43 ` [virtio-dev] " Michael S. Tsirkin
[not found] ` <m2leka0yvl.fsf@oracle.com>
2023-03-06 22:00 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 10:04 ` David Edmondson
2023-03-08 14:16 ` Cornelia Huck
2023-03-08 15:04 ` Michael S. Tsirkin
2023-03-02 13:04 ` [virtio-dev] [PATCH v10 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-02 23:44 ` Michael S. Tsirkin [this message]
2023-03-02 19:40 ` [virtio-dev] Re: [virtio] " Stefan Hajnoczi
2023-03-06 17:00 ` David Edmondson
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 20:19 ` [virtio-dev] " Stefan Hajnoczi
2023-03-03 0:01 ` Michael S. Tsirkin
2023-03-03 13:17 ` Stefan Hajnoczi
2023-03-03 13:19 ` Michael S. Tsirkin
[not found] ` <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com>
2023-03-07 18:33 ` [virtio-dev] " Parav Pandit
2023-03-08 0:34 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 1:01 ` [virtio-dev] " Parav Pandit
2023-03-08 1:06 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 1:14 ` [virtio-dev] " Parav Pandit
[not found] ` <6668fd7a-3eb3-0447-9cbf-72d308b1336a@nvidia.com>
2023-03-08 12:07 ` [virtio-dev] " Michael S. Tsirkin
[not found] ` <992e9a1e-3799-842c-79f3-e66f5c823356@nvidia.com>
2023-03-08 14:43 ` Cornelia Huck
2023-03-08 14:54 ` Michael S. Tsirkin
2023-03-08 15:21 ` Michael S. Tsirkin
[not found] ` <2ef47f53-5978-4b6a-593d-4e94eba0b9ac@nvidia.com>
2023-03-09 6:38 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-02 23:47 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 18:26 ` [virtio-dev] " Parav Pandit
2023-03-02 20:10 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 23:57 ` Michael S. Tsirkin
2023-03-03 13:13 ` Stefan Hajnoczi
2023-03-03 13:18 ` Michael S. Tsirkin
2023-03-03 20:23 ` Stefan Hajnoczi
2023-03-07 11:31 ` Jiri Pirko
2023-03-08 12:03 ` Michael S. Tsirkin
2023-03-07 10:31 ` [virtio-dev] Re: [virtio] " David Edmondson
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 23:48 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 20:40 ` Stefan Hajnoczi
2023-03-03 0:05 ` Michael S. Tsirkin
2023-03-03 13:28 ` Stefan Hajnoczi
2023-03-03 13:37 ` Michael S. Tsirkin
2023-03-03 20:21 ` [virtio-dev] Re: [virtio] " Stefan Hajnoczi
2023-03-05 9:38 ` Michael S. Tsirkin
2023-03-06 0:03 ` Stefan Hajnoczi
2023-03-06 0:18 ` Michael S. Tsirkin
[not found] ` <20230306110340.GA35392@fedora>
2023-03-06 18:37 ` Michael S. Tsirkin
2023-03-06 20:17 ` Stefan Hajnoczi
2023-03-06 21:43 ` Michael S. Tsirkin
2023-03-31 11:07 ` Michael S. Tsirkin
2023-03-07 8:03 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-07 14:39 ` Stefan Hajnoczi
2023-03-07 15:07 ` Jiri Pirko
2023-03-07 19:03 ` Stefan Hajnoczi
2023-03-07 19:09 ` [virtio-dev] " Parav Pandit
2023-03-08 5:17 ` [virtio-dev] Re: [virtio] " Jason Wang
2023-03-08 11:58 ` Stefan Hajnoczi
2023-03-08 11:59 ` Michael S. Tsirkin
2023-03-08 10:17 ` [virtio-dev] " Jiri Pirko
2023-03-08 12:44 ` Stefan Hajnoczi
2023-03-08 12:57 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 17:17 ` Stefan Hajnoczi
2023-03-07 16:13 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 10:08 ` Jiri Pirko
2023-03-08 11:44 ` Michael S. Tsirkin
[not found] ` <7f63fa0a-7deb-5875-6c6b-bfc651681653@redhat.com>
[not found] ` <20230306112030.GB35392@fedora>
[not found] ` <853c78d0-f752-05e9-d79d-811e82801627@nvidia.com>
2023-03-06 16:25 ` [virtio-dev] " Stefan Hajnoczi
2023-03-07 19:04 ` [virtio-dev] " Parav Pandit
[not found] ` <e74483a4-38fa-99b5-86b8-785f0b98d029@nvidia.com>
2023-03-08 14:13 ` [virtio-dev] Re: [virtio-comment] " Stefan Hajnoczi
2023-03-08 16:21 ` [virtio-dev] " Parav Pandit
[not found] ` <18ddbf69-19a6-3c6b-9e42-aaae66e20bcf@nvidia.com>
2023-03-08 17:15 ` [virtio-dev] " Stefan Hajnoczi
2023-03-08 17:21 ` Michael S. Tsirkin
2023-03-09 12:35 ` Stefan Hajnoczi
2023-03-09 13:55 ` Michael S. Tsirkin
2023-03-09 15:56 ` Stefan Hajnoczi
[not found] ` <e8d41902-b794-66e9-8f15-e8617435047c@redhat.com>
2023-03-06 16:22 ` [virtio-dev] " Jiri Pirko
[not found] ` <027fff1b-8ed7-abc0-2331-b188b8822bf4@nvidia.com>
2023-03-06 22:49 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
[not found] ` <e12ab469-4586-f0f5-b084-8f2d7c031e11@nvidia.com>
2023-03-08 21:09 ` Michael S. Tsirkin
2023-03-08 21:17 ` [virtio-dev] " Parav Pandit
2023-03-09 7:28 ` [virtio-dev] " Jiri Pirko
2023-03-07 7:56 ` Jiri Pirko
[not found] ` <ZAXfegxCfvfLwiJT@nanopsycho>
2023-03-06 18:40 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 7:36 ` Jiri Pirko
2023-03-07 16:30 ` Michael S. Tsirkin
2023-03-08 10:05 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-08 11:50 ` Michael S. Tsirkin
2023-03-08 12:08 ` Jiri Pirko
[not found] ` <18d51bc0-d759-1a05-cb7c-3d46c4ed2f1a@nvidia.com>
2023-03-08 18:01 ` David Edmondson
2023-03-08 18:19 ` Jiri Pirko
2023-03-08 21:25 ` [virtio-dev] " Parav Pandit
2023-03-09 7:30 ` [virtio-dev] " Jiri Pirko
2023-03-09 13:04 ` [virtio-dev] " Parav Pandit
2023-03-09 13:57 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 14:02 ` [virtio-dev] " David Edmondson
2023-03-09 14:11 ` Parav Pandit
2023-03-09 14:22 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 14:30 ` [virtio-dev] " Parav Pandit
2023-03-09 14:43 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 16:53 ` [virtio-dev] " Parav Pandit
2023-03-09 17:14 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 17:16 ` [virtio-dev] " Parav Pandit
2023-03-08 21:45 ` Parav Pandit
2023-03-09 7:37 ` [virtio-dev] " Jiri Pirko
2023-03-09 12:36 ` [virtio-dev] " Parav Pandit
2023-03-09 16:32 ` [virtio-dev] " Jiri Pirko
[not found] ` <17471553-8981-eef9-656b-098e1acdda14@nvidia.com>
2023-03-06 18:44 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 10:41 ` David Edmondson
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-03-02 20:51 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 23:51 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 23:51 ` Michael S. Tsirkin
2023-03-03 8:34 ` Michael S. Tsirkin
[not found] ` <ZAXB44F3MS9CxIiK@nanopsycho>
2023-03-06 18:46 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 7:40 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-07 18:52 ` [virtio-dev] " Parav Pandit
2023-03-08 16:24 ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-03-08 16:37 ` [virtio-dev] " Parav Pandit
2023-03-08 16:30 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 18:21 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-02 20:52 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 07/10] ccw: " Michael S. Tsirkin
2023-03-02 20:53 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 08/10] admin: command list discovery Michael S. Tsirkin
2023-03-02 21:09 ` [virtio-dev] " Stefan Hajnoczi
2023-03-31 11:39 ` Michael S. Tsirkin
2023-03-07 10:54 ` [virtio-dev] " David Edmondson
[not found] ` <ZAXbBgN2jw8RhE/3@nanopsycho>
2023-03-08 11:54 ` Michael S. Tsirkin
2023-03-08 12:41 ` Jiri Pirko
2023-03-31 11:43 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-08 12:38 ` Jiri Pirko
2023-03-10 8:14 ` [virtio-dev] " Zhu, Lingshan
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 09/10] admin: conformance clauses Michael S. Tsirkin
2023-03-07 11:04 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-03-08 11:58 ` Michael S. Tsirkin
2023-03-08 12:59 ` David Edmondson
2023-03-08 13:05 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 13:22 ` Michael S. Tsirkin
2023-03-08 13:44 ` David Edmondson
2023-03-08 14:02 ` Jiri Pirko
2023-03-08 14:12 ` Michael S. Tsirkin
2023-03-10 9:10 ` [virtio-dev] " Zhu, Lingshan
2023-03-10 9:13 ` Michael S. Tsirkin
2023-03-10 18:00 ` Zhu Lingshan
2023-03-10 9:34 ` Michael S. Tsirkin
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-03-02 21:12 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:38 ` [virtio-dev] RE: [PATCH v10 00/10] Introduce device group and device management Parav Pandit
2023-03-02 23:27 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-06 16:40 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-06 22:48 ` Michael S. Tsirkin
2023-03-07 7:17 ` Jiri Pirko
2023-03-07 17:15 ` Michael S. Tsirkin
[not found] ` <ZAXcqqdwfoLokT2l@nanopsycho>
2023-03-06 22:54 ` Michael S. Tsirkin
2023-03-07 7:21 ` Jiri Pirko
2023-03-07 17:20 ` Michael S. Tsirkin
2023-03-07 19:31 ` [virtio-dev] " Parav Pandit
2023-03-08 5:11 ` [virtio-dev] " Jason Wang
2023-03-08 12:02 ` [virtio-dev] " Parav Pandit
2023-03-10 8:32 ` [virtio-dev] " Zhu, Lingshan
2023-03-08 9:49 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 16:30 ` [virtio-dev] " Cornelia Huck
2023-03-08 17:22 ` Michael S. Tsirkin
2023-03-08 18:15 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302184408-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=cohuck@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=nrupal.jani@intel.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).