From: David Edmondson <david.edmondson@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com,
stefanha@redhat.com, nrupal.jani@intel.com,
Piotr.Uminski@intel.com, hang.yuan@intel.com
Cc: virtio@lists.oasis-open.org,
Zhu Lingshan <lingshan.zhu@intel.com>,
pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [virtio] [PATCH v10 04/10] admin: introduce virtio admin virtqueues
Date: Tue, 07 Mar 2023 10:41:31 +0000 [thread overview]
Message-ID: <m2fsagzvvo.fsf@oracle.com> (raw)
In-Reply-To: <20c81b66f0b21b5bd646c24840ac3f8462c86acf.1677761896.git.mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> The admin virtqueues will be the first interface to issue admin commands.
"first interface used" ?
> Currently virtio specification defines control virtqueue to manipulate
"Currently the virtio specification defines the control virtqueue"
> features and configuration of the device it operates on. However,
> control virtqueue commands are device type specific, which makes it very
> difficult to extend for device agnostic commands.
>
> To support this requirement in a more generic way, this patch introduces
> a new admin virtqueue interface.
>
> We also support more than one admin virtqueue, for QoS and
> scalability requirements.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> admin.tex | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> content.tex | 7 +++--
> 2 files changed, 79 insertions(+), 2 deletions(-)
>
> diff --git a/admin.tex b/admin.tex
> index 7e28b77..3ffac2e 100644
> --- a/admin.tex
> +++ b/admin.tex
> @@ -155,3 +155,77 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> \field{command_specific_data} and \field{command_specific_result}
> depends on these structures and is described separately or is
> implicit in the structure description.
> +
> +\section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues}
> +
> +An administration virtqueue of an owner device is used to submit
> +group administration commands. An owner device can have more
> +than one administration virtqueue.
> +
> +If VIRTIO_F_ADMIN_VQ has been negotiated, an owner device exposes one
> +or more adminstration virtqueues. The number and locations of the
> +administration virtqueues are exposed by the owner device in a transport
> +specific manner.
> +
> +The driver submits commands by queueing them to an arbitrary
> +administration virtqueue, and they are processed by the
> +device in the order in which they are queued. It is the
> +responsibility of the driver to ensure ordering for commands
> +placed on different administration virtqueues, because they will
> +be executed with no order constraints.
> +
> +Administration virtqueues are used as follows:
> +\begin{itemize}
> +\item The driver submits the command using the \field{struct virtio_admin_cmd}
> +structure using a buffer consisting of two parts: a device-readable one followed by a
> +device-writable one.
> +\item the device-readable part includes fields from \field{opcode}
> +through \field{command_specific_data}.
> +\item the device-writeable buffer includes fields from \field{status}
> +through \field{command_specific_result} inclusive.
> +\end{itemize}
> +
> +For each command, this specification describes a distinct
> +format structure used for \field{command_specific_data} and
> +\field{command_specific_result}, the length of these fields
> +depends on the command.
> +
> +However, to ensure forward compatibility
> +\begin{itemize}
> +\item drivers are allowed to submit buffers that are longer
> +than what the device expects
s/what//
> +(that is, longer than the length of
> +\field{opcode} through \field{command_specific_data}).
> +This allows the driver to maintain
> +a single format structure even if some structure fields are
> +unused by the device.
> +\item drivers are allowed to submit buffers that are shorter
> +than what the device expects
> +(that is, shorter than the length of \field{status} through
> +\field{command_specific_result}). This allows the device to maintain
> +a single format structure even if some structure fields are
> +unused by the driver.
> +\end{itemize}
Given that the previous patch declared this as a single data structure
(containing both command and result), with no length indicators for the
command specific data or result, how will a device know how much space
the driver has allocated for the command_specific_data or
command_specific result?
> +The device compares the length of each part (device-readable and
> +device-writeable) of the buffer as submitted by driver to what it
> +expects and then silently truncates the structures to either the
> +length submitted by the driver, or the length described in this
> +specification, whichever is shorter. The device silently ignores
> +any data falling outside the shorter of the two lengths. Any
> +missing fields are interpreted as set to zero.
> +
> +Similarly, the driver compares the used buffer length
> +of the buffer to what it expects and then silently
> +truncates the structure to the used buffer length.
> +The driver silently ignores any data falling outside
> +the used buffer length reported by the device. Any missing
> +fields are interpreted as set to zero.
> +
> +This simplifies driver and device implementations since the
> +driver/device can simply maintain a single large structure (such
> +as a C structure) for a command and its result. As new versions
> +of the specification are designed, new fields can be added to the
> +tail of a structure, with the driver/device using the full
> +structure without concern for versioning.
> +>>>>>>> 0edc690... admin: introduce virtio admin virtqueues
Merge detritus.
> diff --git a/content.tex b/content.tex
> index ffe45c4..c8647c9 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
> \begin{description}
> \item[0 to 23, and 50 to 127] Feature bits for the specific device type
>
> -\item[24 to 40] Feature bits reserved for extensions to the queue and
> +\item[24 to 41] Feature bits reserved for extensions to the queue and
> feature negotiation mechanisms
>
> -\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
> +\item[42 to 49, and 128 and above] Feature bits reserved for future extensions.
> \end{description}
>
> \begin{note}
> @@ -7682,6 +7682,9 @@ \chapter{Reserved Feature Bits}\label{sec:Reserved Feature Bits}
> that the driver can reset a queue individually.
> See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}.
>
> + \item[VIRTIO_F_ADMIN_VQ(41)] This feature indicates that the device exposes one or more
> + administration virtqueues.
> +
> \end{description}
>
> \drivernormative{\section}{Reserved Feature Bits}{Reserved Feature Bits}
> --
> MST
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that
> generates this mail. Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
--
And removed his hat, in respect of her presence.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-07 10:41 UTC|newest]
Thread overview: 169+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:04 [virtio-dev] [PATCH v10 00/10] Introduce device group and device management Michael S. Tsirkin
2023-03-02 13:04 ` [virtio-dev] [PATCH v10 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-02 23:43 ` [virtio-dev] " Michael S. Tsirkin
[not found] ` <m2leka0yvl.fsf@oracle.com>
2023-03-06 22:00 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 10:04 ` David Edmondson
2023-03-08 14:16 ` Cornelia Huck
2023-03-08 15:04 ` Michael S. Tsirkin
2023-03-02 13:04 ` [virtio-dev] [PATCH v10 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-02 23:44 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 19:40 ` [virtio-dev] Re: [virtio] " Stefan Hajnoczi
2023-03-06 17:00 ` David Edmondson
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 20:19 ` [virtio-dev] " Stefan Hajnoczi
2023-03-03 0:01 ` Michael S. Tsirkin
2023-03-03 13:17 ` Stefan Hajnoczi
2023-03-03 13:19 ` Michael S. Tsirkin
[not found] ` <4f869944-4ccd-c51e-0f30-dc3ba15ffd52@nvidia.com>
2023-03-07 18:33 ` [virtio-dev] " Parav Pandit
2023-03-08 0:34 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 1:01 ` [virtio-dev] " Parav Pandit
2023-03-08 1:06 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 1:14 ` [virtio-dev] " Parav Pandit
[not found] ` <6668fd7a-3eb3-0447-9cbf-72d308b1336a@nvidia.com>
2023-03-08 12:07 ` [virtio-dev] " Michael S. Tsirkin
[not found] ` <992e9a1e-3799-842c-79f3-e66f5c823356@nvidia.com>
2023-03-08 14:43 ` Cornelia Huck
2023-03-08 14:54 ` Michael S. Tsirkin
2023-03-08 15:21 ` Michael S. Tsirkin
[not found] ` <2ef47f53-5978-4b6a-593d-4e94eba0b9ac@nvidia.com>
2023-03-09 6:38 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-02 23:47 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 18:26 ` [virtio-dev] " Parav Pandit
2023-03-02 20:10 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 23:57 ` Michael S. Tsirkin
2023-03-03 13:13 ` Stefan Hajnoczi
2023-03-03 13:18 ` Michael S. Tsirkin
2023-03-03 20:23 ` Stefan Hajnoczi
2023-03-07 11:31 ` Jiri Pirko
2023-03-08 12:03 ` Michael S. Tsirkin
2023-03-07 10:31 ` [virtio-dev] Re: [virtio] " David Edmondson
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 23:48 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 20:40 ` Stefan Hajnoczi
2023-03-03 0:05 ` Michael S. Tsirkin
2023-03-03 13:28 ` Stefan Hajnoczi
2023-03-03 13:37 ` Michael S. Tsirkin
2023-03-03 20:21 ` [virtio-dev] Re: [virtio] " Stefan Hajnoczi
2023-03-05 9:38 ` Michael S. Tsirkin
2023-03-06 0:03 ` Stefan Hajnoczi
2023-03-06 0:18 ` Michael S. Tsirkin
[not found] ` <20230306110340.GA35392@fedora>
2023-03-06 18:37 ` Michael S. Tsirkin
2023-03-06 20:17 ` Stefan Hajnoczi
2023-03-06 21:43 ` Michael S. Tsirkin
2023-03-31 11:07 ` Michael S. Tsirkin
2023-03-07 8:03 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-07 14:39 ` Stefan Hajnoczi
2023-03-07 15:07 ` Jiri Pirko
2023-03-07 19:03 ` Stefan Hajnoczi
2023-03-07 19:09 ` [virtio-dev] " Parav Pandit
2023-03-08 5:17 ` [virtio-dev] Re: [virtio] " Jason Wang
2023-03-08 11:58 ` Stefan Hajnoczi
2023-03-08 11:59 ` Michael S. Tsirkin
2023-03-08 10:17 ` [virtio-dev] " Jiri Pirko
2023-03-08 12:44 ` Stefan Hajnoczi
2023-03-08 12:57 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 17:17 ` Stefan Hajnoczi
2023-03-07 16:13 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 10:08 ` Jiri Pirko
2023-03-08 11:44 ` Michael S. Tsirkin
[not found] ` <7f63fa0a-7deb-5875-6c6b-bfc651681653@redhat.com>
[not found] ` <20230306112030.GB35392@fedora>
[not found] ` <853c78d0-f752-05e9-d79d-811e82801627@nvidia.com>
2023-03-06 16:25 ` [virtio-dev] " Stefan Hajnoczi
2023-03-07 19:04 ` [virtio-dev] " Parav Pandit
[not found] ` <e74483a4-38fa-99b5-86b8-785f0b98d029@nvidia.com>
2023-03-08 14:13 ` [virtio-dev] Re: [virtio-comment] " Stefan Hajnoczi
2023-03-08 16:21 ` [virtio-dev] " Parav Pandit
[not found] ` <18ddbf69-19a6-3c6b-9e42-aaae66e20bcf@nvidia.com>
2023-03-08 17:15 ` [virtio-dev] " Stefan Hajnoczi
2023-03-08 17:21 ` Michael S. Tsirkin
2023-03-09 12:35 ` Stefan Hajnoczi
2023-03-09 13:55 ` Michael S. Tsirkin
2023-03-09 15:56 ` Stefan Hajnoczi
[not found] ` <e8d41902-b794-66e9-8f15-e8617435047c@redhat.com>
2023-03-06 16:22 ` [virtio-dev] " Jiri Pirko
[not found] ` <027fff1b-8ed7-abc0-2331-b188b8822bf4@nvidia.com>
2023-03-06 22:49 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
[not found] ` <e12ab469-4586-f0f5-b084-8f2d7c031e11@nvidia.com>
2023-03-08 21:09 ` Michael S. Tsirkin
2023-03-08 21:17 ` [virtio-dev] " Parav Pandit
2023-03-09 7:28 ` [virtio-dev] " Jiri Pirko
2023-03-07 7:56 ` Jiri Pirko
[not found] ` <ZAXfegxCfvfLwiJT@nanopsycho>
2023-03-06 18:40 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 7:36 ` Jiri Pirko
2023-03-07 16:30 ` Michael S. Tsirkin
2023-03-08 10:05 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-08 11:50 ` Michael S. Tsirkin
2023-03-08 12:08 ` Jiri Pirko
[not found] ` <18d51bc0-d759-1a05-cb7c-3d46c4ed2f1a@nvidia.com>
2023-03-08 18:01 ` David Edmondson
2023-03-08 18:19 ` Jiri Pirko
2023-03-08 21:25 ` [virtio-dev] " Parav Pandit
2023-03-09 7:30 ` [virtio-dev] " Jiri Pirko
2023-03-09 13:04 ` [virtio-dev] " Parav Pandit
2023-03-09 13:57 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 14:02 ` [virtio-dev] " David Edmondson
2023-03-09 14:11 ` Parav Pandit
2023-03-09 14:22 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 14:30 ` [virtio-dev] " Parav Pandit
2023-03-09 14:43 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 16:53 ` [virtio-dev] " Parav Pandit
2023-03-09 17:14 ` [virtio-dev] " Michael S. Tsirkin
2023-03-09 17:16 ` [virtio-dev] " Parav Pandit
2023-03-08 21:45 ` Parav Pandit
2023-03-09 7:37 ` [virtio-dev] " Jiri Pirko
2023-03-09 12:36 ` [virtio-dev] " Parav Pandit
2023-03-09 16:32 ` [virtio-dev] " Jiri Pirko
[not found] ` <17471553-8981-eef9-656b-098e1acdda14@nvidia.com>
2023-03-06 18:44 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 10:41 ` David Edmondson [this message]
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-03-02 20:51 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-03-02 18:40 ` [virtio-dev] " Parav Pandit
2023-03-02 23:51 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 23:51 ` Michael S. Tsirkin
2023-03-03 8:34 ` Michael S. Tsirkin
[not found] ` <ZAXB44F3MS9CxIiK@nanopsycho>
2023-03-06 18:46 ` [virtio-dev] Re: [virtio] " Michael S. Tsirkin
2023-03-07 7:40 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-07 18:52 ` [virtio-dev] " Parav Pandit
2023-03-08 16:24 ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-03-08 16:37 ` [virtio-dev] " Parav Pandit
2023-03-08 16:30 ` [virtio-dev] " Michael S. Tsirkin
2023-03-08 18:21 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-02 20:52 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 07/10] ccw: " Michael S. Tsirkin
2023-03-02 20:53 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 08/10] admin: command list discovery Michael S. Tsirkin
2023-03-02 21:09 ` [virtio-dev] " Stefan Hajnoczi
2023-03-31 11:39 ` Michael S. Tsirkin
2023-03-07 10:54 ` [virtio-dev] " David Edmondson
[not found] ` <ZAXbBgN2jw8RhE/3@nanopsycho>
2023-03-08 11:54 ` Michael S. Tsirkin
2023-03-08 12:41 ` Jiri Pirko
2023-03-31 11:43 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-08 12:38 ` Jiri Pirko
2023-03-10 8:14 ` [virtio-dev] " Zhu, Lingshan
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 09/10] admin: conformance clauses Michael S. Tsirkin
2023-03-07 11:04 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-03-08 11:58 ` Michael S. Tsirkin
2023-03-08 12:59 ` David Edmondson
2023-03-08 13:05 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 13:22 ` Michael S. Tsirkin
2023-03-08 13:44 ` David Edmondson
2023-03-08 14:02 ` Jiri Pirko
2023-03-08 14:12 ` Michael S. Tsirkin
2023-03-10 9:10 ` [virtio-dev] " Zhu, Lingshan
2023-03-10 9:13 ` Michael S. Tsirkin
2023-03-10 18:00 ` Zhu Lingshan
2023-03-10 9:34 ` Michael S. Tsirkin
2023-03-02 13:05 ` [virtio-dev] [PATCH v10 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-03-02 21:12 ` [virtio-dev] " Stefan Hajnoczi
2023-03-02 13:38 ` [virtio-dev] RE: [PATCH v10 00/10] Introduce device group and device management Parav Pandit
2023-03-02 23:27 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 18:39 ` [virtio-dev] " Parav Pandit
2023-03-06 16:40 ` [virtio-dev] Re: [virtio-comment] " Jiri Pirko
2023-03-06 22:48 ` Michael S. Tsirkin
2023-03-07 7:17 ` Jiri Pirko
2023-03-07 17:15 ` Michael S. Tsirkin
[not found] ` <ZAXcqqdwfoLokT2l@nanopsycho>
2023-03-06 22:54 ` Michael S. Tsirkin
2023-03-07 7:21 ` Jiri Pirko
2023-03-07 17:20 ` Michael S. Tsirkin
2023-03-07 19:31 ` [virtio-dev] " Parav Pandit
2023-03-08 5:11 ` [virtio-dev] " Jason Wang
2023-03-08 12:02 ` [virtio-dev] " Parav Pandit
2023-03-10 8:32 ` [virtio-dev] " Zhu, Lingshan
2023-03-08 9:49 ` [virtio-dev] Re: [virtio] " Jiri Pirko
2023-03-08 16:30 ` [virtio-dev] " Cornelia Huck
2023-03-08 17:22 ` Michael S. Tsirkin
2023-03-08 18:15 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fsagzvvo.fsf@oracle.com \
--to=david.edmondson@oracle.com \
--cc=Piotr.Uminski@intel.com \
--cc=cohuck@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nrupal.jani@intel.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).