From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
"mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>
Cc: "sgarzare@redhat.com" <sgarzare@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: [virtio-dev] RE: [PATCH v9 3/8] transport-mmio: Rename QueueNum register
Date: Wed, 29 Mar 2023 15:16:26 +0200 [thread overview]
Message-ID: <87ilejn1ed.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB5481430027FD045C5F78EFD9DC899@PH0PR12MB5481.namprd12.prod.outlook.com>
On Wed, Mar 29 2023, Parav Pandit <parav@nvidia.com> wrote:
>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Wednesday, March 29, 2023 5:16 AM
>>
>> I'm not sure it is worthwile keeping the lines short so aggressively (after all, it
>> does not affect the generated html/pdf), especially as it makes the diff a bit
>> harder to read, but I don't have a strong objection to it.
>>
> I agree, 80 or 100 characters should be reasonable based on Linux kernel experience.
>
> The short line requirement came from [1].
> Shall I change [1] to 80 characters?
>
> [1] https://github.com/oasis-tcs/virtio-spec/blob/b0414098602fbdb0bc5efa4ff06ea6cae8123ed4/_vimrc#L5
I wasn't even aware of that file, as I don't use vim... in any case, 65
seems way too short, especially as many (most?) lines are already longer
than that. 80 (or 100) seems more reasonable.
Michael, do you remember where the 65 came from? Is that anything we
still care about?
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-29 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 20:17 [virtio-dev] [PATCH v9 0/8] Rename queue index to queue number Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 1/8] content: Add vq number text Parav Pandit
2023-03-29 9:01 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-29 9:06 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-29 9:15 ` [virtio-dev] " Cornelia Huck
2023-03-29 12:59 ` [virtio-dev] " Parav Pandit
2023-03-29 13:16 ` Cornelia Huck [this message]
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-29 9:18 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-29 9:23 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-29 9:30 ` [virtio-dev] " Cornelia Huck
2023-03-29 13:01 ` [virtio-dev] " Parav Pandit
2023-03-29 13:18 ` Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilejn1ed.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=jiri@nvidia.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).