From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
mst@redhat.com, virtio-dev@lists.oasis-open.org,
pasic@linux.ibm.com
Cc: sgarzare@redhat.com, virtio-comment@lists.oasis-open.org,
shahafs@nvidia.com, Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number
Date: Wed, 29 Mar 2023 11:30:15 +0200 [thread overview]
Message-ID: <87lejfnbvc.fsf@redhat.com> (raw)
In-Reply-To: <20230328201754.440974-7-parav@nvidia.com>
On Tue, Mar 28 2023, Parav Pandit <parav@nvidia.com> wrote:
> Currently specification uses virtqueue index and
> number interchangeably to refer to the virtqueue.
>
> Instead refer to it by its number.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Signed-off-by: Parav Pandit <parav@nvidia.com>
>
> ---
> changelog:
> v8->v9:
> - replaced 'named' with 'known'
> - replaced 'queue number' with 'vq number'
> v3->v4:
> - moved note to comment
> v2->v3:
> - added comment note for queue_select similar to max_queue_size
> v0->v1:
> - new patch
> ---
> transport-ccw.tex | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/transport-ccw.tex b/transport-ccw.tex
> index 488c46c..0240db8 100644
> --- a/transport-ccw.tex
> +++ b/transport-ccw.tex
> @@ -236,12 +236,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
>
> \begin{lstlisting}
> struct vq_config_block {
> - be16 index;
> + be16 queue_select; /* Previously known as index */
> be16 max_queue_size; /* Previously known as max_num */
Same comment regarding s/Previously/previously/ as for the last patch.
Also, I'm not that happy with the name "queue_select". Sure, it matches
what pci and mmio use, but ccw does not quite use the same mechanism:
vq_config_block is not a structure that always exists where the meaning
of the fields is controlled by a selector field, but a structure that is
provided by the caller and then filled to refer to a certain vq. I'd
prefer this field to be named "vq_num" or something like that.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-29 9:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 20:17 [virtio-dev] [PATCH v9 0/8] Rename queue index to queue number Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 1/8] content: Add vq number text Parav Pandit
2023-03-29 9:01 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-29 9:06 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-29 9:15 ` [virtio-dev] " Cornelia Huck
2023-03-29 12:59 ` [virtio-dev] " Parav Pandit
2023-03-29 13:16 ` Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-29 9:18 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-29 9:23 ` [virtio-dev] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-29 9:30 ` Cornelia Huck [this message]
2023-03-29 13:01 ` [virtio-dev] " Parav Pandit
2023-03-29 13:18 ` Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lejfnbvc.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).