* Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices
[not found] ` <20200729055452.GA31247@mtl-vdi-166.wap.labs.mlnx>
@ 2020-08-03 20:34 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-08-03 20:34 UTC (permalink / raw)
To: Eli Cohen; +Cc: shahafs, parav, linux-kernel, virtualization, saeedm
On Wed, Jul 29, 2020 at 08:54:52AM +0300, Eli Cohen wrote:
> On Tue, Jul 28, 2020 at 02:53:34PM +0800, Jason Wang wrote:
> >
> > Just notice Michael's vhost branch can not compile due to this commit:
> >
> > commit fee8fe6bd8ccacd27e963b71b4f943be3721779e
> > Author: Michael S. Tsirkin <mst@redhat.com>
> > Date:Â Â Mon Jul 27 10:51:55 2020 -0400
> >
> > Â Â Â vdpa: make sure set_features in invoked for legacy
> >
> > Let's wait for Michael to clarify the correct branch to use then.
> >
>
> Michael, are you going to send a path to a git tree that I can rebase my
> series on top of it, or maybe you can just take my v3 and apply them on
> the right tree? If you do, you can take Jason's patches from the series
> he posted here https://lkml.org/lkml/2020/7/1/301 and take my 0003-0010
> patches.
>
> Let me know.
It's a bit too hard to figure out how to put these pieces together, when
I tried I run into some conflicts, and given I can't test them I'd
rather you did this. Please also note kbuild test bot reported a build
failure on mips.
A good tree to base your work on is the linux-next branch
in https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
Thanks!
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices
[not found] <20200728060539.4163-1-eli@mellanox.com>
[not found] ` <1dbac14a-5909-ff0a-8e90-534847f93d50@redhat.com>
@ 2020-08-03 20:51 ` Michael S. Tsirkin
[not found] ` <20200804053432.GB58580@mtl-vdi-166.wap.labs.mlnx>
1 sibling, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-08-03 20:51 UTC (permalink / raw)
To: Eli Cohen; +Cc: shahafs, parav, linux-kernel, virtualization, saeedm
On Tue, Jul 28, 2020 at 09:05:29AM +0300, Eli Cohen wrote:
> Hi Michael,
> please note that this series depends on mlx5 core device driver patches
> in mlx5-next branch in
> git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git.
> git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next
>
> They also depend Jason Wang's patches submitted a couple of weeks ago.
>
> vdpa_sim: use the batching API
> vhost-vdpa: support batch updating
Hmm this makes merging them messy. I can ack merging them through
the mellanox tree, but
conflicts between Jason's patches and what's in my tree also exist.
How big is the dependency? Can I pick it up with your ack?
Also, mips build failures need to be dealt with.
>
>
> The following series of patches provide VDPA support for Mellanox
> devices. The supported devices are ConnectX6 DX and newer.
>
> Currently, only a network driver is implemented; future patches will
> introduce a block device driver. iperf performance on a single queue is
> around 12 Gbps. Future patches will introduce multi queue support.
>
> The files are organized in such a way that code that can be used by
> different VDPA implementations will be placed in a common are resides in
> drivers/vdpa/mlx5/core.
>
> Only virtual functions are currently supported. Also, certain firmware
> capabilities must be set to enable the driver. Physical functions (PFs)
> are skipped by the driver.
>
> To make use of the VDPA net driver, one must load mlx5_vdpa. In such
> case, VFs will be operated by the VDPA driver. Although one can see a
> regular instance of a network driver on the VF, the VDPA driver takes
> precedence over the NIC driver, steering-wize.
>
> Currently, the device/interface infrastructure in mlx5_core is used to
> probe drivers. Future patches will introduce virtbus as a means to
> register devices and drivers and VDPA will be adapted to it.
>
> The mlx5 mode of operation required to support VDPA is switchdev mode.
> Once can use Linux or OVS bridge to take care of layer 2 switching.
>
> In order to provide virtio networking to a guest, an updated version of
> qemu is required. This version has been tested by the following quemu
> version:
>
> url: https://github.com/jasowang/qemu.git
> branch: vdpa
> Commit ID: 6f4e59b807db
>
>
> V2->V3
> Fix makefile to use include path relative to the root of the kernel
>
> Eli Cohen (7):
> net/vdpa: Use struct for set/get vq state
> vhost: Fix documentation
> vdpa: Modify get_vq_state() to return error code
> vdpa/mlx5: Add hardware descriptive header file
> vdpa/mlx5: Add support library for mlx5 VDPA implementation
> vdpa/mlx5: Add shared memory registration code
> vdpa/mlx5: Add VDPA driver for supported mlx5 devices
>
> Jason Wang (2):
> vhost-vdpa: support batch updating
> vdpa_sim: use the batching API
>
> Max Gurtovoy (1):
> vdpa: remove hard coded virtq num
>
> drivers/vdpa/Kconfig | 18 +
> drivers/vdpa/Makefile | 1 +
> drivers/vdpa/ifcvf/ifcvf_base.c | 4 +-
> drivers/vdpa/ifcvf/ifcvf_base.h | 4 +-
> drivers/vdpa/ifcvf/ifcvf_main.c | 13 +-
> drivers/vdpa/mlx5/Makefile | 4 +
> drivers/vdpa/mlx5/core/mlx5_vdpa.h | 91 ++
> drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 ++
> drivers/vdpa/mlx5/core/mr.c | 473 ++++++
> drivers/vdpa/mlx5/core/resources.c | 284 ++++
> drivers/vdpa/mlx5/net/main.c | 76 +
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 1950 ++++++++++++++++++++++++
> drivers/vdpa/mlx5/net/mlx5_vnet.h | 24 +
> drivers/vdpa/vdpa.c | 3 +
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 35 +-
> drivers/vhost/iotlb.c | 4 +-
> drivers/vhost/vdpa.c | 46 +-
> include/linux/vdpa.h | 24 +-
> include/uapi/linux/vhost_types.h | 2 +
> 19 files changed, 3165 insertions(+), 59 deletions(-)
> create mode 100644 drivers/vdpa/mlx5/Makefile
> create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa.h
> create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h
> create mode 100644 drivers/vdpa/mlx5/core/mr.c
> create mode 100644 drivers/vdpa/mlx5/core/resources.c
> create mode 100644 drivers/vdpa/mlx5/net/main.c
> create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.c
> create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
>
> --
> 2.26.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices
[not found] ` <20200804053432.GB58580@mtl-vdi-166.wap.labs.mlnx>
@ 2020-08-04 9:39 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-08-04 9:39 UTC (permalink / raw)
To: Eli Cohen; +Cc: shahafs, parav, linux-kernel, virtualization, saeedm
On Tue, Aug 04, 2020 at 08:34:32AM +0300, Eli Cohen wrote:
> On Mon, Aug 03, 2020 at 04:51:27PM -0400, Michael S. Tsirkin wrote:
> > On Tue, Jul 28, 2020 at 09:05:29AM +0300, Eli Cohen wrote:
> > > Hi Michael,
> > > please note that this series depends on mlx5 core device driver patches
> > > in mlx5-next branch in
> > > git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git.
> > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next
> > >
> > > They also depend Jason Wang's patches submitted a couple of weeks ago.
> > >
> > > vdpa_sim: use the batching API
> > > vhost-vdpa: support batch updating
> >
> > Hmm this makes merging them messy. I can ack merging them through
> > the mellanox tree, but
> > conflicts between Jason's patches and what's in my tree also exist.
> >
>
> Let me see if this is something I can fix.
>
> > How big is the dependency? Can I pick it up with your ack?
> >
> > Also, mips build failures need to be dealt with.
> >
> Will look into it.
Thanks!
I'd like to have everything ready by end of week if possible,
send pull next Monday/Tuesday.
> > >
> > >
> > > The following series of patches provide VDPA support for Mellanox
> > > devices. The supported devices are ConnectX6 DX and newer.
> > >
> > > Currently, only a network driver is implemented; future patches will
> > > introduce a block device driver. iperf performance on a single queue is
> > > around 12 Gbps. Future patches will introduce multi queue support.
> > >
> > > The files are organized in such a way that code that can be used by
> > > different VDPA implementations will be placed in a common are resides in
> > > drivers/vdpa/mlx5/core.
> > >
> > > Only virtual functions are currently supported. Also, certain firmware
> > > capabilities must be set to enable the driver. Physical functions (PFs)
> > > are skipped by the driver.
> > >
> > > To make use of the VDPA net driver, one must load mlx5_vdpa. In such
> > > case, VFs will be operated by the VDPA driver. Although one can see a
> > > regular instance of a network driver on the VF, the VDPA driver takes
> > > precedence over the NIC driver, steering-wize.
> > >
> > > Currently, the device/interface infrastructure in mlx5_core is used to
> > > probe drivers. Future patches will introduce virtbus as a means to
> > > register devices and drivers and VDPA will be adapted to it.
> > >
> > > The mlx5 mode of operation required to support VDPA is switchdev mode.
> > > Once can use Linux or OVS bridge to take care of layer 2 switching.
> > >
> > > In order to provide virtio networking to a guest, an updated version of
> > > qemu is required. This version has been tested by the following quemu
> > > version:
> > >
> > > url: https://github.com/jasowang/qemu.git
> > > branch: vdpa
> > > Commit ID: 6f4e59b807db
> > >
> > >
> > > V2->V3
> > > Fix makefile to use include path relative to the root of the kernel
> > >
> > > Eli Cohen (7):
> > > net/vdpa: Use struct for set/get vq state
> > > vhost: Fix documentation
> > > vdpa: Modify get_vq_state() to return error code
> > > vdpa/mlx5: Add hardware descriptive header file
> > > vdpa/mlx5: Add support library for mlx5 VDPA implementation
> > > vdpa/mlx5: Add shared memory registration code
> > > vdpa/mlx5: Add VDPA driver for supported mlx5 devices
> > >
> > > Jason Wang (2):
> > > vhost-vdpa: support batch updating
> > > vdpa_sim: use the batching API
> > >
> > > Max Gurtovoy (1):
> > > vdpa: remove hard coded virtq num
> > >
> > > drivers/vdpa/Kconfig | 18 +
> > > drivers/vdpa/Makefile | 1 +
> > > drivers/vdpa/ifcvf/ifcvf_base.c | 4 +-
> > > drivers/vdpa/ifcvf/ifcvf_base.h | 4 +-
> > > drivers/vdpa/ifcvf/ifcvf_main.c | 13 +-
> > > drivers/vdpa/mlx5/Makefile | 4 +
> > > drivers/vdpa/mlx5/core/mlx5_vdpa.h | 91 ++
> > > drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h | 168 ++
> > > drivers/vdpa/mlx5/core/mr.c | 473 ++++++
> > > drivers/vdpa/mlx5/core/resources.c | 284 ++++
> > > drivers/vdpa/mlx5/net/main.c | 76 +
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1950 ++++++++++++++++++++++++
> > > drivers/vdpa/mlx5/net/mlx5_vnet.h | 24 +
> > > drivers/vdpa/vdpa.c | 3 +
> > > drivers/vdpa/vdpa_sim/vdpa_sim.c | 35 +-
> > > drivers/vhost/iotlb.c | 4 +-
> > > drivers/vhost/vdpa.c | 46 +-
> > > include/linux/vdpa.h | 24 +-
> > > include/uapi/linux/vhost_types.h | 2 +
> > > 19 files changed, 3165 insertions(+), 59 deletions(-)
> > > create mode 100644 drivers/vdpa/mlx5/Makefile
> > > create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa.h
> > > create mode 100644 drivers/vdpa/mlx5/core/mlx5_vdpa_ifc.h
> > > create mode 100644 drivers/vdpa/mlx5/core/mr.c
> > > create mode 100644 drivers/vdpa/mlx5/core/resources.c
> > > create mode 100644 drivers/vdpa/mlx5/net/main.c
> > > create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> > >
> > > --
> > > 2.26.0
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-04 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200728060539.4163-1-eli@mellanox.com>
[not found] ` <1dbac14a-5909-ff0a-8e90-534847f93d50@redhat.com>
[not found] ` <20200728063211.GA229972@mtl-vdi-166.wap.labs.mlnx>
[not found] ` <ef857921-4b9a-8e48-d5cd-5ef585e8f15c@redhat.com>
[not found] ` <83eb3fdc-83d5-7f88-bef4-602e60c19662@redhat.com>
[not found] ` <20200729055452.GA31247@mtl-vdi-166.wap.labs.mlnx>
2020-08-03 20:34 ` [PATCH V3 vhost next 00/10] VDPA support for Mellanox ConnectX devices Michael S. Tsirkin
2020-08-03 20:51 ` Michael S. Tsirkin
[not found] ` <20200804053432.GB58580@mtl-vdi-166.wap.labs.mlnx>
2020-08-04 9:39 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).