* Re: [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket.
[not found] <20201229110634.275024-1-arseny.krasnov@kaspersky.com>
@ 2020-12-30 20:55 ` Michael S. Tsirkin
2020-12-30 20:58 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2020-12-30 20:55 UTC (permalink / raw)
To: Arseny Krasnov; +Cc: kvm, netdev, linux-kernel, virtualization, Stefan Hajnoczi
On Tue, Dec 29, 2020 at 02:06:33PM +0300, Arseny Krasnov wrote:
> This patch simply adds transport ops and removes
> ignore of non-stream type of packets.
>
> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
How is this supposed to work? virtio vsock at the moment
has byte level end to end credit accounting at the
protocol level. I suspect some protocol changes involving
more than this tweak would
be needed to properly support anything that isn't a stream.
> ---
> drivers/vhost/vsock.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index a483cec31d5c..4a36ef1c52d0 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -346,8 +346,7 @@ vhost_vsock_alloc_pkt(struct vhost_virtqueue *vq,
> return NULL;
> }
>
> - if (le16_to_cpu(pkt->hdr.type) == VIRTIO_VSOCK_TYPE_STREAM)
> - pkt->len = le32_to_cpu(pkt->hdr.len);
> + pkt->len = le32_to_cpu(pkt->hdr.len);
>
> /* No payload */
> if (!pkt->len)
> @@ -416,6 +415,9 @@ static struct virtio_transport vhost_transport = {
> .stream_is_active = virtio_transport_stream_is_active,
> .stream_allow = virtio_transport_stream_allow,
>
> + .seqpacket_seq_send_len = virtio_transport_seqpacket_seq_send_len,
> + .seqpacket_seq_get_len = virtio_transport_seqpacket_seq_get_len,
> +
> .notify_poll_in = virtio_transport_notify_poll_in,
> .notify_poll_out = virtio_transport_notify_poll_out,
> .notify_recv_init = virtio_transport_notify_recv_init,
> --
> 2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket.
2020-12-30 20:55 ` [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket Michael S. Tsirkin
@ 2020-12-30 20:58 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2020-12-30 20:58 UTC (permalink / raw)
To: Arseny Krasnov; +Cc: kvm, netdev, linux-kernel, virtualization, Stefan Hajnoczi
On Wed, Dec 30, 2020 at 03:56:03PM -0500, Michael S. Tsirkin wrote:
> On Tue, Dec 29, 2020 at 02:06:33PM +0300, Arseny Krasnov wrote:
> > This patch simply adds transport ops and removes
> > ignore of non-stream type of packets.
> >
> > Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>
> How is this supposed to work? virtio vsock at the moment
> has byte level end to end credit accounting at the
> protocol level. I suspect some protocol changes involving
> more than this tweak would
> be needed to properly support anything that isn't a stream.
oh this was not threaded correctly so I did not see rest of
patches. ignore this pls will respond there.
> > ---
> > drivers/vhost/vsock.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> > index a483cec31d5c..4a36ef1c52d0 100644
> > --- a/drivers/vhost/vsock.c
> > +++ b/drivers/vhost/vsock.c
> > @@ -346,8 +346,7 @@ vhost_vsock_alloc_pkt(struct vhost_virtqueue *vq,
> > return NULL;
> > }
> >
> > - if (le16_to_cpu(pkt->hdr.type) == VIRTIO_VSOCK_TYPE_STREAM)
> > - pkt->len = le32_to_cpu(pkt->hdr.len);
> > + pkt->len = le32_to_cpu(pkt->hdr.len);
> >
> > /* No payload */
> > if (!pkt->len)
> > @@ -416,6 +415,9 @@ static struct virtio_transport vhost_transport = {
> > .stream_is_active = virtio_transport_stream_is_active,
> > .stream_allow = virtio_transport_stream_allow,
> >
> > + .seqpacket_seq_send_len = virtio_transport_seqpacket_seq_send_len,
> > + .seqpacket_seq_get_len = virtio_transport_seqpacket_seq_get_len,
> > +
> > .notify_poll_in = virtio_transport_notify_poll_in,
> > .notify_poll_out = virtio_transport_notify_poll_out,
> > .notify_recv_init = virtio_transport_notify_recv_init,
> > --
> > 2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-30 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201229110634.275024-1-arseny.krasnov@kaspersky.com>
2020-12-30 20:55 ` [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket Michael S. Tsirkin
2020-12-30 20:58 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).