* [PATCH V4 0/5] virtio: Add virtio-device bindings
@ 2021-07-27 5:23 Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Bartosz Golaszewski, Linus Walleij,
Viresh Kumar
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, linux-gpio,
linux-i2c, Enrico Weigelt, metux IT consult
Hi,
Currently the DT only provides support for following node types for virtio-mmio
nodes:
virtio_mmio@a000000 {
dma-coherent;
interrupts = <0x00 0x10 0x01>;
reg = <0x00 0xa000000 0x00 0x200>;
compatible = "virtio,mmio";
};
Here, each virtio-mmio corresponds to a virtio-device. But there is no way for
other users in the DT to show their dependency on virtio devices.
This patchset provides that support.
The first patch adds virtio-device bindings to allow for device sub-nodes to be
present and the second patch updates the virtio core to update the of_node.
Other patches add bindings for i2c and gpio devices.
Tested on x86 with qemu for arm64.
V3->V4:
- The binding is named "virtio,deviceXXXXXXXX" now.
- The virtio binding doesn't restrict the node names anymore.
- The i2c/gpio nodes are named i2c and gpio now.
- Dropped including gpio.yaml.
- Updated code to match the new binding name.
- Use "type: object" in additional-property.
V2/2.1->V3:
- Added review-tags from Arnd and Wolfram.
- Only the 5th patch changed otherwise:
- Use of_device_is_compatible() instead of keeping a list of devices.
- Use snprintf (with BUG_ON on return value) to create the compatible string,
whose length is fixed using "virtio,XXXXXXXX".
- Use dev_of_node().
V1->V2:
- The changes (both binding and code) are made at virtio level, instead of
virtio-mmio. This allows the same to be used by all device types, irrespective
of the transport mechanism.
- Dropped the reg property and used compatible in the form "virtio,<DID>".
- Dropped dt-bindings/virtio/virtio_ids.h.
- Add a patch to sync virtio-ids from spec, required for the last patch.
--
Viresh
Viresh Kumar (5):
dt-bindings: virtio: Add binding for virtio devices
dt-bindings: i2c: Add bindings for i2c-virtio
dt-bindings: gpio: Add bindings for gpio-virtio
uapi: virtio_ids: Sync ids with specification
virtio: Bind virtio device to device-tree node
.../devicetree/bindings/gpio/gpio-virtio.yaml | 59 +++++++++++++++++++
.../devicetree/bindings/i2c/i2c-virtio.yaml | 51 ++++++++++++++++
.../devicetree/bindings/virtio/mmio.yaml | 3 +-
.../bindings/virtio/virtio-device.yaml | 41 +++++++++++++
drivers/virtio/virtio.c | 57 +++++++++++++++++-
include/uapi/linux/virtio_ids.h | 12 ++++
6 files changed, 219 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
@ 2021-07-27 5:23 ` Viresh Kumar
2021-08-02 19:40 ` Rob Herring
2021-07-27 5:23 ` [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
` (5 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Viresh Kumar
Cc: devicetree, Vincent Guittot, Bill Mills, linux-kernel,
virtualization, Enrico Weigelt, metux IT consult
Allow virtio device sub-nodes to be added to the virtio mmio or pci
nodes. The compatible property for virtio device must be of the format
"virtio,device<ID>", where ID is virtio device ID in hexadecimal format.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
.../devicetree/bindings/virtio/mmio.yaml | 3 +-
.../bindings/virtio/virtio-device.yaml | 41 +++++++++++++++++++
2 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml
diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
index d46597028cf1..4b7a0273181c 100644
--- a/Documentation/devicetree/bindings/virtio/mmio.yaml
+++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
@@ -36,7 +36,8 @@ title: virtio memory mapped devices
- reg
- interrupts
-additionalProperties: false
+additionalProperties:
+ type: object
examples:
- |
diff --git a/Documentation/devicetree/bindings/virtio/virtio-device.yaml b/Documentation/devicetree/bindings/virtio/virtio-device.yaml
new file mode 100644
index 000000000000..1778ea9b5aa5
--- /dev/null
+++ b/Documentation/devicetree/bindings/virtio/virtio-device.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/virtio/virtio-device.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Virtio device bindings
+
+maintainers:
+ - Viresh Kumar <viresh.kumar@linaro.org>
+
+description:
+ These bindings are applicable to virtio devices irrespective of the bus they
+ are bound to, like mmio or pci.
+
+# We need a select here so we don't match all nodes with 'virtio,mmio'
+properties:
+ compatible:
+ pattern: "^virtio,device[0-9a-f]{1,8}$"
+ description: Virtio device nodes.
+ "virtio,deviceID", where ID is the virtio device id. The textual
+ representation of ID shall be in lower case hexadecimal with leading
+ zeroes suppressed.
+
+required:
+ - compatible
+
+additionalProperties: true
+
+examples:
+ - |
+ virtio@3000 {
+ compatible = "virtio,mmio";
+ reg = <0x3000 0x100>;
+ interrupts = <43>;
+
+ i2c {
+ compatible = "virtio,device22";
+ };
+ };
+...
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
@ 2021-07-27 5:23 ` Viresh Kumar
2021-08-02 19:41 ` Rob Herring
2021-07-27 5:23 ` [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Viresh Kumar
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, linux-i2c,
Enrico Weigelt, metux IT consult
This patch adds binding for virtio I2C device, it is based on
virtio-device bindings.
Acked-by: Wolfram Sang <wsa@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
.../devicetree/bindings/i2c/i2c-virtio.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
diff --git a/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml b/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
new file mode 100644
index 000000000000..7d87ed855301
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-virtio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Virtio I2C Adapter
+
+maintainers:
+ - Viresh Kumar <viresh.kumar@linaro.org>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+ - $ref: /schemas/virtio/virtio-device.yaml#
+
+description:
+ Virtio I2C device, see /schemas/virtio/virtio-device.yaml for more details.
+
+properties:
+ $nodename:
+ const: i2c
+
+ compatible:
+ const: virtio,device22
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ virtio@3000 {
+ compatible = "virtio,mmio";
+ reg = <0x3000 0x100>;
+ interrupts = <41>;
+
+ i2c {
+ compatible = "virtio,device22";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ light-sensor@20 {
+ compatible = "dynaimage,al3320a";
+ reg = <0x20>;
+ };
+ };
+ };
+
+...
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
@ 2021-07-27 5:23 ` Viresh Kumar
2021-08-02 19:40 ` Rob Herring
2021-07-27 5:23 ` [PATCH V4 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
` (3 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Linus Walleij, Bartosz Golaszewski,
Viresh Kumar
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, linux-gpio, Enrico Weigelt,
metux IT consult
This patch adds binding for virtio GPIO controller, it is based on
virtio-device bindings.
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
.../devicetree/bindings/gpio/gpio-virtio.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml b/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
new file mode 100644
index 000000000000..601d85754577
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/gpio-virtio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Virtio GPIO controller
+
+maintainers:
+ - Viresh Kumar <viresh.kumar@linaro.org>
+
+allOf:
+ - $ref: /schemas/virtio/virtio-device.yaml#
+
+description:
+ Virtio GPIO controller, see /schemas/virtio/virtio-device.yaml for more
+ details.
+
+properties:
+ $nodename:
+ const: gpio
+
+ compatible:
+ const: virtio,device29
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+required:
+ - compatible
+ - gpio-controller
+ - "#gpio-cells"
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ virtio@3000 {
+ compatible = "virtio,mmio";
+ reg = <0x3000 0x100>;
+ interrupts = <41>;
+
+ gpio {
+ compatible = "virtio,device29";
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+
+...
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH V4 4/5] uapi: virtio_ids: Sync ids with specification
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
` (2 preceding siblings ...)
2021-07-27 5:23 ` [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
@ 2021-07-27 5:23 ` Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
` (2 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker
Cc: Enrico Weigelt, metux IT consult, Vincent Guittot, devicetree,
Viresh Kumar, Bill Mills, linux-kernel, virtualization
This synchronizes the virtio ids with the latest list from virtio
specification.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
include/uapi/linux/virtio_ids.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
index 70a8057ad4bb..3c8e11820fdb 100644
--- a/include/uapi/linux/virtio_ids.h
+++ b/include/uapi/linux/virtio_ids.h
@@ -54,8 +54,20 @@
#define VIRTIO_ID_SOUND 25 /* virtio sound */
#define VIRTIO_ID_FS 26 /* virtio filesystem */
#define VIRTIO_ID_PMEM 27 /* virtio pmem */
+#define VIRTIO_ID_RPMB 28 /* virtio rpmb */
#define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */
+#define VIRTIO_ID_VIDEO_ENCODER 30 /* virtio video encoder */
+#define VIRTIO_ID_VIDEO_DECODER 31 /* virtio video decoder */
+#define VIRTIO_ID_SCMI 32 /* virtio scmi */
+#define VIRTIO_ID_NITRO_SEC_MOD 33 /* virtio nitro secure module*/
+#define VIRTIO_ID_I2C_ADAPTER 34 /* virtio i2c adapter */
+#define VIRTIO_ID_WATCHDOG 35 /* virtio watchdog */
+#define VIRTIO_ID_CAN 36 /* virtio can */
+#define VIRTIO_ID_DMABUF 37 /* virtio dmabuf */
+#define VIRTIO_ID_PARAM_SERV 38 /* virtio parameter server */
+#define VIRTIO_ID_AUDIO_POLICY 39 /* virtio audio policy */
#define VIRTIO_ID_BT 40 /* virtio bluetooth */
+#define VIRTIO_ID_GPIO 41 /* virtio gpio */
/*
* Virtio Transitional IDs
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH V4 5/5] virtio: Bind virtio device to device-tree node
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
` (3 preceding siblings ...)
2021-07-27 5:23 ` [PATCH V4 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
@ 2021-07-27 5:23 ` Viresh Kumar
2021-08-04 3:56 ` [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-08-31 5:31 ` Viresh Kumar
6 siblings, 0 replies; 16+ messages in thread
From: Viresh Kumar @ 2021-07-27 5:23 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker
Cc: Enrico Weigelt, metux IT consult, Vincent Guittot, Arnd Bergmann,
devicetree, Viresh Kumar, Bill Mills, linux-kernel,
virtualization
Bind the virtio devices with their of_node. This will help users of the
virtio devices to mention their dependencies on the device in the DT
itself. Like GPIO pin users can use the phandle of the device node, or
the node may contain more subnodes to add i2c or spi eeproms and other
users.
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/virtio/virtio.c | 57 ++++++++++++++++++++++++++++++++++++++---
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 4b15c00c0a0a..5f80786c2aa2 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -4,6 +4,7 @@
#include <linux/virtio_config.h>
#include <linux/module.h>
#include <linux/idr.h>
+#include <linux/of.h>
#include <uapi/linux/virtio_ids.h>
/* Unique numbering for virtio devices. */
@@ -292,6 +293,9 @@ static int virtio_dev_remove(struct device *_d)
/* Acknowledge the device's existence again. */
virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
+
+ of_node_put(dev->dev.of_node);
+
return 0;
}
@@ -319,6 +323,43 @@ void unregister_virtio_driver(struct virtio_driver *driver)
}
EXPORT_SYMBOL_GPL(unregister_virtio_driver);
+static int virtio_device_of_init(struct virtio_device *dev)
+{
+ struct device_node *np, *pnode = dev_of_node(dev->dev.parent);
+ char compat[] = "virtio,deviceXXXXXXXX";
+ int ret, count;
+
+ if (!pnode)
+ return 0;
+
+ count = of_get_available_child_count(pnode);
+ if (!count)
+ return 0;
+
+ /* There can be only 1 child node */
+ if (WARN_ON(count > 1))
+ return -EINVAL;
+
+ np = of_get_next_available_child(pnode, NULL);
+ if (WARN_ON(!np))
+ return -ENODEV;
+
+ ret = snprintf(compat, sizeof(compat), "virtio,device%x", dev->id.device);
+ BUG_ON(ret >= sizeof(compat));
+
+ if (!of_device_is_compatible(np, compat)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ dev->dev.of_node = np;
+ return 0;
+
+out:
+ of_node_put(np);
+ return ret;
+}
+
/**
* register_virtio_device - register virtio device
* @dev : virtio device to be registered
@@ -343,6 +384,10 @@ int register_virtio_device(struct virtio_device *dev)
dev->index = err;
dev_set_name(&dev->dev, "virtio%u", dev->index);
+ err = virtio_device_of_init(dev);
+ if (err)
+ goto out_ida_remove;
+
spin_lock_init(&dev->config_lock);
dev->config_enabled = false;
dev->config_change_pending = false;
@@ -362,10 +407,16 @@ int register_virtio_device(struct virtio_device *dev)
*/
err = device_add(&dev->dev);
if (err)
- ida_simple_remove(&virtio_index_ida, dev->index);
+ goto out_of_node_put;
+
+ return 0;
+
+out_of_node_put:
+ of_node_put(dev->dev.of_node);
+out_ida_remove:
+ ida_simple_remove(&virtio_index_ida, dev->index);
out:
- if (err)
- virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
+ virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
return err;
}
EXPORT_SYMBOL_GPL(register_virtio_device);
--
2.31.1.272.g89b43f80a514
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
2021-07-27 5:23 ` [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
@ 2021-08-02 19:40 ` Rob Herring
2021-08-03 4:30 ` Viresh Kumar
0 siblings, 1 reply; 16+ messages in thread
From: Rob Herring @ 2021-08-02 19:40 UTC (permalink / raw)
To: Viresh Kumar
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult,
Michael S. Tsirkin, linux-kernel, virtualization,
Bartosz Golaszewski, devicetree, linux-gpio, Linus Walleij,
Bill Mills
On Tue, Jul 27, 2021 at 10:53:50AM +0530, Viresh Kumar wrote:
> This patch adds binding for virtio GPIO controller, it is based on
> virtio-device bindings.
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/gpio/gpio-virtio.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml b/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
> new file mode 100644
> index 000000000000..601d85754577
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-virtio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Virtio GPIO controller
> +
> +maintainers:
> + - Viresh Kumar <viresh.kumar@linaro.org>
> +
> +allOf:
> + - $ref: /schemas/virtio/virtio-device.yaml#
> +
> +description:
> + Virtio GPIO controller, see /schemas/virtio/virtio-device.yaml for more
> + details.
> +
> +properties:
> + $nodename:
> + const: gpio
> +
> + compatible:
> + const: virtio,device29
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
Humm, how does one implement interrupts without a parent interrupt? It
uses the parent virtio,mmio interrupt?
> +
> +required:
> + - compatible
> + - gpio-controller
> + - "#gpio-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + virtio@3000 {
> + compatible = "virtio,mmio";
> + reg = <0x3000 0x100>;
> + interrupts = <41>;
> +
> + gpio {
> + compatible = "virtio,device29";
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> +...
> --
> 2.31.1.272.g89b43f80a514
>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices
2021-07-27 5:23 ` [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
@ 2021-08-02 19:40 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2021-08-02 19:40 UTC (permalink / raw)
To: Viresh Kumar
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
Michael S. Tsirkin, linux-kernel, virtualization, Rob Herring,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult
On Tue, 27 Jul 2021 10:53:48 +0530, Viresh Kumar wrote:
> Allow virtio device sub-nodes to be added to the virtio mmio or pci
> nodes. The compatible property for virtio device must be of the format
> "virtio,device<ID>", where ID is virtio device ID in hexadecimal format.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/virtio/mmio.yaml | 3 +-
> .../bindings/virtio/virtio-device.yaml | 41 +++++++++++++++++++
> 2 files changed, 43 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio
2021-07-27 5:23 ` [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
@ 2021-08-02 19:41 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2021-08-02 19:41 UTC (permalink / raw)
To: Viresh Kumar
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Michael S. Tsirkin, Enrico Weigelt, metux IT consult, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, devicetree,
Rob Herring, linux-i2c, Jean-Philippe Brucker
On Tue, 27 Jul 2021 10:53:49 +0530, Viresh Kumar wrote:
> This patch adds binding for virtio I2C device, it is based on
> virtio-device bindings.
>
> Acked-by: Wolfram Sang <wsa@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/i2c/i2c-virtio.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
2021-08-02 19:40 ` Rob Herring
@ 2021-08-03 4:30 ` Viresh Kumar
2021-08-03 15:47 ` Rob Herring
0 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-08-03 4:30 UTC (permalink / raw)
To: Rob Herring
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult,
Michael S. Tsirkin, linux-kernel, virtualization,
Bartosz Golaszewski, devicetree, linux-gpio, Linus Walleij,
Bill Mills
On 02-08-21, 13:40, Rob Herring wrote:
> Humm, how does one implement interrupts without a parent interrupt? It
> uses the parent virtio,mmio interrupt?
Kind of, yeah, but not necessarily.
The interrupt information is passed over buffers shared between host and guest.
Now the guest may process the buffers when it receives a notification from the
host, that will be at downpath of an interrupt for virtio,mmio. Or the guest may
poll on the virtqueue and process any buffers as soon as they are made
available, no interrupts then.
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
2021-08-03 4:30 ` Viresh Kumar
@ 2021-08-03 15:47 ` Rob Herring
2021-08-04 3:49 ` Viresh Kumar
0 siblings, 1 reply; 16+ messages in thread
From: Rob Herring @ 2021-08-03 15:47 UTC (permalink / raw)
To: Viresh Kumar
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult,
Michael S. Tsirkin, linux-kernel,
open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE,
Bartosz Golaszewski, devicetree, open list:GPIO SUBSYSTEM,
Linus Walleij, Bill Mills
n Mon, Aug 2, 2021 at 10:30 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 02-08-21, 13:40, Rob Herring wrote:
> > Humm, how does one implement interrupts without a parent interrupt? It
> > uses the parent virtio,mmio interrupt?
>
> Kind of, yeah, but not necessarily.
>
> The interrupt information is passed over buffers shared between host and guest.
> Now the guest may process the buffers when it receives a notification from the
> host, that will be at downpath of an interrupt for virtio,mmio. Or the guest may
> poll on the virtqueue and process any buffers as soon as they are made
> available, no interrupts then.
Okay, thanks for the explanation.
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio
2021-08-03 15:47 ` Rob Herring
@ 2021-08-04 3:49 ` Viresh Kumar
0 siblings, 0 replies; 16+ messages in thread
From: Viresh Kumar @ 2021-08-04 3:49 UTC (permalink / raw)
To: Rob Herring
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult,
Michael S. Tsirkin, linux-kernel,
open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE,
Bartosz Golaszewski, devicetree, open list:GPIO SUBSYSTEM,
Linus Walleij, Bill Mills
On 03-08-21, 09:47, Rob Herring wrote:
> n Mon, Aug 2, 2021 at 10:30 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > On 02-08-21, 13:40, Rob Herring wrote:
> > > Humm, how does one implement interrupts without a parent interrupt? It
> > > uses the parent virtio,mmio interrupt?
> >
> > Kind of, yeah, but not necessarily.
> >
> > The interrupt information is passed over buffers shared between host and guest.
> > Now the guest may process the buffers when it receives a notification from the
> > host, that will be at downpath of an interrupt for virtio,mmio. Or the guest may
> > poll on the virtqueue and process any buffers as soon as they are made
> > available, no interrupts then.
>
> Okay, thanks for the explanation.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks for reviewing this Rob.
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 0/5] virtio: Add virtio-device bindings
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
` (4 preceding siblings ...)
2021-07-27 5:23 ` [PATCH V4 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
@ 2021-08-04 3:56 ` Viresh Kumar
2021-08-11 5:38 ` Viresh Kumar
2021-08-31 5:31 ` Viresh Kumar
6 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-08-04 3:56 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Bartosz Golaszewski, Linus Walleij
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, linux-gpio,
linux-i2c, Enrico Weigelt, metux IT consult
On 27-07-21, 10:53, Viresh Kumar wrote:
> Hi,
>
> Currently the DT only provides support for following node types for virtio-mmio
> nodes:
>
> virtio_mmio@a000000 {
> dma-coherent;
> interrupts = <0x00 0x10 0x01>;
> reg = <0x00 0xa000000 0x00 0x200>;
> compatible = "virtio,mmio";
> };
>
> Here, each virtio-mmio corresponds to a virtio-device. But there is no way for
> other users in the DT to show their dependency on virtio devices.
>
> This patchset provides that support.
>
> The first patch adds virtio-device bindings to allow for device sub-nodes to be
> present and the second patch updates the virtio core to update the of_node.
>
> Other patches add bindings for i2c and gpio devices.
>
> Tested on x86 with qemu for arm64.
Michael,
I hope you will be picking this series (Now that it is reviewed by
others) ? Just so you know, Wolfram needs the 4th patch, 4/5, to base
the virtio-i2c driver over it and has requested an immutable branch
for the same.
Thanks.
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 0/5] virtio: Add virtio-device bindings
2021-08-04 3:56 ` [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
@ 2021-08-11 5:38 ` Viresh Kumar
0 siblings, 0 replies; 16+ messages in thread
From: Viresh Kumar @ 2021-08-11 5:38 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Bartosz Golaszewski, Linus Walleij
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, linux-gpio,
linux-i2c, Enrico Weigelt, metux IT consult
On 04-08-21, 09:26, Viresh Kumar wrote:
> Michael,
>
> I hope you will be picking this series (Now that it is reviewed by
> others) ? Just so you know, Wolfram needs the 4th patch, 4/5, to base
> the virtio-i2c driver over it and has requested an immutable branch
> for the same.
Michael, we need an immutable branch with the following patch:
uapi: virtio_ids: Sync ids with specification
This will enable Wolfram to apply the I2C driver for 5.15-rc1 and
maybe Linus as well for the GPIO driver.
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 0/5] virtio: Add virtio-device bindings
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
` (5 preceding siblings ...)
2021-08-04 3:56 ` [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
@ 2021-08-31 5:31 ` Viresh Kumar
2021-08-31 14:25 ` Michael S. Tsirkin
6 siblings, 1 reply; 16+ messages in thread
From: Viresh Kumar @ 2021-08-31 5:31 UTC (permalink / raw)
To: Jason Wang, Michael S. Tsirkin, Rob Herring, Arnd Bergmann,
Jean-Philippe Brucker, Bartosz Golaszewski, Linus Walleij
Cc: devicetree, Vincent Guittot, Arnd Bergmann, Bill Mills,
linux-kernel, virtualization, Wolfram Sang, linux-gpio,
linux-i2c, Enrico Weigelt, metux IT consult
On 27-07-21, 10:53, Viresh Kumar wrote:
> Hi,
>
> Currently the DT only provides support for following node types for virtio-mmio
> nodes:
>
> virtio_mmio@a000000 {
> dma-coherent;
> interrupts = <0x00 0x10 0x01>;
> reg = <0x00 0xa000000 0x00 0x200>;
> compatible = "virtio,mmio";
> };
>
> Here, each virtio-mmio corresponds to a virtio-device. But there is no way for
> other users in the DT to show their dependency on virtio devices.
>
> This patchset provides that support.
>
> The first patch adds virtio-device bindings to allow for device sub-nodes to be
> present and the second patch updates the virtio core to update the of_node.
>
> Other patches add bindings for i2c and gpio devices.
>
> Tested on x86 with qemu for arm64.
Michael, are you picking these up for 5.15 ?
--
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V4 0/5] virtio: Add virtio-device bindings
2021-08-31 5:31 ` Viresh Kumar
@ 2021-08-31 14:25 ` Michael S. Tsirkin
0 siblings, 0 replies; 16+ messages in thread
From: Michael S. Tsirkin @ 2021-08-31 14:25 UTC (permalink / raw)
To: Viresh Kumar
Cc: Arnd Bergmann, Vincent Guittot, Arnd Bergmann,
Jean-Philippe Brucker, Enrico Weigelt, metux IT consult,
linux-kernel, virtualization, Wolfram Sang, Bartosz Golaszewski,
devicetree, Rob Herring, linux-i2c, linux-gpio, Linus Walleij,
Bill Mills
On Tue, Aug 31, 2021 at 11:01:05AM +0530, Viresh Kumar wrote:
> On 27-07-21, 10:53, Viresh Kumar wrote:
> > Hi,
> >
> > Currently the DT only provides support for following node types for virtio-mmio
> > nodes:
> >
> > virtio_mmio@a000000 {
> > dma-coherent;
> > interrupts = <0x00 0x10 0x01>;
> > reg = <0x00 0xa000000 0x00 0x200>;
> > compatible = "virtio,mmio";
> > };
> >
> > Here, each virtio-mmio corresponds to a virtio-device. But there is no way for
> > other users in the DT to show their dependency on virtio devices.
> >
> > This patchset provides that support.
> >
> > The first patch adds virtio-device bindings to allow for device sub-nodes to be
> > present and the second patch updates the virtio core to update the of_node.
> >
> > Other patches add bindings for i2c and gpio devices.
> >
> > Tested on x86 with qemu for arm64.
>
> Michael, are you picking these up for 5.15 ?
Okay.
> --
> viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-08-31 14:25 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 5:23 [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-08-02 19:40 ` Rob Herring
2021-07-27 5:23 ` [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
2021-08-02 19:41 ` Rob Herring
2021-07-27 5:23 ` [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
2021-08-02 19:40 ` Rob Herring
2021-08-03 4:30 ` Viresh Kumar
2021-08-03 15:47 ` Rob Herring
2021-08-04 3:49 ` Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
2021-07-27 5:23 ` [PATCH V4 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
2021-08-04 3:56 ` [PATCH V4 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-08-11 5:38 ` Viresh Kumar
2021-08-31 5:31 ` Viresh Kumar
2021-08-31 14:25 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).