* Re: [PATCH 0/9] use canonical ftrace path whenever possible
[not found] <20230130181915.1113313-1-zwisler@google.com>
@ 2023-01-30 19:26 ` Michael S. Tsirkin
[not found] ` <20230130181915.1113313-8-zwisler@google.com>
1 sibling, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2023-01-30 19:26 UTC (permalink / raw)
To: Ross Zwisler
Cc: Mark Rutland, kvm, Alexander Shishkin, Alexei Starovoitov,
virtualization, Song Liu, Huang Rui, Stanislav Fomichev,
linux-kselftest, Todd E Brandt, Shuah Khan, Mykola Lysenko,
Leon Romanovsky, linux-rdma, John Fastabend, Andrii Nakryiko,
Jason Gunthorpe, Ingo Molnar, Yonghong Song, linux-trace-kernel,
linux-pm, Ross Zwisler, Arnaldo Carvalho de Melo, KP Singh,
linux-hardening, Steven Rostedt, Namhyung Kim, bpf, Hao Luo,
Daniel Borkmann, linux-mm, linux-kernel, linux-perf-users,
Peter Zijlstra, Masami Hiramatsu, Jiri Olsa, Paolo Bonzini,
Andrew Morton, Martin KaFai Lau, Tycho Andersen,
Tobin C. Harding
On Mon, Jan 30, 2023 at 11:19:06AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is typically located at /sys/kernel/debug/tracing.
> For backward compatibility, when mounting the debugfs file system,
> the tracefs file system will be automatically mounted at:
>
> /sys/kernel/debug/tracing
>
> There are many places where this older debugfs path is still used in
> code comments, selftests, examples and tools, so let's update them to
> avoid confusion.
>
> I've broken up the series as best I could by maintainer or directory,
> and I've only sent people the patches that I think they care about to
> avoid spamming everyone.
>
> Ross Zwisler (9):
> tracing: always use canonical ftrace path
> bpf: use canonical ftrace path
> selftests/bpf: use canonical ftrace path
> perf docs: use canonical ftrace path
> tools/power: use canonical ftrace path
> selftests: use canonical ftrace path
> tools/virtio: use canonical ftrace path
> leaking_addresses: also skip canonical ftrace path
> tools/kvm_stat: use canonical ftrace path
>
> include/linux/kernel.h | 2 +-
> include/linux/tracepoint.h | 4 ++--
> include/uapi/linux/bpf.h | 8 ++++----
> kernel/trace/Kconfig | 20 +++++++++----------
> kernel/trace/kprobe_event_gen_test.c | 2 +-
> kernel/trace/ring_buffer.c | 2 +-
> kernel/trace/synth_event_gen_test.c | 2 +-
> kernel/trace/trace.c | 2 +-
> samples/bpf/cpustat_kern.c | 4 ++--
> samples/bpf/hbm.c | 4 ++--
> samples/bpf/ibumad_kern.c | 4 ++--
> samples/bpf/lwt_len_hist.sh | 2 +-
> samples/bpf/offwaketime_kern.c | 2 +-
> samples/bpf/task_fd_query_user.c | 4 ++--
> samples/bpf/test_lwt_bpf.sh | 2 +-
> samples/bpf/test_overhead_tp_kern.c | 4 ++--
> samples/user_events/example.c | 4 ++--
> scripts/leaking_addresses.pl | 1 +
> scripts/tracing/draw_functrace.py | 6 +++---
> scripts/tracing/ftrace-bisect.sh | 4 ++--
> tools/include/uapi/linux/bpf.h | 8 ++++----
> tools/kvm/kvm_stat/kvm_stat | 2 +-
> tools/lib/api/fs/tracing_path.c | 4 ++--
> tools/lib/traceevent/event-parse.c | 8 ++++----
> tools/perf/Documentation/perf-list.txt | 2 +-
> tools/perf/Documentation/perf-script-perl.txt | 2 +-
> .../perf/Documentation/perf-script-python.txt | 4 ++--
> tools/power/pm-graph/sleepgraph.py | 4 ++--
> .../x86/amd_pstate_tracer/amd_pstate_trace.py | 4 ++--
> .../intel_pstate_tracer.py | 10 +++++-----
> .../selftests/bpf/get_cgroup_id_user.c | 2 +-
> .../bpf/prog_tests/kprobe_multi_test.c | 2 +-
> .../bpf/prog_tests/task_fd_query_tp.c | 2 +-
> .../bpf/prog_tests/tp_attach_query.c | 2 +-
> .../selftests/bpf/prog_tests/trace_printk.c | 2 +-
> .../selftests/bpf/prog_tests/trace_vprintk.c | 2 +-
> .../selftests/bpf/progs/test_stacktrace_map.c | 2 +-
> .../selftests/bpf/progs/test_tracepoint.c | 2 +-
> tools/testing/selftests/bpf/test_ftrace.sh | 2 +-
> tools/testing/selftests/bpf/test_tunnel.sh | 8 ++++----
> tools/testing/selftests/bpf/trace_helpers.c | 4 ++--
> .../testing/selftests/user_events/dyn_test.c | 2 +-
> .../selftests/user_events/ftrace_test.c | 10 +++++-----
> .../testing/selftests/user_events/perf_test.c | 8 ++++----
> tools/testing/selftests/vm/protection_keys.c | 4 ++--
> tools/tracing/latency/latency-collector.c | 2 +-
> tools/virtio/virtio-trace/README | 2 +-
> tools/virtio/virtio-trace/trace-agent.c | 2 +-
> 48 files changed, 96 insertions(+), 95 deletions(-)
>
> --
> 2.39.1.456.gfc5497dd1b-goog
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 7/9] tools/virtio: use canonical ftrace path
[not found] ` <20230130181915.1113313-8-zwisler@google.com>
@ 2023-01-30 19:26 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2023-01-30 19:26 UTC (permalink / raw)
To: Ross Zwisler
Cc: Ross Zwisler, linux-kernel, Steven Rostedt, virtualization,
linux-trace-kernel
On Mon, Jan 30, 2023 at 11:19:13AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is typically located at /sys/kernel/debug/tracing.
> For backward compatibility, when mounting the debugfs file system,
> the tracefs file system will be automatically mounted at:
>
> /sys/kernel/debug/tracing
>
> A few spots in tools/virtio still refer to this older debugfs
> path, so let's update them to avoid confusion.
>
> Signed-off-by: Ross Zwisler <zwisler@google.com>
> ---
> tools/virtio/virtio-trace/README | 2 +-
> tools/virtio/virtio-trace/trace-agent.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virtio/virtio-trace/README b/tools/virtio/virtio-trace/README
> index b64845b823ab..cea29a2a4c0a 100644
> --- a/tools/virtio/virtio-trace/README
> +++ b/tools/virtio/virtio-trace/README
> @@ -95,7 +95,7 @@ Run
>
> 1) Enable ftrace in the guest
> <Example>
> - # echo 1 > /sys/kernel/debug/tracing/events/sched/enable
> + # echo 1 > /sys/kernel/tracing/events/sched/enable
>
> 2) Run trace agent in the guest
> This agent must be operated as root.
> diff --git a/tools/virtio/virtio-trace/trace-agent.c b/tools/virtio/virtio-trace/trace-agent.c
> index cdfe77c2b4c8..805942d02e9f 100644
> --- a/tools/virtio/virtio-trace/trace-agent.c
> +++ b/tools/virtio/virtio-trace/trace-agent.c
> @@ -19,7 +19,7 @@
> #define PIPE_MIN_SIZE (PAGE_SIZE*PIPE_DEF_BUFS)
> #define PIPE_MAX_SIZE (1024*1024)
> #define READ_PATH_FMT \
> - "/sys/kernel/debug/tracing/per_cpu/cpu%d/trace_pipe_raw"
> + "/sys/kernel/tracing/per_cpu/cpu%d/trace_pipe_raw"
Should we try both old and new path then?
> #define WRITE_PATH_FMT "/dev/virtio-ports/trace-path-cpu%d"
> #define CTL_PATH "/dev/virtio-ports/agent-ctl-path"
>
> --
> 2.39.1.456.gfc5497dd1b-goog
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-30 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230130181915.1113313-1-zwisler@google.com>
2023-01-30 19:26 ` [PATCH 0/9] use canonical ftrace path whenever possible Michael S. Tsirkin
[not found] ` <20230130181915.1113313-8-zwisler@google.com>
2023-01-30 19:26 ` [PATCH 7/9] tools/virtio: use canonical ftrace path Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).