* Re: [PATCH] virtio-crypto: Do not use GFP_ATOMIC when not needed
[not found] <00f487d16bf9fc5ce215c44bed3f11df5adf266a.1675544037.git.christophe.jaillet@wanadoo.fr>
@ 2023-02-10 9:49 ` Herbert Xu
0 siblings, 0 replies; only message in thread
From: Herbert Xu @ 2023-02-10 9:49 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Michael S. Tsirkin, kernel-janitors, linux-kernel,
virtualization, linux-crypto, David S. Miller
On Sat, Feb 04, 2023 at 09:54:08PM +0100, Christophe JAILLET wrote:
> There is no need to use GFP_ATOMIC here. GFP_KERNEL is already used for
> another memory allocation just the line after.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative ! ! !
>
> Maybe it is the other memory allocation that should use GFP_ATOMIC.
>
> Review with care !
Looks correct to me. We don't support calling akcipher in atomic
contexts.
> ---
> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-10 10:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <00f487d16bf9fc5ce215c44bed3f11df5adf266a.1675544037.git.christophe.jaillet@wanadoo.fr>
2023-02-10 9:49 ` [PATCH] virtio-crypto: Do not use GFP_ATOMIC when not needed Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).