wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
* commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64
@ 2019-06-15 16:10 Andriy Perev Ortkin
  2019-06-18 16:24 ` Jason A. Donenfeld
  0 siblings, 1 reply; 3+ messages in thread
From: Andriy Perev Ortkin @ 2019-06-15 16:10 UTC (permalink / raw)
  To: wireguard

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

commit https://git.zx2c4.com/WireGuard/commit/?id=799895f27f3d63d2e92a5c1c411205ae70f2a5ca
breaks out of tree module build on arm64 , kernel 5.1.10
strangely when building x86_64 everything is fine

  CC [M]  /home/asavah/kross/src/WireGuard/src/main.o
In file included from /home/asavah/kross/src/WireGuard/src/compat/compat.h:824,
                 from <command-line>:
./include/linux/timekeeping.h:67:8: error: unknown type name ‘ktime_t’
   67 | extern ktime_t ktime_get(void);
      |        ^~~~~~~

The following patch fixes the issue, however I have no idea why x86_64
builds fine and arm64 does not,
neither I'm sure that the patch is right, it fixed the issue for me tho.

[-- Attachment #2: 001-ktime.patch --]
[-- Type: application/octet-stream, Size: 427 bytes --]

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 614f458..5ba9b67 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -821,6 +821,7 @@ static inline void skb_mark_not_on_list(struct sk_buff *skb)
 #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
 #include <linux/hrtimer.h>
 #else
+#include <linux/ktime.h>
 #include <linux/timekeeping.h>
 #endif
 static inline s64 __our_ktime_get_coarse_boottime(void)

[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64
  2019-06-15 16:10 commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64 Andriy Perev Ortkin
@ 2019-06-18 16:24 ` Jason A. Donenfeld
  2019-06-18 19:03   ` Jason A. Donenfeld
  0 siblings, 1 reply; 3+ messages in thread
From: Jason A. Donenfeld @ 2019-06-18 16:24 UTC (permalink / raw)
  To: Andriy Perev Ortkin; +Cc: WireGuard mailing list

Thanks. I'll fix this.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64
  2019-06-18 16:24 ` Jason A. Donenfeld
@ 2019-06-18 19:03   ` Jason A. Donenfeld
  0 siblings, 0 replies; 3+ messages in thread
From: Jason A. Donenfeld @ 2019-06-18 19:03 UTC (permalink / raw)
  To: Andriy Perev Ortkin; +Cc: WireGuard mailing list

Let me know if the latest master branch works for you.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-18 19:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-15 16:10 commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64 Andriy Perev Ortkin
2019-06-18 16:24 ` Jason A. Donenfeld
2019-06-18 19:03   ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).