Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator

Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator

[Simon Horman]

On Fri, Mar 08, 2024 at 03:27:44AM -0800, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the wireguard driver and leverage the network
> core allocation instead.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <horms@kernel.org>

...

Re: [PATCH net-next v2 2/2] wireguard: Remove generic .ndo_get_stats64

[Simon Horman]

On Fri, Mar 08, 2024 at 03:27:45AM -0800, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <horms@kernel.org>

...

Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator

[Jason A. Donenfeld]

I applied this series to the wireguard tree. Thanks for the patches.

Jason

Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator

[Jason A. Donenfeld]

On Wed, Mar 13, 2024 at 9:24 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> I applied this series to the wireguard tree. Thanks for the patches.

Actually, sorry, nevermind. 1/2 is fine, but 2/2 results in `ip -stats
link ...` returning all zeros.

Jason

Re: [PATCH net-next v2 1/2] wireguard: Leverage core stats allocator

[Jason A. Donenfeld]

On Wed, Mar 13, 2024 at 9:27 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On Wed, Mar 13, 2024 at 9:24 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >
> > I applied this series to the wireguard tree. Thanks for the patches.
>
> Actually, sorry, nevermind. 1/2 is fine, but 2/2 results in `ip -stats
> link ...` returning all zeros.

Ahh, okay, required some more commits from 6.8. Okay, seems to be
working. I'll let this cook a bit and then push it up in a while.


Jason